From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933063AbcKPU3R (ORCPT ); Wed, 16 Nov 2016 15:29:17 -0500 Received: from mail-it0-f48.google.com ([209.85.214.48]:35716 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752679AbcKPU3P (ORCPT ); Wed, 16 Nov 2016 15:29:15 -0500 MIME-Version: 1.0 In-Reply-To: <20161116192331.2jwpewu33dwji3fa@pengutronix.de> References: <1477585631-18574-1-git-send-email-ard.biesheuvel@linaro.org> <20161116192331.2jwpewu33dwji3fa@pengutronix.de> From: Ard Biesheuvel Date: Wed, 16 Nov 2016 20:29:13 +0000 Message-ID: Subject: Re: [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Michael Ellerman , jeyu@redhat.com, Benjamin Herrenschmidt , Rusty Russell , Will Deacon , "paulus@samba.org" , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAGKTMLK005582 On 16 November 2016 at 19:23, Uwe Kleine-König wrote: > On Thu, Oct 27, 2016 at 05:27:08PM +0100, Ard Biesheuvel wrote: >> This series is a followup to the single patch 'modversions: treat symbol >> CRCs as 32 bit quantities on 64 bit archs', of which two versions have >> been sent out so far [0][1] >> >> As pointed out by Michael, GNU ld behaves a bit differently between arm64 >> and PowerPC64, and where the former gets rid of all runtime relocations >> related to CRCs, the latter is not as easily convinced. >> >> Patch #1 fixes the issue where CRCs are corrupted by the runtime relocation >> routines for 32-bit PowerPC, for which the original fix was effectively >> reverted by commit 0e0ed6406e61 ("powerpc/modules: Module CRC relocation fix >> causes perf issues") >> >> Patch #2 adds handling of R_PPC64_ADDR32 relocations against the NULL .dynsym >> symbol entry to the PPC64 runtime relocation routines, so it is prepared to >> deal with CRCs being emitted as 32-bit quantities. >> >> Patch #3 is the original patch from the v1 and v2 submissions. > > Is this related to me seeing > > [ 2.111424] mvneta: module verification failed: signature and/or required key missing - tainting kernel > [ 2.126061] scsi_mod: no symbol version for _clear_bit > [ 2.131257] scsi_mod: Unknown symbol _clear_bit (err -22) > [ 2.138093] mvneta: no symbol version for _clear_bit > [ 2.143117] mvneta: Unknown symbol _clear_bit (err -22) > [ 2.144135] mvmdio: no symbol version for __gnu_mcount_nc > [ 2.144138] mvmdio: Unknown symbol __gnu_mcount_nc (err -22) > ... > > ? If so, this would be great to mention it in the commit log to make > people searching for this issue actually find this patch set. > No, I don't think it is. My guess would be that it is caused by https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4dd1837d75 From mboxrd@z Thu Jan 1 00:00:00 1970 From: ard.biesheuvel@linaro.org (Ard Biesheuvel) Date: Wed, 16 Nov 2016 20:29:13 +0000 Subject: [PATCH v3 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y In-Reply-To: <20161116192331.2jwpewu33dwji3fa@pengutronix.de> References: <1477585631-18574-1-git-send-email-ard.biesheuvel@linaro.org> <20161116192331.2jwpewu33dwji3fa@pengutronix.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16 November 2016 at 19:23, Uwe Kleine-K?nig wrote: > On Thu, Oct 27, 2016 at 05:27:08PM +0100, Ard Biesheuvel wrote: >> This series is a followup to the single patch 'modversions: treat symbol >> CRCs as 32 bit quantities on 64 bit archs', of which two versions have >> been sent out so far [0][1] >> >> As pointed out by Michael, GNU ld behaves a bit differently between arm64 >> and PowerPC64, and where the former gets rid of all runtime relocations >> related to CRCs, the latter is not as easily convinced. >> >> Patch #1 fixes the issue where CRCs are corrupted by the runtime relocation >> routines for 32-bit PowerPC, for which the original fix was effectively >> reverted by commit 0e0ed6406e61 ("powerpc/modules: Module CRC relocation fix >> causes perf issues") >> >> Patch #2 adds handling of R_PPC64_ADDR32 relocations against the NULL .dynsym >> symbol entry to the PPC64 runtime relocation routines, so it is prepared to >> deal with CRCs being emitted as 32-bit quantities. >> >> Patch #3 is the original patch from the v1 and v2 submissions. > > Is this related to me seeing > > [ 2.111424] mvneta: module verification failed: signature and/or required key missing - tainting kernel > [ 2.126061] scsi_mod: no symbol version for _clear_bit > [ 2.131257] scsi_mod: Unknown symbol _clear_bit (err -22) > [ 2.138093] mvneta: no symbol version for _clear_bit > [ 2.143117] mvneta: Unknown symbol _clear_bit (err -22) > [ 2.144135] mvmdio: no symbol version for __gnu_mcount_nc > [ 2.144138] mvmdio: Unknown symbol __gnu_mcount_nc (err -22) > ... > > ? If so, this would be great to mention it in the commit log to make > people searching for this issue actually find this patch set. > No, I don't think it is. My guess would be that it is caused by https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4dd1837d75