All of lore.kernel.org
 help / color / mirror / Atom feed
From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFT PATCH 1/2] ARM: module: split core and init PLT sections
Date: Tue, 21 Feb 2017 17:35:44 +0000	[thread overview]
Message-ID: <CAKv+Gu-qPuVjw4BMdDkWx8jmW2Vt-Uiv7xz-PcTCvMm18+SLWQ@mail.gmail.com> (raw)
In-Reply-To: <CAMZqy1CWNC2aL4Qhp2C9M0POuU4juz2=L8WpoihRUdWT6uhiGg@mail.gmail.com>

On 21 February 2017 at 14:26, Angus Clark <angus@angusclark.org> wrote:
> Hi Ard,
>
> I have tested the patch and I think there is still a small issue.  At
> present, count_plts() assumes a PLT entry would only be required for
> undefined symbols.  However, if 'init' and 'core' are located far
> apart, then we may need an entry in the init PLT if some init code
> makes a call to a defined symbol in the core section.
>

Argh. You're absolutely right, another complication I did not
anticipate, unfortunately.

> As a quick test, I added an 'include_defined' argument to count_plts()
> which gets set for init relocs.  With this in place, the module loads
> fine and appears to function as expected.
>
> Happy to test any further versions :-)
>

Thanks, v2 coming up

  reply	other threads:[~2017-02-21 17:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20 22:00 [RFT PATCH 0/2] ARM/arm64: module-plt: split core and init PLT sections Ard Biesheuvel
2017-02-20 22:00 ` [RFT PATCH 1/2] ARM: module: " Ard Biesheuvel
2017-02-21 14:26   ` Angus Clark
2017-02-21 17:35     ` Ard Biesheuvel [this message]
2017-02-23 15:45   ` Ard Biesheuvel
2017-02-20 22:00 ` [RFT PATCH 2/2] arm64: " Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu-qPuVjw4BMdDkWx8jmW2Vt-Uiv7xz-PcTCvMm18+SLWQ@mail.gmail.com \
    --to=ard.biesheuvel@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.