All of lore.kernel.org
 help / color / mirror / Atom feed
From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: multi_v7_defconfig: enable some newly added crypto modules
Date: Tue, 28 Feb 2017 14:04:55 +0000	[thread overview]
Message-ID: <CAKv+Gu89zRKXkORpttoOPFw8WUAdJ+mLnGKvqbAYHYUUquPJqg@mail.gmail.com> (raw)
In-Reply-To: <68af3dce-14ce-b464-3b75-479759402f8a@nvidia.com>

 On 28 February 2017 at 14:01, Jon Hunter <jonathanh@nvidia.com> wrote:
>
> On 15/02/17 18:30, Ard Biesheuvel wrote:
>> Enable the new accelerated CRC32(C), CRC-T10DIF and ChaCha20 drivers
>> as modules for multi_v7_defconfig builds.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>>  arch/arm/configs/multi_v7_defconfig | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
>> index b01a43851294..597e56047747 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -936,6 +936,9 @@ CONFIG_CRYPTO_SHA512_ARM=m
>>  CONFIG_CRYPTO_AES_ARM=m
>>  CONFIG_CRYPTO_AES_ARM_BS=m
>>  CONFIG_CRYPTO_AES_ARM_CE=m
>> +CONFIG_CRYPTO_CHACHA20_NEON=m
>> +CONFIG_CRYPTO_CRC32_ARM_CE=m
>> +CONFIG_CRYPTO_CRCT10DIF_ARM_CE=m
>>  CONFIG_CRYPTO_GHASH_ARM_CE=m
>>  CONFIG_CRYPTO_DEV_ATMEL_AES=m
>>  CONFIG_CRYPTO_DEV_ATMEL_TDES=m
>
> Now these are enabled by default, I see the following error ...
>
> AS [M]  arch/arm/crypto/crc32-ce-core.o
> arch/arm/crypto/crc32-ce-core.S: Assembler messages:
> arch/arm/crypto/crc32-ce-core.S:56: Error: unknown architecture `crc'
>
> arch/arm/crypto/crc32-ce-core.S:138: Error: bad type for scalar -- `vmov dCONSTANTl[0],CRC'
> arch/arm/crypto/crc32-ce-core.S:300: Error: bad instruction `crc32w r0,r0,r2'
> arch/arm/crypto/crc32-ce-core.S:300: Error: bad instruction `crc32w r0,r0,r3'
> arch/arm/crypto/crc32-ce-core.S:300: Error: bad instruction `crc32w r0,r0,r3'
> arch/arm/crypto/crc32-ce-core.S:300: Error: bad instruction `crc32h r0,r0,r3'
> arch/arm/crypto/crc32-ce-core.S:300: Error: bad instruction `crc32b r0,r0,r3'
> arch/arm/crypto/crc32-ce-core.S:300: Error: bad instruction `crc32b r0,r0,r3'
> arch/arm/crypto/crc32-ce-core.S:300: Error: bad instruction `crc32h r0,r0,r3'
> arch/arm/crypto/crc32-ce-core.S:305: Error: bad instruction `crc32cw r0,r0,r2'
> arch/arm/crypto/crc32-ce-core.S:305: Error: bad instruction `crc32cw r0,r0,r3'
> arch/arm/crypto/crc32-ce-core.S:305: Error: bad instruction `crc32cw r0,r0,r3'
> arch/arm/crypto/crc32-ce-core.S:305: Error: bad instruction `crc32ch r0,r0,r3'
> arch/arm/crypto/crc32-ce-core.S:305: Error: bad instruction `crc32cb r0,r0,r3'
> arch/arm/crypto/crc32-ce-core.S:305: Error: bad instruction `crc32cb r0,r0,r3'
> arch/arm/crypto/crc32-ce-core.S:305: Error: bad instruction `crc32ch r0,r0,r3'
> scripts/Makefile.build:395: recipe for target 'arch/arm/crypto/crc32-ce-core.o' failed
> make[1]: *** [arch/arm/crypto/crc32-ce-core.o] Error 1
>
> Yes this is with an older toolchain that uses an older assembler (GNU assembler
> (crosstool-NG linaro-1.13.1-4.7-2013.04-20130415 - Linaro GCC 2013.04) 2.23.1),
> however, I am curious if older toolchains not supporting the 'crc' arch_extension
> are deprecated now?
>

Hello Jon,

This is surprising: this implies that there are toolchain that do
support the crypto-neon-fp-armv8 FPU type but not the scalar (i.e.,
non-NEON) CRC instructions. We could easily fix this by adding another
build time test, I just didn't expect we'd need one

      reply	other threads:[~2017-02-28 14:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 18:30 [PATCH] ARM: multi_v7_defconfig: enable some newly added crypto modules Ard Biesheuvel
2017-02-16 16:21 ` Arnd Bergmann
2017-02-28 14:01 ` Jon Hunter
2017-02-28 14:04   ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu89zRKXkORpttoOPFw8WUAdJ+mLnGKvqbAYHYUUquPJqg@mail.gmail.com \
    --to=ard.biesheuvel@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.