From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1B50C4360C for ; Sun, 13 Oct 2019 06:29:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DAD020663 for ; Sun, 13 Oct 2019 06:29:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ShHctQMI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727382AbfJMG3u (ORCPT ); Sun, 13 Oct 2019 02:29:50 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:37885 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbfJMG3u (ORCPT ); Sun, 13 Oct 2019 02:29:50 -0400 Received: by mail-wm1-f65.google.com with SMTP id f22so13677430wmc.2 for ; Sat, 12 Oct 2019 23:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KcJ7Kv1ST9YbGxqx4tgfEVL19WmMfSIFjEryHkrxqaM=; b=ShHctQMIAMUEsc4GsPIKwVo7BaxtA/IH8w/7Imj4tm0mGBrIFwVfV7ELQaSvJSlEjc r6G/5eGmPT4AmRnsFXTU4hud3uI5T8lcoG6t5Au5+2XmTznxgF7jdxBXqGCwcPofCqiN K8ePCjmhAVEQSOS48hJ3Ap0yr4Ev4qvnWlpkyPNwMoYW65uFF7td0WNt8yC+znjxNxhf f87SIcJ/405TP5H1YSlhz/FYH42vWWIP+YIzS6Fm4lGkEVwyJHIVSgmli91yQqv2xHrr 6JCiVL8HkhUVImkuKO9S/LYvzH8u8opYzoSE8JUpL4OTKI0HYsQenqJNA0qkll1KaqGB luZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KcJ7Kv1ST9YbGxqx4tgfEVL19WmMfSIFjEryHkrxqaM=; b=r+Z+9C1PLZ3SrFyCAnFamFEvanQtI/97pXZTxD80pxVZ7NZpGzNI7kFuFTX6HU5zXk 6jRpwAh4upXAjymgG26DJCkGHmJDn8hHCXMx2Ao5X8ck19HA4mALf1yBW4F5Fmi0fQBP F/fst7JSmPPg+Thc/6LlSIoBWS9crBJtFoxtAQpcpd1JOjujwnL6N8s5i9tMhbEB1ev2 4oN7YMeW64CPfCZLf6AYllJIhPj2jnl4PW1XsVj7VuVvWBET5tdyI0CQOLaM9NDHe9EW bjqRoNabEb4gZGcNW2KA5fK5jWQ3IhcKoWEq7QrUqmAEQk9ShE+vxJMcwtEtVMLGCzZm w8Qg== X-Gm-Message-State: APjAAAXykiKIBUMYAObp3rUQyl0ZWMKceYys2iRMIubVZWumcvmx1/Kc BKyrY/oMbo2Gl0gZTW+kOmUSDlNgvABv4kpphQ7fhg== X-Google-Smtp-Source: APXvYqxQOJKzj7kLS8VKcVx0K23FigMu5lWnFTg7n8/Dbq+Wi535YTj5c3SXPfhU3OGjcDrK5VwCQXY8VlhZG3vRdGQ= X-Received: by 2002:a7b:ce01:: with SMTP id m1mr9465516wmc.136.1570948187865; Sat, 12 Oct 2019 23:29:47 -0700 (PDT) MIME-Version: 1.0 References: <20191013043918.337113-1-ebiggers@kernel.org> In-Reply-To: <20191013043918.337113-1-ebiggers@kernel.org> From: Ard Biesheuvel Date: Sun, 13 Oct 2019 08:29:35 +0200 Message-ID: Subject: Re: [PATCH 0/4] crypto: nx - convert to skcipher API To: Eric Biggers Cc: "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Herbert Xu , linuxppc-dev , =?UTF-8?Q?Breno_Leit=C3=A3o?= , Nayna Jain , Paulo Flabiano Smorigo Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, 13 Oct 2019 at 06:40, Eric Biggers wrote: > > This series converts the PowerPC Nest (NX) implementations of AES modes > from the deprecated "blkcipher" API to the "skcipher" API. This is > needed in order for the blkcipher API to be removed. > > This patchset is compile-tested only, as I don't have this hardware. > If anyone has this hardware, please test this patchset with > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y. > > Eric Biggers (4): > crypto: nx - don't abuse blkcipher_desc to pass iv around > crypto: nx - convert AES-ECB to skcipher API > crypto: nx - convert AES-CBC to skcipher API > crypto: nx - convert AES-CTR to skcipher API > > drivers/crypto/nx/nx-aes-cbc.c | 81 ++++++++++++++----------------- > drivers/crypto/nx/nx-aes-ccm.c | 40 ++++++---------- > drivers/crypto/nx/nx-aes-ctr.c | 87 +++++++++++++++------------------- > drivers/crypto/nx/nx-aes-ecb.c | 76 +++++++++++++---------------- > drivers/crypto/nx/nx-aes-gcm.c | 24 ++++------ > drivers/crypto/nx/nx.c | 64 ++++++++++++++----------- > drivers/crypto/nx/nx.h | 19 ++++---- > 7 files changed, 176 insertions(+), 215 deletions(-) > Hi Eric, Thanks for taking this on. I'll look in more detail at these patches during the week. In the meantime, I may have a stab at converting ccp, virtio-crypto and omap aes/des myself, since i have the hardware to test those. Thanks, Ard. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22782C4360C for ; Sun, 13 Oct 2019 06:31:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EB55206B7 for ; Sun, 13 Oct 2019 06:31:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ShHctQMI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EB55206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46rX0V607ZzDqjk for ; Sun, 13 Oct 2019 17:31:54 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ShHctQMI"; dkim-atps=neutral Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46rWyG28XQzDqjX for ; Sun, 13 Oct 2019 17:29:52 +1100 (AEDT) Received: by mail-wm1-x342.google.com with SMTP id b24so13677071wmj.5 for ; Sat, 12 Oct 2019 23:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KcJ7Kv1ST9YbGxqx4tgfEVL19WmMfSIFjEryHkrxqaM=; b=ShHctQMIAMUEsc4GsPIKwVo7BaxtA/IH8w/7Imj4tm0mGBrIFwVfV7ELQaSvJSlEjc r6G/5eGmPT4AmRnsFXTU4hud3uI5T8lcoG6t5Au5+2XmTznxgF7jdxBXqGCwcPofCqiN K8ePCjmhAVEQSOS48hJ3Ap0yr4Ev4qvnWlpkyPNwMoYW65uFF7td0WNt8yC+znjxNxhf f87SIcJ/405TP5H1YSlhz/FYH42vWWIP+YIzS6Fm4lGkEVwyJHIVSgmli91yQqv2xHrr 6JCiVL8HkhUVImkuKO9S/LYvzH8u8opYzoSE8JUpL4OTKI0HYsQenqJNA0qkll1KaqGB luZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KcJ7Kv1ST9YbGxqx4tgfEVL19WmMfSIFjEryHkrxqaM=; b=HGv7Wt9FFvZfJX5tGHXglTgIEn24aeab8jG3rYKHO7jRQScSjQWnbiwnU52PcwYETU Wj6Bk9UxyzMkx/tuih3vOLkjybhdopJGunRXnqV4dttuK5iBdsLq1Zp5V5I5JttQdfQy aRMrQS7hT/BMzFoYH/qOfGbUKRzSLjmXn4Eq5lz6oMDbFwzMbWD46FKyt3IMsb4Z0kg8 xt802gdwWCcLaGADV1D/RypzTqr0FIeFRBjiwOgWxhQk8wpI8DaP5evTKjSYY1OrvGRX nIhJYNnSHm9i5CRmuLgBw1uQ3+cBkhDM5ZOokzXhAToMl0+rsg7UYDli2uW6gU0HrJpI aM1Q== X-Gm-Message-State: APjAAAXr3lXSxFCqftmkzs77vyy2YosTrauaepBPot/g9emNDSY2BT9j MmvafHz5jvEOeXjQI9/13WIi1Wk2LapqAfgQE5wP5A== X-Google-Smtp-Source: APXvYqxQOJKzj7kLS8VKcVx0K23FigMu5lWnFTg7n8/Dbq+Wi535YTj5c3SXPfhU3OGjcDrK5VwCQXY8VlhZG3vRdGQ= X-Received: by 2002:a7b:ce01:: with SMTP id m1mr9465516wmc.136.1570948187865; Sat, 12 Oct 2019 23:29:47 -0700 (PDT) MIME-Version: 1.0 References: <20191013043918.337113-1-ebiggers@kernel.org> In-Reply-To: <20191013043918.337113-1-ebiggers@kernel.org> From: Ard Biesheuvel Date: Sun, 13 Oct 2019 08:29:35 +0200 Message-ID: Subject: Re: [PATCH 0/4] crypto: nx - convert to skcipher API To: Eric Biggers Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Herbert Xu , Nayna Jain , Paulo Flabiano Smorigo , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , =?UTF-8?Q?Breno_Leit=C3=A3o?= , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, 13 Oct 2019 at 06:40, Eric Biggers wrote: > > This series converts the PowerPC Nest (NX) implementations of AES modes > from the deprecated "blkcipher" API to the "skcipher" API. This is > needed in order for the blkcipher API to be removed. > > This patchset is compile-tested only, as I don't have this hardware. > If anyone has this hardware, please test this patchset with > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y. > > Eric Biggers (4): > crypto: nx - don't abuse blkcipher_desc to pass iv around > crypto: nx - convert AES-ECB to skcipher API > crypto: nx - convert AES-CBC to skcipher API > crypto: nx - convert AES-CTR to skcipher API > > drivers/crypto/nx/nx-aes-cbc.c | 81 ++++++++++++++----------------- > drivers/crypto/nx/nx-aes-ccm.c | 40 ++++++---------- > drivers/crypto/nx/nx-aes-ctr.c | 87 +++++++++++++++------------------- > drivers/crypto/nx/nx-aes-ecb.c | 76 +++++++++++++---------------- > drivers/crypto/nx/nx-aes-gcm.c | 24 ++++------ > drivers/crypto/nx/nx.c | 64 ++++++++++++++----------- > drivers/crypto/nx/nx.h | 19 ++++---- > 7 files changed, 176 insertions(+), 215 deletions(-) > Hi Eric, Thanks for taking this on. I'll look in more detail at these patches during the week. In the meantime, I may have a stab at converting ccp, virtio-crypto and omap aes/des myself, since i have the hardware to test those. Thanks, Ard.