From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3421C3A5A7 for ; Wed, 4 Sep 2019 13:02:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9A5D2339D for ; Wed, 4 Sep 2019 13:02:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OpobEe6f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730258AbfIDNCX (ORCPT ); Wed, 4 Sep 2019 09:02:23 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55461 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727929AbfIDNCX (ORCPT ); Wed, 4 Sep 2019 09:02:23 -0400 Received: by mail-wm1-f67.google.com with SMTP id g207so3211258wmg.5 for ; Wed, 04 Sep 2019 06:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XYc/WH2seI0xG53pu04DpOsVrDgCeSJvzPVy1Wb7xbc=; b=OpobEe6f+1X770rq3d1rRf53pMVcgDaDEKe/WovlDp2hG/tqPnfNk5zQL1yR5IXJYF 1MOTewq98YCQHq/Qu51mnCqQgtFbvHRRrMZ1+RGH0XfLfY6vCw6Dlf98UjtK/a+kDkuk nNsbIV8a1uNN66skhbYXIn4MVV0MeZM/TnE/j0BzdJTkbG0Nzg0kOh4ZJUZQtOh7vC/h bIEWGp3OWkoRDE2kZoGRRjicvsFXw0aeLn0495+eVPjpkaUDvVQNEfgQ3uSgctfx0TPl D8364k+W38v403LkqfHJzbpKJHFHRtkk4JMoBJI0YcJJFrX68HXQqL7xURr3fLiOJNV9 6UKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XYc/WH2seI0xG53pu04DpOsVrDgCeSJvzPVy1Wb7xbc=; b=gq0pRzS9iQjY4Eu/F4+tUvT4jE+VlQwwbCDKE0PQ2JWgiEDyrwIj/Y7WSslY2q0Aix nvChbkVzlSFtKBOEjuMzunemJ1+GgQPWcjKq3X2r/3SuX7mdRXsMZFfMdasOeCSDUTYD Mph+fCwyzfclKK18JloCqjaZ7bEkJNXf9PGo0BOlXj0+pl7F9iw08OC6sJ6BILYYwevE oohRq5js3yg+pxU8RuLSGSk7W5gbbQd9GfZ4KVTdSvgP8wNEmltkv/7Yo4NuIPmQiIdG 3nmephPMoHfCisrx5UPHohaIpYyWA60C4MxDe66OnEx843lp7B+DwocQdKlnpMi1XpXR gtDQ== X-Gm-Message-State: APjAAAUf6dyBRE4lXyCyb+Fvdeo2Y5cWNHsVldVPC2XRgl15ox+KC8UR 14pA/44l3aLQ4Xs0+lwTo5/OPLteEOufcCK1t9a/dw== X-Google-Smtp-Source: APXvYqyCgK6btzLgwwnSgv74jEoWQoHI8ozi7jcw7cQUQdxzdOcrwHxKh0kRXd8ctiQN4glkzmopK4ioCeAsyCa3ItY= X-Received: by 2002:a1c:3cc3:: with SMTP id j186mr4129045wma.119.1567602141735; Wed, 04 Sep 2019 06:02:21 -0700 (PDT) MIME-Version: 1.0 References: <20190901203532.2615-1-hdegoede@redhat.com> In-Reply-To: <20190901203532.2615-1-hdegoede@redhat.com> From: Ard Biesheuvel Date: Wed, 4 Sep 2019 06:02:09 -0700 Message-ID: Subject: Re: [PATCH 0/9] crypto: sha256 - Merge crypto/sha256.h into crypto/sha.h To: Hans de Goede Cc: Herbert Xu , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Russell King , Catalin Marinas , Will Deacon , Gilad Ben-Yossef , Atul Gupta , Marc Zyngier , Eric Biggers , Andy Lutomirski , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "the arch/x86 maintainers" , linux-s390 , linux-efi , Linux Kernel Mailing List , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, 1 Sep 2019 at 13:35, Hans de Goede wrote: > > Hi All, > > As promised here is a follow-up series to my earlier sha256 series. > > Note I have only compiled and tested this series on x86_64 !! > > All changes to architecture specific code on other archs have not even > been tested to compile! With that said most of these changes were done > using my editors search - replace function so things should be fine... > (and FWIW I did do a Kconfig hack to compile test the ccree change). > > The first patch in this series rename various file local functions / > arrays to avoid conflicts with the new include/crypto/sha256.h, followed > by a patch merging include/crypto/sha256.h into include/crypto/sha.h. > > The last patch makes use of this merging to remove a bit more code > duplication, making sha256_generic use sha256_init and sha224_init from > lib/crypto/sha256.c. An added advantage of this, is that this gives these > 2 functions coverage by the crypto selftests. > For the series, Acked-by: Ard Biesheuvel Thanks Hans. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com ([209.85.128.68]:55462 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730254AbfIDNCY (ORCPT ); Wed, 4 Sep 2019 09:02:24 -0400 Received: by mail-wm1-f68.google.com with SMTP id g207so3211262wmg.5 for ; Wed, 04 Sep 2019 06:02:22 -0700 (PDT) MIME-Version: 1.0 References: <20190901203532.2615-1-hdegoede@redhat.com> In-Reply-To: <20190901203532.2615-1-hdegoede@redhat.com> From: Ard Biesheuvel Date: Wed, 4 Sep 2019 06:02:09 -0700 Message-ID: Subject: Re: [PATCH 0/9] crypto: sha256 - Merge crypto/sha256.h into crypto/sha.h Content-Type: text/plain; charset="UTF-8" Sender: linux-s390-owner@vger.kernel.org List-ID: To: Hans de Goede Cc: Herbert Xu , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Russell King , Catalin Marinas , Will Deacon , Gilad Ben-Yossef , Atul Gupta , Marc Zyngier , Eric Biggers , Andy Lutomirski , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , the arch/x86 maintainers , linux-s390 , linux-efi , Linux Kernel Mailing List , linux-arm-kernel On Sun, 1 Sep 2019 at 13:35, Hans de Goede wrote: > > Hi All, > > As promised here is a follow-up series to my earlier sha256 series. > > Note I have only compiled and tested this series on x86_64 !! > > All changes to architecture specific code on other archs have not even > been tested to compile! With that said most of these changes were done > using my editors search - replace function so things should be fine... > (and FWIW I did do a Kconfig hack to compile test the ccree change). > > The first patch in this series rename various file local functions / > arrays to avoid conflicts with the new include/crypto/sha256.h, followed > by a patch merging include/crypto/sha256.h into include/crypto/sha.h. > > The last patch makes use of this merging to remove a bit more code > duplication, making sha256_generic use sha256_init and sha224_init from > lib/crypto/sha256.c. An added advantage of this, is that this gives these > 2 functions coverage by the crypto selftests. > For the series, Acked-by: Ard Biesheuvel Thanks Hans. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 485D2C3A5A7 for ; Wed, 4 Sep 2019 13:02:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A9412073F for ; Wed, 4 Sep 2019 13:02:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q7rXaFja"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OpobEe6f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A9412073F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NpX3xoI9nIqM0r+G0JpQynDtTSEHkFTDn9CWMtnkE1A=; b=q7rXaFjaCqjtV2 loZKkFIX3UvEqSZWiq5s3DYi4XZbhTNdaYTIaA3grc8Ed5gdu/0wKLIZ3gyOf/06eYyMJk7KV6/2c ot8A4c30psxK4T/ELJOqeDeL89a8YJIREqelQ2i8yjgnCr9W/ZqxJE3DYdBMkyblAF5JOQglkN8qW vjpMrdHiBqD4nGlENQqAJ21V1p+f3onlAkzRL49iIrCs+4MhhuZKuyV+QNpVYLMU3BlkuuVJk3YOu qYgHSn0k9F9Ytj7ao+ue9As44WFOVc3x/pgJdeenuApHlRA0c8z4gaP9z4rDwULU1Axp08gMAywlW qeaR+GliKGA9kHF9flpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5Uvn-0002ve-QM; Wed, 04 Sep 2019 13:02:39 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5Uva-0002i2-3A for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2019 13:02:27 +0000 Received: by mail-wm1-x342.google.com with SMTP id t17so3230702wmi.2 for ; Wed, 04 Sep 2019 06:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XYc/WH2seI0xG53pu04DpOsVrDgCeSJvzPVy1Wb7xbc=; b=OpobEe6f+1X770rq3d1rRf53pMVcgDaDEKe/WovlDp2hG/tqPnfNk5zQL1yR5IXJYF 1MOTewq98YCQHq/Qu51mnCqQgtFbvHRRrMZ1+RGH0XfLfY6vCw6Dlf98UjtK/a+kDkuk nNsbIV8a1uNN66skhbYXIn4MVV0MeZM/TnE/j0BzdJTkbG0Nzg0kOh4ZJUZQtOh7vC/h bIEWGp3OWkoRDE2kZoGRRjicvsFXw0aeLn0495+eVPjpkaUDvVQNEfgQ3uSgctfx0TPl D8364k+W38v403LkqfHJzbpKJHFHRtkk4JMoBJI0YcJJFrX68HXQqL7xURr3fLiOJNV9 6UKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XYc/WH2seI0xG53pu04DpOsVrDgCeSJvzPVy1Wb7xbc=; b=CpHVSMKxj9mPvrpLTChr6OWkXXf3V2KcRGKpkEXcw4QnceYxuf8lKePo0MXmeGKMvU W35szJ9rCAYmTJaGHIbXpJXHJ6Fo87aM3mb/KcJoHf2HaXmUU6zkzYy/V+WlpBT6dDwB 8NMiQJP+Br2zdVz1kBOwpzigWs/43cN9lVfYIm+LcQ4I3tQjKf/8X6XNKTCyRuOkNjeZ tPhElskD+G+xdeEhpiJqtQQE+/PkbAehg517Z2vVESfBFaEUBCaw7lfR8oNrwOnxzf7m sM4aPjLKzKC9MjFZEvjxuHNajHoKcliboYeSt9YmTGFfBkDWmHZ+nV2DHmlysCisnSdI cztw== X-Gm-Message-State: APjAAAUw65RqITint4WGJhU5C8xNsBNP+5QRlZgSz0WyDlHa3WvPVf0F dV1DqrmjzfZS6GgJq0Yn/TAsIQlndGrxqBHClV0Ibg== X-Google-Smtp-Source: APXvYqyCgK6btzLgwwnSgv74jEoWQoHI8ozi7jcw7cQUQdxzdOcrwHxKh0kRXd8ctiQN4glkzmopK4ioCeAsyCa3ItY= X-Received: by 2002:a1c:3cc3:: with SMTP id j186mr4129045wma.119.1567602141735; Wed, 04 Sep 2019 06:02:21 -0700 (PDT) MIME-Version: 1.0 References: <20190901203532.2615-1-hdegoede@redhat.com> In-Reply-To: <20190901203532.2615-1-hdegoede@redhat.com> From: Ard Biesheuvel Date: Wed, 4 Sep 2019 06:02:09 -0700 Message-ID: Subject: Re: [PATCH 0/9] crypto: sha256 - Merge crypto/sha256.h into crypto/sha.h To: Hans de Goede X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190904_060226_256938_DE081B3B X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-efi , Catalin Marinas , Heiko Carstens , "H . Peter Anvin" , Will Deacon , Atul Gupta , linux-s390 , Herbert Xu , the arch/x86 maintainers , Russell King , Eric Biggers , Christian Borntraeger , Ingo Molnar , Vasily Gorbik , Marc Zyngier , Gilad Ben-Yossef , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel , Linux Kernel Mailing List , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "David S . Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 1 Sep 2019 at 13:35, Hans de Goede wrote: > > Hi All, > > As promised here is a follow-up series to my earlier sha256 series. > > Note I have only compiled and tested this series on x86_64 !! > > All changes to architecture specific code on other archs have not even > been tested to compile! With that said most of these changes were done > using my editors search - replace function so things should be fine... > (and FWIW I did do a Kconfig hack to compile test the ccree change). > > The first patch in this series rename various file local functions / > arrays to avoid conflicts with the new include/crypto/sha256.h, followed > by a patch merging include/crypto/sha256.h into include/crypto/sha.h. > > The last patch makes use of this merging to remove a bit more code > duplication, making sha256_generic use sha256_init and sha224_init from > lib/crypto/sha256.c. An added advantage of this, is that this gives these > 2 functions coverage by the crypto selftests. > For the series, Acked-by: Ard Biesheuvel Thanks Hans. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel