From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ard Biesheuvel Subject: Re: [PATCH] crypto: arm/aes-cipher - move S-box to .rodata section Date: Tue, 13 Feb 2018 10:57:25 +0000 Message-ID: References: <20180212135237.GA3011@pjb1027-Latitude-E5410> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , linux-arm-kernel , Linux Kernel Mailing List , Herbert Xu , "David S. Miller" To: Jinbum Park Return-path: Received: from mail-it0-f67.google.com ([209.85.214.67]:33911 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934077AbeBMK50 (ORCPT ); Tue, 13 Feb 2018 05:57:26 -0500 Received: by mail-it0-f67.google.com with SMTP id j21so9223253ita.1 for ; Tue, 13 Feb 2018 02:57:26 -0800 (PST) In-Reply-To: <20180212135237.GA3011@pjb1027-Latitude-E5410> Sender: linux-crypto-owner@vger.kernel.org List-ID: On 12 February 2018 at 13:52, Jinbum Park wrote: > Move the AES inverse S-box to the .rodata section > where it is safe from abuse by speculation. > > Signed-off-by: Jinbum Park Acked-by: Ard Biesheuvel > --- > arch/arm/crypto/aes-cipher-core.S | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/arch/arm/crypto/aes-cipher-core.S b/arch/arm/crypto/aes-cipher-core.S > index 54b3840..184d6c2 100644 > --- a/arch/arm/crypto/aes-cipher-core.S > +++ b/arch/arm/crypto/aes-cipher-core.S > @@ -174,6 +174,16 @@ > .ltorg > .endm > > +ENTRY(__aes_arm_encrypt) > + do_crypt fround, crypto_ft_tab, crypto_ft_tab + 1, 2 > +ENDPROC(__aes_arm_encrypt) > + > + .align 5 > +ENTRY(__aes_arm_decrypt) > + do_crypt iround, crypto_it_tab, __aes_arm_inverse_sbox, 0 > +ENDPROC(__aes_arm_decrypt) > + > + .section ".rodata", "a" > .align L1_CACHE_SHIFT > .type __aes_arm_inverse_sbox, %object > __aes_arm_inverse_sbox: > @@ -210,12 +220,3 @@ __aes_arm_inverse_sbox: > .byte 0x17, 0x2b, 0x04, 0x7e, 0xba, 0x77, 0xd6, 0x26 > .byte 0xe1, 0x69, 0x14, 0x63, 0x55, 0x21, 0x0c, 0x7d > .size __aes_arm_inverse_sbox, . - __aes_arm_inverse_sbox > - > -ENTRY(__aes_arm_encrypt) > - do_crypt fround, crypto_ft_tab, crypto_ft_tab + 1, 2 > -ENDPROC(__aes_arm_encrypt) > - > - .align 5 > -ENTRY(__aes_arm_decrypt) > - do_crypt iround, crypto_it_tab, __aes_arm_inverse_sbox, 0 > -ENDPROC(__aes_arm_decrypt) > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: ard.biesheuvel@linaro.org (Ard Biesheuvel) Date: Tue, 13 Feb 2018 10:57:25 +0000 Subject: [PATCH] crypto: arm/aes-cipher - move S-box to .rodata section In-Reply-To: <20180212135237.GA3011@pjb1027-Latitude-E5410> References: <20180212135237.GA3011@pjb1027-Latitude-E5410> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12 February 2018 at 13:52, Jinbum Park wrote: > Move the AES inverse S-box to the .rodata section > where it is safe from abuse by speculation. > > Signed-off-by: Jinbum Park Acked-by: Ard Biesheuvel > --- > arch/arm/crypto/aes-cipher-core.S | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/arch/arm/crypto/aes-cipher-core.S b/arch/arm/crypto/aes-cipher-core.S > index 54b3840..184d6c2 100644 > --- a/arch/arm/crypto/aes-cipher-core.S > +++ b/arch/arm/crypto/aes-cipher-core.S > @@ -174,6 +174,16 @@ > .ltorg > .endm > > +ENTRY(__aes_arm_encrypt) > + do_crypt fround, crypto_ft_tab, crypto_ft_tab + 1, 2 > +ENDPROC(__aes_arm_encrypt) > + > + .align 5 > +ENTRY(__aes_arm_decrypt) > + do_crypt iround, crypto_it_tab, __aes_arm_inverse_sbox, 0 > +ENDPROC(__aes_arm_decrypt) > + > + .section ".rodata", "a" > .align L1_CACHE_SHIFT > .type __aes_arm_inverse_sbox, %object > __aes_arm_inverse_sbox: > @@ -210,12 +220,3 @@ __aes_arm_inverse_sbox: > .byte 0x17, 0x2b, 0x04, 0x7e, 0xba, 0x77, 0xd6, 0x26 > .byte 0xe1, 0x69, 0x14, 0x63, 0x55, 0x21, 0x0c, 0x7d > .size __aes_arm_inverse_sbox, . - __aes_arm_inverse_sbox > - > -ENTRY(__aes_arm_encrypt) > - do_crypt fround, crypto_ft_tab, crypto_ft_tab + 1, 2 > -ENDPROC(__aes_arm_encrypt) > - > - .align 5 > -ENTRY(__aes_arm_decrypt) > - do_crypt iround, crypto_it_tab, __aes_arm_inverse_sbox, 0 > -ENDPROC(__aes_arm_decrypt) > -- > 1.9.1 >