From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ard Biesheuvel Subject: Re: [PATCH v4 19/27] x86: assembly, make some functions local Date: Fri, 6 Oct 2017 15:01:03 +0100 Message-ID: References: <20171002091246.28432-1-jslaby@suse.cz> <20171002091246.28432-19-jslaby@suse.cz> <5a3785ea-d2d8-dd51-4b02-12f4ca5507d7@suse.cz> <9dfcee94-2058-8986-526c-f7ef9ebada66@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0TBh-0002LR-9f for xen-devel@lists.xenproject.org; Fri, 06 Oct 2017 14:01:13 +0000 Received: by mail-it0-f51.google.com with SMTP id 72so1271736itl.5 for ; Fri, 06 Oct 2017 07:01:05 -0700 (PDT) In-Reply-To: <9dfcee94-2058-8986-526c-f7ef9ebada66@suse.cz> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jiri Slaby Cc: Mark Rutland , "linux-efi@vger.kernel.org" , Matt Fleming , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "hpa@zytor.com" , xen-devel , "tglx@linutronix.de" List-Id: xen-devel@lists.xenproject.org T24gNiBPY3RvYmVyIDIwMTcgYXQgMTM6NTMsIEppcmkgU2xhYnkgPGpzbGFieUBzdXNlLmN6PiB3 cm90ZToKPiBIaSwKPgo+IE9uIDEwLzA0LzIwMTcsIDA5OjMzIEFNLCBBcmQgQmllc2hldXZlbCB3 cm90ZToKPj4gT24gNCBPY3RvYmVyIDIwMTcgYXQgMDg6MjIsIEppcmkgU2xhYnkgPGpzbGFieUBz dXNlLmN6PiB3cm90ZToKPj4+IE9uIDEwLzAyLzIwMTcsIDAyOjQ4IFBNLCBBcmQgQmllc2hldXZl bCB3cm90ZToKPj4+PiBPbiAyIE9jdG9iZXIgMjAxNyBhdCAxMDoxMiwgSmlyaSBTbGFieSA8anNs YWJ5QHN1c2UuY3o+IHdyb3RlOgo+Pj4+PiBUaGVyZSBpcyBhIGNvdXBsZSBvZiBhc3NlbWJseSBm dW5jdGlvbnMsIHdoaWNoIGFyZSBpbnZva2VkIG9ubHkgbG9jYWxseQo+Pj4+PiBpbiB0aGUgZmls ZSB0aGV5IGFyZSBkZWZpbmVkLiBJbiBDLCB3ZSBtYXJrIHRoZW0gInN0YXRpYyIuIEluIGFzc2Vt Ymx5LAo+Pj4+PiBhbm5vdGF0ZSB0aGVtIHVzaW5nIFNZTV97RlVOQyxDT0RFfV9TVEFSVF9MT0NB TCAoYW5kIHN3aXRjaCB0aGVpcgo+Pj4+PiBFTkRQUk9DIHRvIFNZTV97RlVOQyxDT0RFfV9FTkQg dG9vKS4gV2hldGhlciBGVU5DIG9yIENPREUgZGVwZW5kcyBvbgo+Pj4+PiBFTkRQUk9DL0VORCBm b3IgYSBwYXJ0aWN1bGFyIGZ1bmN0aW9uIChDIG9yIG5vbi1DKS4KPj4+Pj4KPj4+Pgo+Pj4+IEkg d2Fzbid0IGNjJ2VkIG9uIHRoZSBjb3ZlciBsZXR0ZXIsIHNvIEkgYW0gbWlzc2luZyB0aGUgcmF0 aW9uYWxlIG9mCj4+Pj4gcmVwbGFjaW5nIEVOVFJZL0VORFBST0Mgd2l0aCBvdGhlciBtYWNyb3Mu Cj4+Pgo+Pj4gVGhlcmUgd2FzIG5vIGNvdmVyIGxldHRlci4gSSBhbSBhdHRhY2hpbmcgd2hhdCBp cyBpbiBQQVRDSCAxLzI3IGluc3RlYWQ6Cj4+PiBJbnRyb2R1Y2UgbmV3IEMgbWFjcm9zIGZvciBh bm5vdGF0aW9ucyBvZiBmdW5jdGlvbnMgYW5kIGRhdGEgaW4KPj4+IGFzc2VtYmx5LiBUaGVyZSBp cyBhIGxvbmctc3RhbmRpbmcgbWVzcyBpbiBtYWNyb3MgbGlrZSBFTlRSWSwgRU5ELAo+Pj4gRU5E UFJPQyBhbmQgc2ltaWxhci4gVGhleSBhcmUgdXNlZCBpbiBkaWZmZXJlbnQgbWFubmVycyBhbmQg c29tZXRpbWVzCj4+PiBpbmNvcnJlY3RseS4KPj4+Cj4+Cj4+IEkgbXVzdCBzYXksIEkgZG9uJ3Qg c2hhcmUgdGhpcyBzZW50aW1lbnQuCj4+Cj4+IEluIGFybTY0LCB3ZSB1c2UgRU5UUlkvRU5EUFJP QyBmb3IgZnVuY3Rpb25zIHdpdGggZXh0ZXJuYWwgbGlua2FnZSwKPj4gYW5kIHRoZSBiYXJlIHN5 bWJvbCBuYW1lL0VORFBST0MgZm9yIGZ1bmN0aW9ucyB3aXRoIGxvY2FsIGxpbmthZ2UuIEkKPj4g Z3Vlc3Mgd2UgY291bGQgYWRkIEVORE9CSkVDVCBpZiB3ZSB3YW50ZWQgdG8sIGJ1dCB3ZSBuZXZl ciByZWFsbHkgZmVsdAo+PiB0aGUgbmVlZC4KPgo+IFllcyBhbmQgdGhpcyBpcyBleGFjdGx5IHRo ZSByZWFzb24gZm9yIHRoZSBuZXcgbWFjcm9zLiBOb3csIGl0J3MgYQo+IGNvbXBsZXRlIG1lc3Mu IE9uZSBhcmNoIGRvZXMgdGhpcywgYW5vdGhlciBkb2VzIHRoYXQuIEFuZCB3ZSBhcmUgaW4gYQo+ IHN0YXRlIHRvIGhhdmUgcmVsaWFibGUgc3RhY2t0cmFjZXMsIGxldCBvYmp0b29sIGNoZWNrIGZ1 bmN0aW9ucywgbGV0Cj4gb2JqdG9vbCBnZW5lcmF0ZSBhbm5vdGF0aW9ucyAoZS5nLiBmb3IgT1JD IHVud2luZGVyKSwgZXRjLgo+CgpZb3UgYXJlIGltcGx5aW5nIHRoYXQgRU5UUlkvRU5EUFJPQyBh bmQgJ2JhcmUgc3ltYm9sIG5hbWUnL0VORFBST0MKcHJldmVudCB5b3UgZnJvbSBkb2luZyBhbnkg b2YgdGhpcywgYnV0IHRoaXMgaXMgc2ltcGx5IG5vdCB0cnVlLgoKPiBXaXRob3V0IGtub3dpbmcg d2hhdCBpcyBzdGFydCwgd2hlcmUgaXMgaXRzIGVuZCwgd2hhdCBpcyBmdW5jdGlvbiwgd2hhdAo+ IGlzIG9iamVjdCAoZGF0YSkgZXRjLiwgaXQgY2FuIGJhcmVseSBjaGVjayBvciBldmVuIGdlbmVy YXRlIGFueXRoaW5nCj4gYXV0b21hdGljYWxseS4gTm90IHNwZWFraW5nIGFib3V0IGltcGFpcmVk IG1hY3JvcyBsaWtlIHlvdXIgbmFtZS9FTkRQUk9DCj4gYWJvdmUuCj4KCldoYXQgaXMgdGhlIHBy b2JsZW0gd2l0aCBpbXBhaXJlZCBtYWNyb3M/Cgo+IFRoZXJlIHdhcyBhIGNsZWFudXAgaW4geDg2 IGRvbmUgYnkgSm9zaCBhbmQgb3RoZXJzIHRoYXQgd2UgaGF2ZSBhdCBsZWFzdAo+IGNvcnJlY3Qg RU5UUlkrRU5EIGFuZCBFTlRSWStFTkRQUk9DIGFubm90YXRpb25zIGluIG1vc3QgY2FzZXMgbm93 LiBFdmVuCj4gdGhvdWdoIGl0IHdhcyBjb25jbHVkZWQgdGhlIG5hbWVzIGFyZSB3ZWlyZCAobGVm dG92ZXIgZnJvbSB0aGUgcGFzdCkuIFNvCj4geWVzLCB0aGVyZSB3YXMgYSBkaXNjdXNzaW9uIGFi b3V0IHRoZSBjbGVhbnVwLCBuYW1pbmcgYW5kIHN1Y2guIEFuZCBJCj4gY2FtZSB1cCB3aXRoIHRo ZSBuYW1lcyBpbiB0aGlzIGUtbWFpbC4KPgo+IGh0dHA6Ly9sa21sLmtlcm5lbC5vcmcvci8lM0My MDE3MDIxNzEwNDc1Ny4yODU4OC0xLWpzbGFieUBzdXNlLmN6JTNFCj4KCk9LLCBidXQgd3JhcHBp bmcgYXNtIGRpcmVjdGl2ZXMgaW4gbWFjcm9zIHdpbGwgbm90IHN1ZGRlbmx5IG1ha2UgdGhlCmFz c2VtYmxlciBjYXJlIGFib3V0IHdoZXRoZXIgeW91IHVzZSB0aGVtIG9yLCB3aGV0aGVyIHRoZXkg YXJlIHBhaXJlZCwKZXRjLgoKPj4+IFNvIGludHJvZHVjZSBtYWNyb3Mgd2l0aCBjbGVhciB1c2Ug dG8gYW5ub3RhdGUgYXNzZW1ibHkgYXMgZm9sbG93czoKPj4+Cj4+PiBhKSBTdXBwb3J0IG1hY3Jv cyBmb3IgdGhlIG9uZXMgYmVsb3cKPj4+ICAgIFNZTV9UX0ZVTkMgLS0gdHlwZSB1c2VkIGJ5IGFz c2VtYmxlciB0byBtYXJrIGZ1bmN0aW9ucwo+Pj4gICAgU1lNX1RfT0JKRUNUIC0tIHR5cGUgdXNl ZCBieSBhc3NlbWJsZXIgdG8gbWFyayBkYXRhCj4+PiAgICBTWU1fVF9OT05FIC0tIHR5cGUgdXNl ZCBieSBhc3NlbWJsZXIgdG8gbWFyayBlbnRyaWVzIG9mIHVua25vd24gdHlwZQo+Pj4KPj4KPj4g SXMgaXMgbmVjZXNzYXJ5IHRvIG1hcmsgYW4gZW50cnkgYXMgaGF2aW5nIG5vIHR5cGU/IFdoYXQg aXMgdGhlCj4+IGRlZmF1bHQgdHlwZSBmb3IgYW4gdW5tYXJrZWQgZW50cnk/Cj4KPiBUaGUgZGVm YXVsdCBpcyBpbmRlZWQgVF9OT05FLiBUaGUgdGhpbmcgaXMgdGhhdCBtb3N0IG1hY3JvcyB1c2UK PiBTWU1fU1RBUlQgYW5kIFNZTV9FTkQgd2hpY2ggcmVxdWlyZXMgdGhlIHR5cGUgYXMgYXJndW1l bnQuIFNvIGZvcgo+IGNvbnZlbmllbmNlLCB3ZSBkZWZpbmUgYWxzbyBTWU1fVF9OT05FIHVzZWQg ZS5nLiB0byBkZWZpbmUgU1lNX0NPREVfRU5EOgo+ICNkZWZpbmUgU1lNX0NPREVfRU5EKG5hbWUp ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAo+ICAgICAgICAgU1lNX0VORChDT0RFLCBu YW1lLCBTWU1fVF9OT05FKQo+Cj4gRGVzcGl0ZSBpdCBuZWVkcyBub3QgYmUgdGhlcmUuIEJ1dCB1 c2VycyBvZiB0aGUgbWFjcm9zIHNob3VsZCBub3QgY2FyZS4KPgo+Pj4gICAgVGhleSBhcmUgZGVm aW5lZCBhcyBTVFRfRlVOQywgU1RUX09CSkVDVCwgYW5kIFNUVF9OT1RZUEUKPj4+ICAgIHJlc3Bl Y3RpdmVseS4gQWNjb3JkaW5nIHRvIHRoZSBnYXMgbWFudWFsLCB0aGlzIGlzIHRoZSBtb3N0IHBv cnRhYmxlCj4+PiAgICB3YXkuIEkgYW0gbm90IHN1cmUgYWJvdXQgb3RoZXIgYXNzZW1ibGVycywg c28gd2UgY2FuIHN3aXRjaCB0aGlzIGJhY2sKPj4+ICAgIHRvICVmdW5jdGlvbiBhbmQgJW9iamVj dCBpZiB0aGlzIHR1cm5zIGludG8gYSBwcm9ibGVtLiBBcmNoaXRlY3R1cmVzCj4+PiAgICBjYW4g YWxzbyBvdmVycmlkZSB0aGVtIGJ5IHNvbWV0aGluZyBsaWtlICIsIEBmdW5jdGlvbiIgaWYgdGhl eSBuZWVkLgo+Pj4KPj4+ICAgIFNZTV9BX0FMSUdOLCBTWU1fQV9OT05FIC0tIGFsaWduIHRoZSBz eW1ib2w/Cj4+PiAgICBTWU1fVl9HTE9CQUwsIFNZTV9WX1dFQUssIFNZTV9WX0xPQ0FMIC0tIHZp c2liaWxpdHkgb2Ygc3ltYm9scwo+Pj4KPj4KPj4gTGlua2FnZSAhPSB2aXNpYmlsaXR5Cj4KPiBP SywgSSBjYW4gZml4IHRoaXMuCj4KPj4+IGQpIEZvciBkYXRhCj4+PiAgICBTWU1fREFUQV9TVEFS VCAtLSBnbG9iYWwgZGF0YSBzeW1ib2wKPj4+ICAgIFNZTV9EQVRBX0VORCAtLSB0aGUgZW5kIG9m IHRoZSBTWU1fREFUQV9TVEFSVCBzeW1ib2wKPj4+ICAgIFNZTV9EQVRBX0VORF9MQUJFTCAtLSB0 aGUgbGFiZWxlZCBlbmQgb2YgU1lNX0RBVEFfU1RBUlQgc3ltYm9sCj4+PiAgICBTWU1fREFUQV9T SU1QTEUgLS0gc3RhcnQrZW5kIHdyYXBwZXIgYXJvdW5kIHNpbXBsZSBnbG9iYWwgZGF0YQo+Pj4g ICAgU1lNX0RBVEFfU0lNUExFX0xPQ0FMIC0tIHN0YXJ0K2VuZCB3cmFwcGVyIGFyb3VuZCBzaW1w bGUgbG9jYWwgZGF0YQo+Pj4KPj4KPj4gSSBhbSBzb3JyeSBidXQgSSB0aGluayB0aGlzIGlzIHRl cnJpYmxlLiBEbyB3ZSByZWFsbHkgbmVlZCAyMCsgbmV3Cj4+IG1hY3JvcyB0byB3cmFwIGV2ZXJ5 IHNpbmdsZSBhc3NlbWJsZXIgZGlyZWN0aXZlIGludm9sdmVkIGluIGRlZmluaW5nCj4+IHN5bWJv bHMgYW5kIHNldHRpbmcgdGhlaXIgYXR0cmlidXRlcz8KPgo+IEJhc2ljYWxseSwgbW9zdCBjb2Rl IHVzZXMgU1lNX0ZVTkNfU1RBUlQvRU5EIGFuZCBTWU1fREFUQV9TVEFSVC9FTkQgKG9yCj4gU1lN X0RBVEFfU0lNUExFKS4gVGhlIHJlc3QgaXMgc3BlY2lhbCBjYXNlcyB0aGF0IF9oYXZlXyB0byBi ZSBhbm5vdGF0ZWQKPiBhcyBzdWNoIGFueXdheSAoYnkgZS5nLiBTWU1fQ09ERV9TVEFSVC9FTkQp LiBPYmp0b29sIGNhbm5vdCBjaGVjayB0aGUKPiBjb2RlIHdpdGhvdXQgdGhpcyByZWxpYWJseSBh bmQgaXQgaXMgZXhhY3RseSB0aGUgc2FtZSBhcyB1c2luZyBlaXRoZXIKPiBFTkQgb3IgRU5EUFJP QyBmb3IgYSBwYXJ0aWN1bGFyIGZ1bmN0aW9uIGV4Y2VwdCBwZW9wbGUgdXNlIHRoZXNlIGluIGEK PiB3cm9uZyB3YXkgYXMgdGhleSBhcmUgdW5kb2N1bWVudGVkLgo+CgpTbyB3aGF0IGlzIHByZXZl bnRpbmcgcGVvcGxlIGZyb20gdXNpbmcgdGhlc2UgbmV3IG1hY3JvcyBpbiB0aGUgd3Jvbmcgd2F5 PwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRl dmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhl bi5vcmcveGVuLWRldmVsCg==