All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Pavel Fedin <p.fedin@samsung.com>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	KVM devel mailing list <kvm@vger.kernel.org>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH] KVM: arm/arm64: Revert to old way of checking for device mapping in stage2_flush_ptes().
Date: Fri, 4 Dec 2015 09:37:12 +0100	[thread overview]
Message-ID: <CAKv+Gu9TemWhgySjkb3-PAQNz=VZBW0E4Sn34H_K53r3zjGNfw@mail.gmail.com> (raw)
In-Reply-To: <1449194337.30642.69.camel@decadent.org.uk>

On 4 December 2015 at 02:58, Ben Hutchings <ben@decadent.org.uk> wrote:
> On Wed, 2015-12-02 at 18:41 +0100, Ard Biesheuvel wrote:
>> Hi Pavel,
>>
>> Thanks for getting to the bottom of this.
>>
>> On 1 December 2015 at 14:03, Pavel Fedin <p.fedin@samsung.com> wrote:
>> > This function takes stage-II physical addresses (A.K.A. IPA), on input, not
>> > real physical addresses. This causes kvm_is_device_pfn() to return wrong
>> > values, depending on how much guest and host memory maps match. This
>> > results in completely broken KVM on some boards. The problem has been
>> > caught on Samsung proprietary hardware.
>> >
>> > Cc: stable@vger.kernel.org
>> > Fixes: e6fab5442345 ("ARM/arm64: KVM: test properly for a PTE's uncachedness")
>> >
>>
>> That commit is not in a release yet, so no need for cc stable
> [...]
>
> But it is cc'd to stable, so unless it is going to be nacked at review
> stage, any subsequent fixes should also be cc'd.
>

Ah yes, thanks for pointing that out.

But please, don't cc your proposed patches straight to
stable@vger.kernel.org. I usually leave it up to the maintainer that
merges the patch to add the Cc: line to the commit log.

  parent reply	other threads:[~2015-12-04  8:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 13:03 [PATCH] KVM: arm/arm64: Revert to old way of checking for device mapping in stage2_flush_ptes() Pavel Fedin
2015-12-01 13:03 ` Pavel Fedin
2015-12-02 17:41 ` Ard Biesheuvel
2015-12-03  7:14   ` Pavel Fedin
2015-12-03  8:09     ` Ard Biesheuvel
2015-12-03  8:14       ` Pavel Fedin
2015-12-04  1:58   ` Ben Hutchings
2015-12-04  6:39     ` Pavel Fedin
2015-12-04  8:37     ` Ard Biesheuvel [this message]
2015-12-02 18:50 ` Christoffer Dall
2015-12-02 19:04   ` Ard Biesheuvel
2015-12-02 19:23     ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9TemWhgySjkb3-PAQNz=VZBW0E4Sn34H_K53r3zjGNfw@mail.gmail.com' \
    --to=ard.biesheuvel@linaro.org \
    --cc=ben@decadent.org.uk \
    --cc=christoffer.dall@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=marc.zyngier@arm.com \
    --cc=p.fedin@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.