From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756417AbdKCUKx (ORCPT ); Fri, 3 Nov 2017 16:10:53 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:43447 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751907AbdKCUKv (ORCPT ); Fri, 3 Nov 2017 16:10:51 -0400 X-Google-Smtp-Source: ABhQp+RJemyc3aiBV+kPPP3jG7iPCjlYrt4zu7QClGDTqy0RMriWrj0xRhqkbxHtSnVCyTTJDB9T0VW+5vH+FHAwlZM= MIME-Version: 1.0 In-Reply-To: <20171103171203.107569-19-samitolvanen@google.com> References: <20171103171203.107569-1-samitolvanen@google.com> <20171103171203.107569-19-samitolvanen@google.com> From: Ard Biesheuvel Date: Fri, 3 Nov 2017 20:10:50 +0000 Message-ID: Subject: Re: [PATCH 14/15] arm64: crypto: disable LTO for aes-ce-cipher.c To: Sami Tolvanen Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Matthias Kaehlcke , Nick Desaulniers , Kees Cook , Greg Hackmann Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3 November 2017 at 17:12, Sami Tolvanen wrote: > CONFIG_CLANG_LTO requires the use of clang's integrated assembler, which > doesn't understand the inline assembly in aes-ce-cipher.c. Disable LTO for > the file to work around the issue. > > Signed-off-by: Sami Tolvanen Acked-by: Ard Biesheuvel > --- > arch/arm64/crypto/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/crypto/Makefile b/arch/arm64/crypto/Makefile > index b5edc5918c28..0edaef43a1d4 100644 > --- a/arch/arm64/crypto/Makefile > +++ b/arch/arm64/crypto/Makefile > @@ -24,7 +24,7 @@ obj-$(CONFIG_CRYPTO_CRC32_ARM64_CE) += crc32-ce.o > crc32-ce-y:= crc32-ce-core.o crc32-ce-glue.o > > obj-$(CONFIG_CRYPTO_AES_ARM64_CE) += aes-ce-cipher.o > -CFLAGS_aes-ce-cipher.o += -march=armv8-a+crypto > +CFLAGS_aes-ce-cipher.o += -march=armv8-a+crypto $(DISABLE_LTO) > > obj-$(CONFIG_CRYPTO_AES_ARM64_CE_CCM) += aes-ce-ccm.o > aes-ce-ccm-y := aes-ce-ccm-glue.o aes-ce-ccm-core.o > -- > 2.15.0.403.gc27cc4dac6-goog > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: ard.biesheuvel@linaro.org (Ard Biesheuvel) Date: Fri, 3 Nov 2017 20:10:50 +0000 Subject: [PATCH 14/15] arm64: crypto: disable LTO for aes-ce-cipher.c In-Reply-To: <20171103171203.107569-19-samitolvanen@google.com> References: <20171103171203.107569-1-samitolvanen@google.com> <20171103171203.107569-19-samitolvanen@google.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 3 November 2017 at 17:12, Sami Tolvanen wrote: > CONFIG_CLANG_LTO requires the use of clang's integrated assembler, which > doesn't understand the inline assembly in aes-ce-cipher.c. Disable LTO for > the file to work around the issue. > > Signed-off-by: Sami Tolvanen Acked-by: Ard Biesheuvel > --- > arch/arm64/crypto/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/crypto/Makefile b/arch/arm64/crypto/Makefile > index b5edc5918c28..0edaef43a1d4 100644 > --- a/arch/arm64/crypto/Makefile > +++ b/arch/arm64/crypto/Makefile > @@ -24,7 +24,7 @@ obj-$(CONFIG_CRYPTO_CRC32_ARM64_CE) += crc32-ce.o > crc32-ce-y:= crc32-ce-core.o crc32-ce-glue.o > > obj-$(CONFIG_CRYPTO_AES_ARM64_CE) += aes-ce-cipher.o > -CFLAGS_aes-ce-cipher.o += -march=armv8-a+crypto > +CFLAGS_aes-ce-cipher.o += -march=armv8-a+crypto $(DISABLE_LTO) > > obj-$(CONFIG_CRYPTO_AES_ARM64_CE_CCM) += aes-ce-ccm.o > aes-ce-ccm-y := aes-ce-ccm-glue.o aes-ce-ccm-core.o > -- > 2.15.0.403.gc27cc4dac6-goog > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel