All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Christopher Li <sparse@chrisli.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>,
	Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v3] sparse: treat function pointers as pointers to const data
Date: Tue, 14 Oct 2014 14:55:35 +0200	[thread overview]
Message-ID: <CAKv+Gu_7tgBVJ9uLRDazhMoj88xu5JS89VkW2UumFxKq65ze7g@mail.gmail.com> (raw)
In-Reply-To: <CAKv+Gu92fB1oHxn4jDCvNYZ4jhWpbtS-ANhX7LUx73w-+je-0Q@mail.gmail.com>

On 8 October 2014 20:06, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> On 8 October 2014 20:00, Christopher Li <sparse@chrisli.org> wrote:
>> On Mon, Oct 6, 2014 at 10:44 PM, Ard Biesheuvel
>> <ard.biesheuvel@linaro.org> wrote:
>>>> we only address the case where the function pointer is the target of
>>>> an assignment.
>>
>> I apply the patch in my private branch but haven't push out yet.
>>
>> I just want to confirm, you didn't find this kind of assignment in the
>> kernel, right?
>>
>
> I noticed this patch
>
> https://git.kernel.org/cgit/linux/kernel/git/kvmarm/kvmarm.git/commit/?h=queue&id=de56fb1923ca11f428bf557870e0faa99f38762e
>
> and saw that it was bogus: changing the return type of the pointed-to
> function to 'const int' makes no sense at all, and yet it shuts up
> sparse.
>
> With my sparse patch, that patch could have been dropped (although I
> think it was merged after all)
>

Ping?

  reply	other threads:[~2014-10-14 12:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08  6:30 [PATCH v3] sparse: treat function pointers as pointers to const data Ard Biesheuvel
2014-10-06 14:44 ` Ard Biesheuvel
2014-10-08 18:00   ` Christopher Li
2014-10-08 18:06     ` Ard Biesheuvel
2014-10-14 12:55       ` Ard Biesheuvel [this message]
2014-10-15  1:34         ` Christopher Li
2014-10-15  5:16           ` Ard Biesheuvel
2014-10-15  7:06             ` Christopher Li
2014-10-15  7:10               ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu_7tgBVJ9uLRDazhMoj88xu5JS89VkW2UumFxKq65ze7g@mail.gmail.com \
    --to=ard.biesheuvel@linaro.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=sparse@chrisli.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.