From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbdKQJyz (ORCPT ); Fri, 17 Nov 2017 04:54:55 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:37008 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbdKQJyu (ORCPT ); Fri, 17 Nov 2017 04:54:50 -0500 X-Google-Smtp-Source: AGs4zMbuGrpCBe/6QV3Mkd93fWPBrN5jdL5NUXmLOUi3y7gbOWtRPxjXoXDftqfxJP/U2tfBuNvkU1pH3++yICAitdI= MIME-Version: 1.0 In-Reply-To: <20171116235019.GA55530@samitolvanen.mtv.corp.google.com> References: <20171115213428.22559-1-samitolvanen@google.com> <20171115213428.22559-9-samitolvanen@google.com> <20171116114406.GB9361@arm.com> <20171116163132.GC94341@samitolvanen.mtv.corp.google.com> <20171116213702.GA10616@samitolvanen.mtv.corp.google.com> <20171116230939.GA38360@samitolvanen.mtv.corp.google.com> <20171116235019.GA55530@samitolvanen.mtv.corp.google.com> From: Ard Biesheuvel Date: Fri, 17 Nov 2017 09:54:48 +0000 Message-ID: Subject: Re: [PATCH v2 08/18] arm64: don't disable ADR_PREL_PG_HI21* with ARM64_ERRATUM_843419 To: Sami Tolvanen Cc: Will Deacon , Mark Rutland , Andi Kleen , Kees Cook , linux-kbuild@vger.kernel.org, Nick Desaulniers , "linux-kernel@vger.kernel.org" , Greg Hackmann , Masahiro Yamada , Michal Marek , Yury Norov , Alex Matveev , Matthias Kaehlcke , "linux-arm-kernel@lists.infradead.org" , Maxim Kuvyrkov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16 November 2017 at 23:50, Sami Tolvanen wrote: > On Thu, Nov 16, 2017 at 11:20:40PM +0000, Ard Biesheuvel wrote: >> So at which point is the IR in a partially linked object file >> converted into executable code? > > At the final module link step (cmd_ld_ko_o) in scripts/Makefile.modpost, > added in patch 12. > OK, so all IR objects are converted into a single .o file encapsulating the module image. Does this give the same benefits as LTO linking IR objects to a fully linked executable? Even if it does, partial linking is not something the toolchain people are usually crazy about, so it would be nice to have some confirmation that this is a usage model that is fully supported. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f66.google.com ([209.85.214.66]:36713 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751523AbdKQJyu (ORCPT ); Fri, 17 Nov 2017 04:54:50 -0500 Received: by mail-it0-f66.google.com with SMTP id 187so1249823iti.1 for ; Fri, 17 Nov 2017 01:54:49 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20171116235019.GA55530@samitolvanen.mtv.corp.google.com> References: <20171115213428.22559-1-samitolvanen@google.com> <20171115213428.22559-9-samitolvanen@google.com> <20171116114406.GB9361@arm.com> <20171116163132.GC94341@samitolvanen.mtv.corp.google.com> <20171116213702.GA10616@samitolvanen.mtv.corp.google.com> <20171116230939.GA38360@samitolvanen.mtv.corp.google.com> <20171116235019.GA55530@samitolvanen.mtv.corp.google.com> From: Ard Biesheuvel Date: Fri, 17 Nov 2017 09:54:48 +0000 Message-ID: Subject: Re: [PATCH v2 08/18] arm64: don't disable ADR_PREL_PG_HI21* with ARM64_ERRATUM_843419 Content-Type: text/plain; charset="UTF-8" Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Sami Tolvanen Cc: Will Deacon , Mark Rutland , Andi Kleen , Kees Cook , linux-kbuild@vger.kernel.org, Nick Desaulniers , "linux-kernel@vger.kernel.org" , Greg Hackmann , Masahiro Yamada , Michal Marek , Yury Norov , Alex Matveev , Matthias Kaehlcke , "linux-arm-kernel@lists.infradead.org" , Maxim Kuvyrkov On 16 November 2017 at 23:50, Sami Tolvanen wrote: > On Thu, Nov 16, 2017 at 11:20:40PM +0000, Ard Biesheuvel wrote: >> So at which point is the IR in a partially linked object file >> converted into executable code? > > At the final module link step (cmd_ld_ko_o) in scripts/Makefile.modpost, > added in patch 12. > OK, so all IR objects are converted into a single .o file encapsulating the module image. Does this give the same benefits as LTO linking IR objects to a fully linked executable? Even if it does, partial linking is not something the toolchain people are usually crazy about, so it would be nice to have some confirmation that this is a usage model that is fully supported. From mboxrd@z Thu Jan 1 00:00:00 1970 From: ard.biesheuvel@linaro.org (Ard Biesheuvel) Date: Fri, 17 Nov 2017 09:54:48 +0000 Subject: [PATCH v2 08/18] arm64: don't disable ADR_PREL_PG_HI21* with ARM64_ERRATUM_843419 In-Reply-To: <20171116235019.GA55530@samitolvanen.mtv.corp.google.com> References: <20171115213428.22559-1-samitolvanen@google.com> <20171115213428.22559-9-samitolvanen@google.com> <20171116114406.GB9361@arm.com> <20171116163132.GC94341@samitolvanen.mtv.corp.google.com> <20171116213702.GA10616@samitolvanen.mtv.corp.google.com> <20171116230939.GA38360@samitolvanen.mtv.corp.google.com> <20171116235019.GA55530@samitolvanen.mtv.corp.google.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16 November 2017 at 23:50, Sami Tolvanen wrote: > On Thu, Nov 16, 2017 at 11:20:40PM +0000, Ard Biesheuvel wrote: >> So at which point is the IR in a partially linked object file >> converted into executable code? > > At the final module link step (cmd_ld_ko_o) in scripts/Makefile.modpost, > added in patch 12. > OK, so all IR objects are converted into a single .o file encapsulating the module image. Does this give the same benefits as LTO linking IR objects to a fully linked executable? Even if it does, partial linking is not something the toolchain people are usually crazy about, so it would be nice to have some confirmation that this is a usage model that is fully supported.