From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ard Biesheuvel Subject: Re: [PATCH] sdhci-fujitsu: add support for setting the CMD_DAT_DELAY attribute Date: Mon, 6 Nov 2017 10:46:30 +0000 Message-ID: References: <20171101002132.13500-1-ard.biesheuvel@linaro.org> <20171102000814.ih2ggtfpmfsx3xap@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org To: Ulf Hansson Cc: Vincent Yang , Rob Herring , Mark Rutland , Adrian Hunter , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , Vincent Yang , Vincent Yang , Vincent Yang List-Id: devicetree@vger.kernel.org On 6 November 2017 at 07:17, Ulf Hansson wrote: > [...] > >>>>> >>>>> Do you mean set it unconditionally? That works for me, but I have no >>>> >>>> Yes. >>>> >>>>> way of testing whether it still works on other SoCs that use this IP. >>>> >>>> Me neither! >>> >>> Hi all, I can not yet get contact with IP owner because it is a >>> holiday in Japan. >>> Around two years ago, F_SDH30_CMD_DAT_DELAY was a new feature of this IP. >>> I will update the latest information as soon as I get it. >>> >> I got a response from IP owner. >> He explains F_SDH30_CMD_DAT_DELAY is intended to adjust signal timing of >> CMD/DAT lines, and it is necessary to change its value according to >> SoC/board design. >> So he advises us to make F_SDH30_CMD_DAT_DELAY adjustable by a DT binding. >> >> Kind regards >> Vincent >> >>>> >>>> Apparently there are no DTS in the kernel git that uses the >>>> "fujitsu,mb86s70-sdhci-3.0". >>> >>> Around two years ago, sdhci_f_sdh30_driver was a portion for mb86s70 SoC >>> patch series, but finally the patch series did not fully go upstream. >>> > > Vincent, thanks for all the help in this! > > Ard, one thing, could you please split the DT doc change into a > separate patch, preceding the change that actually do the parsing of > the new binding. > Will do. Thanks.