All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Breck <liam@networkimprov.net>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Sebastian Reichel <sre@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v1 7/7] power: bq24190_charger: Set bq24190-battery device .type=unknown
Date: Wed, 22 Mar 2017 11:33:11 -0700	[thread overview]
Message-ID: <CAKvHMgQ2JFDYWuhoL=WFh-RGQEcSKCM8xWBKNo5JJLoHEkYCqg@mail.gmail.com> (raw)
In-Reply-To: <41f97886-306e-725f-4b05-dc98a3b57fa1@redhat.com>

On Wed, Mar 22, 2017 at 7:41 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 22-03-17 14:37, Liam Breck wrote:
>>
>> On Wed, Mar 22, 2017 at 6:15 AM, Hans de Goede <hdegoede@redhat.com>
>> wrote:
>>>
>>> Hi,
>>>
>>> On 22-03-17 13:25, Hans de Goede wrote:
>>>>
>>>>
>>>> Hi,
>>>>
>>>> On 21-03-17 23:09, Liam Breck wrote:
>>>>>
>>>>>
>>>>> From: Liam Breck <kernel@networkimprov.net>
>>>>>
>>>>> Not for upstream. Temporary workaround to prevent bq24190-battery
>>>>> device
>>>>> from interfering with a fuel gauge that has
>>>>> .type=power_supply_type_battery
>>>>>
>>>>> I'll move properties from -battery device to -charger in a subsequent
>>>>> version.
>>>>>
>>>>> Cc: Hans de Goede <hdegoede@redhat.com>
>>>>
>>>>
>>>>
>>>> Hmm, I don't like this. I was about to post v2 of my patches (which I
>>>> will
>>>> rebase on top of this series)
>>>
>>>
>>>
>>> It seems this series does not apply to:
>>>
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next
>>>
>>> It looks like there is another series which sits in between ?
>>
>>
>> Yes, see two patches linked in Depends-on lines. Could you add those and
>> rebase?
>
>
> I can confirm that with those 2 patches thrown in things apply
> cleanly on linux-power-supply/for-next.
>
> I see that these 2 patches add a new devicetree binding for describing
> a battery. That is really cool stuff and long overdue IMHO I'm glad
> to see someone doing this.
>
> But (sorry) in my experience getting new devicetree bindings upstream
> often takes a while, while people are discussing the best way to
> solve things. So I'm not quite sure this will go upstream real soon
> now and I would like to get my patches into -next in time for 4.12
> if possible.

Sebastian asked us to write those two patches, and has acked one, I
expect ack on the docs for this version (the DT api is settled). The
only thing holding up that patchset is a test pass by the TI
maintainer of bq27xxx_battery. But we can separate the
power_supply_core changes from that if nec.

I would like to run your patches in my environment for some time
before acking. For that, I need the -battery back! And also this
patchset.

How's progress on the pmic-gauge battery driver? I'd be curious to see
it since I've been adding features to the bq27xxx driver lately.

> So for now I'm going to hold of on rebasing and just send v2 as is
> (based on linux-power-supply/for-next). If Sebastian thinks your
> patches should go first I will happily do a rebased v3.
>
> Regards,
>
> Hans

  reply	other threads:[~2017-03-22 18:40 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 22:09 [PATCH v1 0/7] BQ24190 support for power_supply_battery_info and DT binding Liam Breck
2017-03-21 22:09 ` [PATCH v1 1/7] devicetree: power: battery: Add properties for pre-charge and end-charge current Liam Breck
2017-03-24  9:01   ` Sebastian Reichel
2017-03-25  0:34     ` Liam Breck
2017-03-29  0:43       ` Rob Herring
     [not found]   ` <20170321220921.5834-2-liam-RYWXG+zxWwBdeoIcmNTgJF6hYfS7NtTn@public.gmane.org>
2017-03-22 12:04     ` Hans de Goede
2017-03-29  0:39     ` Rob Herring
2017-03-29  1:42       ` Liam Breck
2017-03-21 22:09 ` [PATCH v1 2/7] devicetree: power: Add docs for TI BQ24190 battery charger Liam Breck
2017-03-24  9:00   ` Sebastian Reichel
     [not found]   ` <20170321220921.5834-3-liam-RYWXG+zxWwBdeoIcmNTgJF6hYfS7NtTn@public.gmane.org>
2017-03-22 12:04     ` Hans de Goede
2017-03-29  0:47     ` Rob Herring
2017-03-29  1:48       ` Liam Breck
2017-03-21 22:09 ` [PATCH v1 3/7] power: power_supply_core: Add *_battery_info fields for pre- and end-charge current Liam Breck
2017-03-22 12:12   ` Hans de Goede
2017-03-24  9:07   ` Sebastian Reichel
2017-03-21 22:09 ` [PATCH v1 4/7] power: bq24190_charger: Uniform pm_runtime_get() failure handling Liam Breck
2017-03-22 12:14   ` Hans de Goede
2017-03-22 15:35   ` Tony Lindgren
2017-03-24  9:13   ` Sebastian Reichel
2017-03-21 22:09 ` [PATCH v1 5/7] power: bq24190_charger: Reorder init sequence in probe() Liam Breck
2017-03-22 12:14   ` Hans de Goede
2017-03-22 15:36     ` Tony Lindgren
2017-03-21 22:09 ` [PATCH v1 6/7] power: bq24190_charger: Add power_supply_battery_info and devicetree support Liam Breck
2017-03-22 12:15   ` Hans de Goede
2017-03-24  9:20   ` Sebastian Reichel
2017-03-21 22:09 ` [PATCH v1 7/7] power: bq24190_charger: Set bq24190-battery device .type=unknown Liam Breck
2017-03-22 12:25   ` Hans de Goede
2017-03-22 13:15     ` Hans de Goede
2017-03-22 13:37       ` Liam Breck
2017-03-22 14:41         ` Hans de Goede
2017-03-22 18:33           ` Liam Breck [this message]
2017-03-23  8:18             ` Hans de Goede
2017-03-23  8:55               ` Liam Breck
2017-03-22 13:22     ` Liam Breck
2017-03-23 10:52   ` Sebastian Reichel
2017-03-23 11:31     ` Liam Breck
2017-03-23 13:37       ` Sebastian Reichel
2017-03-23 19:05         ` Liam Breck
2017-03-23 20:47     ` Liam Breck
2017-03-24  9:39       ` Sebastian Reichel
2017-03-24 10:44         ` Liam Breck
2017-03-24 11:22           ` Sebastian Reichel
2017-03-24 11:56             ` Liam Breck
2017-03-29 14:12               ` Sebastian Reichel
2017-04-14 22:43     ` Liam Breck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKvHMgQ2JFDYWuhoL=WFh-RGQEcSKCM8xWBKNo5JJLoHEkYCqg@mail.gmail.com' \
    --to=liam@networkimprov.net \
    --cc=hdegoede@redhat.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.