Re: [PATCH v2 4/6] power: bq24190_charger: Call power_supply_changed() for relevant component

[Liam Breck <liam@networkimprov.net>]

On Mon, Jan 16, 2017 at 10:31 AM, Mark Greer <mgreer@animalcreek.com> wrote:
> On Sun, Jan 15, 2017 at 10:08:04PM -0800, Liam Breck wrote:
>>
>
>> We wrongly get uevents for bq24190-charger and bq24190-battery on every
>> register change.
>>
>> Fix by checking the association with charger and battery before
>> emitting uevent(s).
>>
>> Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger")
>> Cc: Mark A. Greer <mgreer@animalcreek.com>
>> Cc: Matt Ranostay <matt@ranostay.consulting>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Signed-off-by: Liam Breck <kernel@networkimprov.net>
>> ---
>>  drivers/power/supply/bq24190_charger.c | 50 +++++++++++++++++++---------------
>>  1 file changed, 27 insertions(+), 23 deletions(-)
>>
>> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
>> index 62194d8..ba5a5b2 100644
>> --- a/drivers/power/supply/bq24190_charger.c
>> +++ b/drivers/power/supply/bq24190_charger.c
>
>> @@ -1225,8 +1227,12 @@ static irqreturn_t bq24190_irq_handler_thread(int irq, void *data)
>>                                       ret);
>>               }
>>
>> +             if ((bdi->ss_reg & battery_mask_ss) != (ss_reg & battery_mask_ss))
>> +                     alert_battery = true;
>> +             if ((bdi->ss_reg & ~battery_mask_ss) != (ss_reg & ~battery_mask_ss))
>
> Lines are > 80 characters. Please break up.

I did this deliberately, because the same logic appears for f_reg in
that function, and this way you can see that at a glance.

My research on 80-char limit found that it's not a hard rule.