From: Liam Breck <liam@networkimprov.net>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Liam Breck <kernel@networkimprov.net>,
Tony Lindgren <tony@atomide.com>,
linux-pm@vger.kernel.org
Subject: Re: Moving forward with the patches for using the bq24190 on x86 systems
Date: Mon, 3 Apr 2017 14:56:45 -0700 [thread overview]
Message-ID: <CAKvHMgR+mvxSRYH69oAyGGL2ppZxO=s1CtUw_N2Cy-tZe-nAUg@mail.gmail.com> (raw)
In-Reply-To: <527947b5-948b-1aab-233f-c421bdf317e2@redhat.com>
On Mon, Apr 3, 2017 at 12:27 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi Sebastian, Liam,
>
> I still have 2 patches pending for using the bq24190 on x86 systems,
> which I would like to see merged in some form (and if possible in
> time for 4.12):
Is there a specific reason for urgency?
Can I ask how you got involved in porting Linux to this Atom box?
> 1) The "power: supply: bq24190_charger: Never reset the charger chip" patch.
>
> Sebastian you said you would merge this after letting it sit a bit longer
> on the list, unless any problems with it were noticed. I believe Liam
> would prefer for this to not get merged as-is. So I see 3 options:
>
> a) Merge as-is (AFAIK no problems with it have been noticed)
> b) Add a "no-reset-on-probe" boolean device property which will
> make the driver not do a reset on probe (nor on resume)
> c) Add a "reset-on-probe" boolean device property and make the
> driver only do a reset on probe (and on resume) if this is set
>
> Sebastian, can you please pick one of these 3 options ? Then I
> will adjust my patch as necessary and post a new version.
I've solicited Tony's input on this. He's studied the charger/driver a
lot, and is a guru-level kernel contributor.
> 2) The "power: supply: bq24190_charger: Remove battery power_supply device"
> patch
>
> The problem with this one is that it removes userspace ABI on which
> Liam is relying, so this cannot go upstream as is. I think that
> for now it is best to add a "disable-battery-power-supply-iface"
> boolean device-property (for kernel internal use only, not part
> of the DT bindings) and guard the power_supply_register call
> for the battery interface with a check for this.
That would be a reasonable near-term workaround, until I merge the
-battery properties into -charger.
next prev parent reply other threads:[~2017-04-03 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 7:27 Moving forward with the patches for using the bq24190 on x86 systems Hans de Goede
2017-04-03 21:56 ` Liam Breck [this message]
2017-04-04 0:56 ` Tony Lindgren
2017-04-04 9:04 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKvHMgR+mvxSRYH69oAyGGL2ppZxO=s1CtUw_N2Cy-tZe-nAUg@mail.gmail.com' \
--to=liam@networkimprov.net \
--cc=hdegoede@redhat.com \
--cc=kernel@networkimprov.net \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.