From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Breck Subject: Re: [PATCH v3 0/5] bq27xxx_battery data memory update Date: Wed, 27 Sep 2017 05:02:44 -0700 Message-ID: References: <20170824033617.20840-1-liam@networkimprov.net> <20170830002939.ns43wldvffmwqhuv@earth> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-io0-f193.google.com ([209.85.223.193]:38618 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbdI0MCq (ORCPT ); Wed, 27 Sep 2017 08:02:46 -0400 Received: by mail-io0-f193.google.com with SMTP id e9so6048320iod.5 for ; Wed, 27 Sep 2017 05:02:45 -0700 (PDT) In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Julia Lawall Cc: Sebastian Reichel , Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, "Andrew F. Davis" , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Linux PM mailing list Hi Julia, thanks so much for your help! On Wed, Sep 27, 2017 at 3:02 AM, Julia Lawall wrote: > The github version of Coccinelle finally supports the semantic patch for > your code. I have attached the semantic patch. I wonder what should be > done with this? Do you want to use it locally with make coccicheck? Do > you want it to be integrated into the kernel? Everything in the semantic Yes, our intent is to push it upstream. Can you submit a patch? Did you test with 4.13? That should show a handful of dupes... > patch depends on the occurrence of BQ27XXX_DATA, so if make coccicheck is > used on files that don't contain this word, they should be ignored very > efficiently. So perhaps it is ok for scripts/coccinelle even if it is > relevant to only one file. > > julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: liam@networkimprov.net (Liam Breck) Date: Wed, 27 Sep 2017 05:02:44 -0700 Subject: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update In-Reply-To: References: <20170824033617.20840-1-liam@networkimprov.net> <20170830002939.ns43wldvffmwqhuv@earth> Message-ID: To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr Hi Julia, thanks so much for your help! On Wed, Sep 27, 2017 at 3:02 AM, Julia Lawall wrote: > The github version of Coccinelle finally supports the semantic patch for > your code. I have attached the semantic patch. I wonder what should be > done with this? Do you want to use it locally with make coccicheck? Do > you want it to be integrated into the kernel? Everything in the semantic Yes, our intent is to push it upstream. Can you submit a patch? Did you test with 4.13? That should show a handful of dupes... > patch depends on the occurrence of BQ27XXX_DATA, so if make coccicheck is > used on files that don't contain this word, they should be ignored very > efficiently. So perhaps it is ok for scripts/coccinelle even if it is > relevant to only one file. > > julia