From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Breck Subject: Re: [PATCH v3 0/5] bq27xxx_battery data memory update Date: Wed, 27 Sep 2017 05:46:50 -0700 Message-ID: References: <20170824033617.20840-1-liam@networkimprov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-it0-f68.google.com ([209.85.214.68]:49269 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbdI0Mqw (ORCPT ); Wed, 27 Sep 2017 08:46:52 -0400 Received: by mail-it0-f68.google.com with SMTP id c195so6882980itb.4 for ; Wed, 27 Sep 2017 05:46:51 -0700 (PDT) In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Julia Lawall Cc: Sebastian Reichel , Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, "Andrew F. Davis" , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Linux PM mailing list On Wed, Sep 27, 2017 at 5:16 AM, Julia Lawall wrote: > > > On Wed, 27 Sep 2017, Liam Breck wrote: > >> Hi Julia, thanks so much for your help! >> >> On Wed, Sep 27, 2017 at 3:02 AM, Julia Lawall wrote: >> > The github version of Coccinelle finally supports the semantic patch for >> > your code. I have attached the semantic patch. I wonder what should be >> > done with this? Do you want to use it locally with make coccicheck? Do >> > you want it to be integrated into the kernel? Everything in the semantic >> >> Yes, our intent is to push it upstream. Can you submit a patch? >> >> Did you test with 4.13? That should show a handful of dupes... > > Are you sure? I did a git checkout v4.13 and there aren't any occurrences > of BQ27XXX_DATA. Sorry, that macro landed in 4.14. If you revert this commit, you should see dupes: power: supply: bq27xxx: Remove duplicate chip data arrays From mboxrd@z Thu Jan 1 00:00:00 1970 From: liam@networkimprov.net (Liam Breck) Date: Wed, 27 Sep 2017 05:46:50 -0700 Subject: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update In-Reply-To: References: <20170824033617.20840-1-liam@networkimprov.net> Message-ID: To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On Wed, Sep 27, 2017 at 5:16 AM, Julia Lawall wrote: > > > On Wed, 27 Sep 2017, Liam Breck wrote: > >> Hi Julia, thanks so much for your help! >> >> On Wed, Sep 27, 2017 at 3:02 AM, Julia Lawall wrote: >> > The github version of Coccinelle finally supports the semantic patch for >> > your code. I have attached the semantic patch. I wonder what should be >> > done with this? Do you want to use it locally with make coccicheck? Do >> > you want it to be integrated into the kernel? Everything in the semantic >> >> Yes, our intent is to push it upstream. Can you submit a patch? >> >> Did you test with 4.13? That should show a handful of dupes... > > Are you sure? I did a git checkout v4.13 and there aren't any occurrences > of BQ27XXX_DATA. Sorry, that macro landed in 4.14. If you revert this commit, you should see dupes: power: supply: bq27xxx: Remove duplicate chip data arrays