* [PATCH 1/2] Makefile: clang-tools: Print information when clang-tidy tool is missing
@ 2021-05-20 23:18 Maciej Falkowski
2021-05-20 23:18 ` [PATCH 2/2] Makefile: clang-tools: Omit printing stack trace when KeyboardInterrupt is raised Maciej Falkowski
2021-05-20 23:56 ` [PATCH 1/2] Makefile: clang-tools: Print information when clang-tidy tool is missing Nick Desaulniers
0 siblings, 2 replies; 6+ messages in thread
From: Maciej Falkowski @ 2021-05-20 23:18 UTC (permalink / raw)
To: natechancellor, ndesaulniers
Cc: clang-built-linux, linux-kernel, maciej.falkowski9
When `clang-tidy` tool is missing in the system, the FileNotFoundError
exception is raised in the program reporting a stack trace to the user:
$ ./scripts/clang-tools/run-clang-tools.py clang-tidy ./compile_commands.json
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
File "/usr/lib64/python3.8/multiprocessing/pool.py", line 125, in worker
result = (True, func(*args, **kwds))
File "/usr/lib64/python3.8/multiprocessing/pool.py", line 48, in mapstar
return list(map(*args))
File "./scripts/clang-tools/run-clang-tools.py", line 54, in run_analysis
p = subprocess.run(["clang-tidy", "-p", args.path, checks, entry["file"]],
File "/usr/lib64/python3.8/subprocess.py", line 489, in run
with Popen(*popenargs, **kwargs) as process:
File "/usr/lib64/python3.8/subprocess.py", line 854, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/usr/lib64/python3.8/subprocess.py", line 1702, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'clang-tidy'
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "./scripts/clang-tools/run-clang-tools.py", line 74, in <module>
main()
File "./scripts/clang-tools/run-clang-tools.py", line 70, in main
pool.map(run_analysis, datastore)
File "/usr/lib64/python3.8/multiprocessing/pool.py", line 364, in map
return self._map_async(func, iterable, mapstar, chunksize).get()
File "/usr/lib64/python3.8/multiprocessing/pool.py", line 771, in get
raise self._value
FileNotFoundError: [Errno 2] No such file or directory: 'clang-tidy'
The patch adds more user-friendly information on the missing tool by
catching FileNotFoundError for `clang-tidy` file and raising exception
again for possible other files:
$ ./scripts/clang-tools/run-clang-tools.py clang-tidy ./compile_commands.json
Command `clang-tidy` is missing in the system.
Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1342
---
scripts/clang-tools/run-clang-tools.py | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py
index fa7655c7cec0..38fc311d2e03 100755
--- a/scripts/clang-tools/run-clang-tools.py
+++ b/scripts/clang-tools/run-clang-tools.py
@@ -67,7 +67,13 @@ def main():
# Read JSON data into the datastore variable
with open(args.path, "r") as f:
datastore = json.load(f)
- pool.map(run_analysis, datastore)
+ try:
+ pool.map(run_analysis, datastore)
+ except FileNotFoundError as not_found:
+ if not_found.filename == 'clang-tidy':
+ print('Command `clang-tidy` is missing in the system.')
+ else:
+ raise not_found
if __name__ == "__main__":
--
2.26.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] Makefile: clang-tools: Omit printing stack trace when KeyboardInterrupt is raised
2021-05-20 23:18 [PATCH 1/2] Makefile: clang-tools: Print information when clang-tidy tool is missing Maciej Falkowski
@ 2021-05-20 23:18 ` Maciej Falkowski
2021-05-21 17:17 ` Nick Desaulniers
2021-05-20 23:56 ` [PATCH 1/2] Makefile: clang-tools: Print information when clang-tidy tool is missing Nick Desaulniers
1 sibling, 1 reply; 6+ messages in thread
From: Maciej Falkowski @ 2021-05-20 23:18 UTC (permalink / raw)
To: natechancellor, ndesaulniers
Cc: clang-built-linux, linux-kernel, maciej.falkowski9
When user terminates the script (also implicitly through for example
`make clang-analyzer`) by using
Ctrl+C (or sending SIGINT more generally) the KeyboardInterrupt
is raised printing stack trace of the execution as shown below:
$ ./scripts/clang-tools/run-clang-tools.py clang-tidy ./compile_commands.json
^CTraceback (most recent call last):
File "./scripts/clang-tools/run-clang-tools.py", line 74, in <module>
main()
File "./scripts/clang-tools/run-clang-tools.py", line 70, in main
pool.map(run_analysis, datastore)
File "/usr/lib64/python3.8/multiprocessing/pool.py", line 364, in map
return self._map_async(func, iterable, mapstar, chunksize).get()
File "/usr/lib64/python3.8/multiprocessing/pool.py", line 765, in get
self.wait(timeout)
File "/usr/lib64/python3.8/multiprocessing/pool.py", line 762, in wait
self._event.wait(timeout)
File "/usr/lib64/python3.8/threading.py", line 558, in wait
Process ForkPoolWorker-6:
Process ForkPoolWorker-1:
Process ForkPoolWorker-5:
Process ForkPoolWorker-7:
Process ForkPoolWorker-2:
Process ForkPoolWorker-3:
Process ForkPoolWorker-4:
Process ForkPoolWorker-8:
signaled = self._cond.wait(timeout)
File "/usr/lib64/python3.8/threading.py", line 302, in wait
waiter.acquire()
KeyboardInterrupt
The patch handles the raise of the KeyboardInterrupt and exits when occurred
with code 130 as documented in: https://tldp.org/LDP/abs/html/exitcodes.html
Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
---
scripts/clang-tools/run-clang-tools.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py
index 38fc311d2e03..eb0e0ecfce24 100755
--- a/scripts/clang-tools/run-clang-tools.py
+++ b/scripts/clang-tools/run-clang-tools.py
@@ -77,4 +77,7 @@ def main():
if __name__ == "__main__":
- main()
+ try:
+ main()
+ except KeyboardInterrupt:
+ sys.exit(130)
--
2.26.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Makefile: clang-tools: Print information when clang-tidy tool is missing
2021-05-20 23:18 [PATCH 1/2] Makefile: clang-tools: Print information when clang-tidy tool is missing Maciej Falkowski
2021-05-20 23:18 ` [PATCH 2/2] Makefile: clang-tools: Omit printing stack trace when KeyboardInterrupt is raised Maciej Falkowski
@ 2021-05-20 23:56 ` Nick Desaulniers
1 sibling, 0 replies; 6+ messages in thread
From: Nick Desaulniers @ 2021-05-20 23:56 UTC (permalink / raw)
To: Maciej Falkowski
Cc: Nathan Chancellor, clang-built-linux, LKML, Borislav Petkov,
Masahiro Yamada, Nathan Huckleberry
On Thu, May 20, 2021 at 4:18 PM Maciej Falkowski
<maciej.falkowski9@gmail.com> wrote:
>
> When `clang-tidy` tool is missing in the system, the FileNotFoundError
> exception is raised in the program reporting a stack trace to the user:
>
> $ ./scripts/clang-tools/run-clang-tools.py clang-tidy ./compile_commands.json
> multiprocessing.pool.RemoteTraceback:
> """
> Traceback (most recent call last):
> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 125, in worker
> result = (True, func(*args, **kwds))
> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 48, in mapstar
> return list(map(*args))
> File "./scripts/clang-tools/run-clang-tools.py", line 54, in run_analysis
> p = subprocess.run(["clang-tidy", "-p", args.path, checks, entry["file"]],
> File "/usr/lib64/python3.8/subprocess.py", line 489, in run
> with Popen(*popenargs, **kwargs) as process:
> File "/usr/lib64/python3.8/subprocess.py", line 854, in __init__
> self._execute_child(args, executable, preexec_fn, close_fds,
> File "/usr/lib64/python3.8/subprocess.py", line 1702, in _execute_child
> raise child_exception_type(errno_num, err_msg, err_filename)
> FileNotFoundError: [Errno 2] No such file or directory: 'clang-tidy'
> """
>
> The above exception was the direct cause of the following exception:
>
> Traceback (most recent call last):
> File "./scripts/clang-tools/run-clang-tools.py", line 74, in <module>
> main()
> File "./scripts/clang-tools/run-clang-tools.py", line 70, in main
> pool.map(run_analysis, datastore)
> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 364, in map
> return self._map_async(func, iterable, mapstar, chunksize).get()
> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 771, in get
> raise self._value
> FileNotFoundError: [Errno 2] No such file or directory: 'clang-tidy'
>
> The patch adds more user-friendly information on the missing tool by
> catching FileNotFoundError for `clang-tidy` file and raising exception
> again for possible other files:
>
> $ ./scripts/clang-tools/run-clang-tools.py clang-tidy ./compile_commands.json
> Command `clang-tidy` is missing in the system.
This is much nicer when I run:
$ make LLVM=1 LLVM_IAS=1 -j72 clang-analyzer
without clang-tidy built or installed locally, thank you for the patch.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Please make sure to include the results from running
./scripts/get_maintainer.pl on your patch files for the CC list.
>
> Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1342
> ---
> scripts/clang-tools/run-clang-tools.py | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py
> index fa7655c7cec0..38fc311d2e03 100755
> --- a/scripts/clang-tools/run-clang-tools.py
> +++ b/scripts/clang-tools/run-clang-tools.py
> @@ -67,7 +67,13 @@ def main():
> # Read JSON data into the datastore variable
> with open(args.path, "r") as f:
> datastore = json.load(f)
> - pool.map(run_analysis, datastore)
> + try:
> + pool.map(run_analysis, datastore)
> + except FileNotFoundError as not_found:
> + if not_found.filename == 'clang-tidy':
> + print('Command `clang-tidy` is missing in the system.')
> + else:
> + raise not_found
>
>
> if __name__ == "__main__":
> --
> 2.26.3
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Makefile: clang-tools: Omit printing stack trace when KeyboardInterrupt is raised
2021-05-20 23:18 ` [PATCH 2/2] Makefile: clang-tools: Omit printing stack trace when KeyboardInterrupt is raised Maciej Falkowski
@ 2021-05-21 17:17 ` Nick Desaulniers
2021-05-22 3:03 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Nick Desaulniers @ 2021-05-21 17:17 UTC (permalink / raw)
To: Maciej Falkowski
Cc: Nathan Chancellor, clang-built-linux, LKML, Masahiro Yamada
On Thu, May 20, 2021 at 4:18 PM Maciej Falkowski
<maciej.falkowski9@gmail.com> wrote:
>
> When user terminates the script (also implicitly through for example
> `make clang-analyzer`) by using
> Ctrl+C (or sending SIGINT more generally) the KeyboardInterrupt
> is raised printing stack trace of the execution as shown below:
>
> $ ./scripts/clang-tools/run-clang-tools.py clang-tidy ./compile_commands.json
> ^CTraceback (most recent call last):
> File "./scripts/clang-tools/run-clang-tools.py", line 74, in <module>
> main()
> File "./scripts/clang-tools/run-clang-tools.py", line 70, in main
> pool.map(run_analysis, datastore)
> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 364, in map
> return self._map_async(func, iterable, mapstar, chunksize).get()
> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 765, in get
> self.wait(timeout)
> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 762, in wait
> self._event.wait(timeout)
> File "/usr/lib64/python3.8/threading.py", line 558, in wait
> Process ForkPoolWorker-6:
> Process ForkPoolWorker-1:
> Process ForkPoolWorker-5:
> Process ForkPoolWorker-7:
> Process ForkPoolWorker-2:
> Process ForkPoolWorker-3:
> Process ForkPoolWorker-4:
> Process ForkPoolWorker-8:
> signaled = self._cond.wait(timeout)
> File "/usr/lib64/python3.8/threading.py", line 302, in wait
> waiter.acquire()
> KeyboardInterrupt
With this applied,
$ make LLVM=1 LLVM_IAS=1 -j72 clang-analyzer
^C
Process ForkPoolWorker-5:
make: *** [Makefile:1902: clang-analyzer] Error 130
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Thanks for the patch!
> The patch handles the raise of the KeyboardInterrupt and exits when occurred
> with code 130 as documented in: https://tldp.org/LDP/abs/html/exitcodes.html
>
> Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
> ---
> scripts/clang-tools/run-clang-tools.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py
> index 38fc311d2e03..eb0e0ecfce24 100755
> --- a/scripts/clang-tools/run-clang-tools.py
> +++ b/scripts/clang-tools/run-clang-tools.py
> @@ -77,4 +77,7 @@ def main():
>
>
> if __name__ == "__main__":
> - main()
> + try:
> + main()
> + except KeyboardInterrupt:
> + sys.exit(130)
> --
> 2.26.3
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Makefile: clang-tools: Omit printing stack trace when KeyboardInterrupt is raised
2021-05-21 17:17 ` Nick Desaulniers
@ 2021-05-22 3:03 ` Masahiro Yamada
2021-06-15 19:57 ` Maciej Falkowski
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2021-05-22 3:03 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Maciej Falkowski, Nathan Chancellor, clang-built-linux, LKML
On Sat, May 22, 2021 at 2:18 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Thu, May 20, 2021 at 4:18 PM Maciej Falkowski
> <maciej.falkowski9@gmail.com> wrote:
> >
> > When user terminates the script (also implicitly through for example
> > `make clang-analyzer`) by using
> > Ctrl+C (or sending SIGINT more generally) the KeyboardInterrupt
> > is raised printing stack trace of the execution as shown below:
> >
> > $ ./scripts/clang-tools/run-clang-tools.py clang-tidy ./compile_commands.json
> > ^CTraceback (most recent call last):
> > File "./scripts/clang-tools/run-clang-tools.py", line 74, in <module>
> > main()
> > File "./scripts/clang-tools/run-clang-tools.py", line 70, in main
> > pool.map(run_analysis, datastore)
> > File "/usr/lib64/python3.8/multiprocessing/pool.py", line 364, in map
> > return self._map_async(func, iterable, mapstar, chunksize).get()
> > File "/usr/lib64/python3.8/multiprocessing/pool.py", line 765, in get
> > self.wait(timeout)
> > File "/usr/lib64/python3.8/multiprocessing/pool.py", line 762, in wait
> > self._event.wait(timeout)
> > File "/usr/lib64/python3.8/threading.py", line 558, in wait
> > Process ForkPoolWorker-6:
> > Process ForkPoolWorker-1:
> > Process ForkPoolWorker-5:
> > Process ForkPoolWorker-7:
> > Process ForkPoolWorker-2:
> > Process ForkPoolWorker-3:
> > Process ForkPoolWorker-4:
> > Process ForkPoolWorker-8:
> > signaled = self._cond.wait(timeout)
> > File "/usr/lib64/python3.8/threading.py", line 302, in wait
> > waiter.acquire()
> > KeyboardInterrupt
>
> With this applied,
> $ make LLVM=1 LLVM_IAS=1 -j72 clang-analyzer
> ^C
> Process ForkPoolWorker-5:
> make: *** [Makefile:1902: clang-analyzer] Error 130
>
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Tested-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Thanks for the patch!
I am not a python expert, but is
"Let's suppress back-trace when a user presses an interrupt"
the common coding style?
If really so, do we need to do something similar in all python scripts?
I do not know what is special about run-clang-tools.py.
For example, if I press Ctrl-C while building Clang
by using tc-build, I see a back-trace.
I have never thought back-tracing was annoying.
The exit code is 130 regardless of this patch.
BTW, I prefer not having "Makefile:" in the patch subject
since this is not touching Makefile at all.
I rather like "clang-tools:" or "scripts/clang-tools:".
> > The patch handles the raise of the KeyboardInterrupt and exits when occurred
> > with code 130 as documented in: https://tldp.org/LDP/abs/html/exitcodes.html
> >
> > Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
> > ---
> > scripts/clang-tools/run-clang-tools.py | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py
> > index 38fc311d2e03..eb0e0ecfce24 100755
> > --- a/scripts/clang-tools/run-clang-tools.py
> > +++ b/scripts/clang-tools/run-clang-tools.py
> > @@ -77,4 +77,7 @@ def main():
> >
> >
> > if __name__ == "__main__":
> > - main()
> > + try:
> > + main()
> > + except KeyboardInterrupt:
> > + sys.exit(130)
> > --
> > 2.26.3
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Makefile: clang-tools: Omit printing stack trace when KeyboardInterrupt is raised
2021-05-22 3:03 ` Masahiro Yamada
@ 2021-06-15 19:57 ` Maciej Falkowski
0 siblings, 0 replies; 6+ messages in thread
From: Maciej Falkowski @ 2021-06-15 19:57 UTC (permalink / raw)
To: Masahiro Yamada, Nick Desaulniers
Cc: Nathan Chancellor, clang-built-linux, LKML
On 5/22/21 5:03 AM, Masahiro Yamada wrote:
> On Sat, May 22, 2021 at 2:18 AM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
>> On Thu, May 20, 2021 at 4:18 PM Maciej Falkowski
>> <maciej.falkowski9@gmail.com> wrote:
>>> When user terminates the script (also implicitly through for example
>>> `make clang-analyzer`) by using
>>> Ctrl+C (or sending SIGINT more generally) the KeyboardInterrupt
>>> is raised printing stack trace of the execution as shown below:
>>>
>>> $ ./scripts/clang-tools/run-clang-tools.py clang-tidy ./compile_commands.json
>>> ^CTraceback (most recent call last):
>>> File "./scripts/clang-tools/run-clang-tools.py", line 74, in <module>
>>> main()
>>> File "./scripts/clang-tools/run-clang-tools.py", line 70, in main
>>> pool.map(run_analysis, datastore)
>>> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 364, in map
>>> return self._map_async(func, iterable, mapstar, chunksize).get()
>>> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 765, in get
>>> self.wait(timeout)
>>> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 762, in wait
>>> self._event.wait(timeout)
>>> File "/usr/lib64/python3.8/threading.py", line 558, in wait
>>> Process ForkPoolWorker-6:
>>> Process ForkPoolWorker-1:
>>> Process ForkPoolWorker-5:
>>> Process ForkPoolWorker-7:
>>> Process ForkPoolWorker-2:
>>> Process ForkPoolWorker-3:
>>> Process ForkPoolWorker-4:
>>> Process ForkPoolWorker-8:
>>> signaled = self._cond.wait(timeout)
>>> File "/usr/lib64/python3.8/threading.py", line 302, in wait
>>> waiter.acquire()
>>> KeyboardInterrupt
>> With this applied,
>> $ make LLVM=1 LLVM_IAS=1 -j72 clang-analyzer
>> ^C
>> Process ForkPoolWorker-5:
>> make: *** [Makefile:1902: clang-analyzer] Error 130
>>
>> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>> Tested-by: Nick Desaulniers <ndesaulniers@google.com>
>>
>> Thanks for the patch!
>
> I am not a python expert, but is
> "Let's suppress back-trace when a user presses an interrupt"
> the common coding style?
I think that is not a common coding style.
In this case, the back-trace is verbose and it is caused
by a bug in multiprocessing Pool.
> If really so, do we need to do something similar in all python scripts?
> I do not know what is special about run-clang-tools.py.
I think no, I misunderstood the nature of the problem.
The verbose back-trace is a result of the multiprocessing Pool
not handling KeyboardInterrupt properly.
It is the old bug(bugs.python.org/issue8296), yet to be
solved(bugs.python.org/issue22393).
For more info please see:
https://stackoverflow.com/questions/1408356/keyboard-interrupts-with-pythons-multiprocessing-pool
This issue is already once solved in a Linux source tree in a
scripts/checkkconfigsymbols.py:
scripts/checkkconfigsymbols.py:312
try:
return check_symbols_helper(pool, ignore)
except KeyboardInterrupt:
pool.terminate()
pool.join()
sys.exit(1)
Also the comment:
scripts/checkkconfigsymbols.py:321
"""Helper method for check_symbols(). Used to catch keyboard interrupts in
check_symbols() in order to properly terminate running worker processes."""
> For example, if I press Ctrl-C while building Clang
> by using tc-build, I see a back-trace.
> I have never thought back-tracing was annoying.
>
> The exit code is 130 regardless of this patch.
Okay.
>
> BTW, I prefer not having "Makefile:" in the patch subject
> since this is not touching Makefile at all.
>
> I rather like "clang-tools:" or "scripts/clang-tools:".
>
Okay.
The solution should cover the whole bug, I think this patch
may be dismissed then.
Thank you for your feedback!
Best regards,
Maciej Falkowski
>
>
>
>
>
>>> The patch handles the raise of the KeyboardInterrupt and exits when occurred
>>> with code 130 as documented in: https://tldp.org/LDP/abs/html/exitcodes.html
>>>
>>> Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
>>> ---
>>> scripts/clang-tools/run-clang-tools.py | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py
>>> index 38fc311d2e03..eb0e0ecfce24 100755
>>> --- a/scripts/clang-tools/run-clang-tools.py
>>> +++ b/scripts/clang-tools/run-clang-tools.py
>>> @@ -77,4 +77,7 @@ def main():
>>>
>>>
>>> if __name__ == "__main__":
>>> - main()
>>> + try:
>>> + main()
>>> + except KeyboardInterrupt:
>>> + sys.exit(130)
>>> --
>>> 2.26.3
>>>
>>
>> --
>> Thanks,
>> ~Nick Desaulniers
>
>
> --
> Best Regards
> Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-15 19:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20 23:18 [PATCH 1/2] Makefile: clang-tools: Print information when clang-tidy tool is missing Maciej Falkowski
2021-05-20 23:18 ` [PATCH 2/2] Makefile: clang-tools: Omit printing stack trace when KeyboardInterrupt is raised Maciej Falkowski
2021-05-21 17:17 ` Nick Desaulniers
2021-05-22 3:03 ` Masahiro Yamada
2021-06-15 19:57 ` Maciej Falkowski
2021-05-20 23:56 ` [PATCH 1/2] Makefile: clang-tools: Print information when clang-tidy tool is missing Nick Desaulniers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.