All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: Joe Perches <joe@perches.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] genksyms: keywords: Use __restrict not _restrict
Date: Fri, 14 Aug 2020 19:14:31 -0700	[thread overview]
Message-ID: <CAKwvOd=8C94K-9VCqdCn9FXiyfDhKxMu=4AGem1bGgp8m6z0fw@mail.gmail.com> (raw)
In-Reply-To: <15f52e9b0e50296aba35871bc1575a684c4a258a.camel@perches.com>

On Fri, Aug 14, 2020 at 6:38 PM Joe Perches <joe@perches.com> wrote:
>
> Use the proper form of the RESTRICT keyword.
>
> Quote the comments properly too.
>
> Signed-off-by: Joe Perches <joe@perches.com>

Acked-by: Nick Desaulniers <ndesaulniers@google.com>

(Surprised what looked to me like a typo compiled).  Would a
checkpatch warning be helpful, too? What's KAO? Urban dictionary has
no entry. :^P

> ---
>  scripts/genksyms/keywords.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/genksyms/keywords.c b/scripts/genksyms/keywords.c
> index 7a85c4e21175..057c6cabad1d 100644
> --- a/scripts/genksyms/keywords.c
> +++ b/scripts/genksyms/keywords.c
> @@ -25,9 +25,9 @@ static struct resword {
>         { "__int128_t", BUILTIN_INT_KEYW },
>         { "__uint128_t", BUILTIN_INT_KEYW },
>
> -       // According to rth, c99 defines "_Bool", __restrict", __restrict__", "restrict".  KAO
> +       // According to rth, c99 defines "_Bool", "__restrict", "__restrict__", "restrict".  KAO
>         { "_Bool", BOOL_KEYW },
> -       { "_restrict", RESTRICT_KEYW },
> +       { "__restrict", RESTRICT_KEYW },
>         { "__restrict__", RESTRICT_KEYW },
>         { "restrict", RESTRICT_KEYW },
>         { "asm", ASM_KEYW },
>


-- 
Thanks,
~Nick Desaulniers

  reply	other threads:[~2020-08-15 21:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-15  1:38 [PATCH] genksyms: keywords: Use __restrict not _restrict Joe Perches
2020-08-15  2:14 ` Nick Desaulniers [this message]
2020-08-15  3:05   ` Linus Torvalds
2020-08-15  3:17     ` Joe Perches
2020-08-15 22:46       ` Randy Dunlap
2020-08-18  1:05         ` Masahiro Yamada
2020-08-18  3:32           ` Randy Dunlap
2020-08-18 11:15             ` Masahiro Yamada
2020-08-15 21:30     ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKwvOd=8C94K-9VCqdCn9FXiyfDhKxMu=4AGem1bGgp8m6z0fw@mail.gmail.com' \
    --to=ndesaulniers@google.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.