From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D19C433F5 for ; Tue, 26 Apr 2022 16:40:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353062AbiDZQnS (ORCPT ); Tue, 26 Apr 2022 12:43:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345421AbiDZQnP (ORCPT ); Tue, 26 Apr 2022 12:43:15 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 903D6DFF7 for ; Tue, 26 Apr 2022 09:40:07 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 16so7597969lju.13 for ; Tue, 26 Apr 2022 09:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cB5NjQgyHxPYEpDTZ0PSuz+LJmELdLbWCQhQbA445xM=; b=jIea80rv6317KJHDIdWEbWLBH461Z6ATA9dHEddVM6shF40hnoZ/lnlgYWIl1caWXG Yb/G0dSCt5pOJZdvCTEDTQrIg045MQkLNpLdop5n97g8AavwMV2wfDM3puA15FUjILKx 8MBe4JSCXWmgocvd1aXyzegdZiEZFRlgw2J7xvdT1yj4JaKHfkKZeFo/awKotDRDuPJn +RzFukr2Ks+iaDANd0a83Usr7Xto7N6PiN1/9da4lpYRdntlJem0jBBIdrO959nSeSf+ Dkj+H1b+xJNcmsONZxRDhqxHl8H0EnAGmUQSo4ts0TxJnlECnnqc/QWm9y4clr6yXM9c OGNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cB5NjQgyHxPYEpDTZ0PSuz+LJmELdLbWCQhQbA445xM=; b=uwpOr0W64cuW2dUBxB5EWVui6Eashm1GAgZ2YpjQWrB2nPO2B8hvraUS0xBAFX+wu4 GbmuKWIewbsQT3oMzboExomPHpNe2hwUNnnFPi68SKMAV+KoZJEzKAdhi+1mupnA1VQS /XWThbR8+imC1Qj6zxpqXbfxYJ4CggZpiL3iANMr9IacePdTZw1Y7nzbeTqtfu/yNlBW 4F/FWD7MzZgoL1/L4SW8K3L+yZMVRxBwjE9TJOJY76DWWN8iar913n92+agUGPLCYSLN vLYQz3RJyih8pZ7oQgQ/2o/iLEd0PawR1UFMRNlyN1OBolBikoRg3CGTbtULnazyX2ye ERXw== X-Gm-Message-State: AOAM530cxCcdwkH3JWYlHXpGQUf/elEbIxElaGT76DdIFDYaQADLNzQc E2odTvbf5O63/XJ9iKW8hP9oYUScttmA+mq6/JaaAHP2iZE= X-Google-Smtp-Source: ABdhPJzCHG1DW6WwNCEQQr1E6ENnVyF3MYLe1M7kwazJPqDOFzVfHEITcsPFkNsdFROU9SnNXltpQ8u9ocAyT++DhiQ= X-Received: by 2002:a2e:a7d4:0:b0:24d:b0c3:9683 with SMTP id x20-20020a2ea7d4000000b0024db0c39683mr14669411ljp.472.1650991205358; Tue, 26 Apr 2022 09:40:05 -0700 (PDT) MIME-Version: 1.0 References: <20220424190811.1678416-1-masahiroy@kernel.org> <20220424190811.1678416-17-masahiroy@kernel.org> In-Reply-To: From: Nick Desaulniers Date: Tue, 26 Apr 2022 09:39:54 -0700 Message-ID: Subject: Re: [PATCH 16/27] modpost: make multiple export error To: Masahiro Yamada Cc: Linux Kbuild mailing list , Linux Kernel Mailing List , Michal Marek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 25, 2022 at 9:10 PM Masahiro Yamada wrote: > > On Tue, Apr 26, 2022 at 3:48 AM Nick Desaulniers > wrote: > > > > On Sun, Apr 24, 2022 at 12:09 PM Masahiro Yamada wrote: > > > > > > This is currently a warning, but I think modpost should stop building > > > in this case. > > > > > > If the same symbol is exported multiple times and we let it keep going, > > > the sanity check becomes difficult. > > > > > > Only the legitimate case is that an external module overrides the > > > corresponding in-tree module to provide a different implementation > > > with the same interface. > > > > Could the same module export a weak version of a symbol, and a strong one? > > No. There is no concept like EXPORT_SYMBOL_WEAK. > > I am talking about kmod things. > You can modprobe an external module instead of the in-kernel one. Ok, this patch seems fine to me. Reviewed-by: Nick Desaulniers -- Thanks, ~Nick Desaulniers