From: Nick Desaulniers <ndesaulniers@google.com> To: Masahiro Yamada <masahiroy@kernel.org> Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor <nathan@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>, Peter Zijlstra <peterz@infradead.org>, linux-modules@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ard Biesheuvel <ardb@kernel.org>, Sami Tolvanen <samitolvanen@google.com>, clang-built-linux <llvm@lists.linux.dev> Subject: Re: [PATCH v4 03/14] modpost: split the section mismatch checks into section-check.c Date: Mon, 9 May 2022 10:19:47 -0700 [thread overview] Message-ID: <CAKwvOd=LR=UNOeWJDmM-McJ=FrCWTo8w1ox+KGMQCwCVpiUyFg@mail.gmail.com> (raw) In-Reply-To: <20220508190631.2386038-4-masahiroy@kernel.org> On Sun, May 8, 2022 at 12:10 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > modpost.c is too big, and the half of the code is for section checks. > Split it. > > I fixed some style issues in the moved code. It would be helpful for review if the split and restyle were distinct patches. Otherwise I can't tell what has changed. This does lose the ability to use git blame to get more context on some of the oddities in modpost (which I have found useful in the past). I don't feel strongly though. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > Changes in v4: > - New patch > > scripts/mod/Makefile | 2 +- > scripts/mod/modpost.c | 1202 +--------------------------------- > scripts/mod/modpost.h | 34 +- > scripts/mod/section-check.c | 1222 +++++++++++++++++++++++++++++++++++ > 4 files changed, 1240 insertions(+), 1220 deletions(-) > create mode 100644 scripts/mod/section-check.c > > diff --git a/scripts/mod/Makefile b/scripts/mod/Makefile > index c9e38ad937fd..ca739c6c68a1 100644 > --- a/scripts/mod/Makefile > +++ b/scripts/mod/Makefile > @@ -5,7 +5,7 @@ CFLAGS_REMOVE_empty.o += $(CC_FLAGS_LTO) > hostprogs-always-y += modpost mk_elfconfig > always-y += empty.o > > -modpost-objs := modpost.o file2alias.o sumversion.o > +modpost-objs := modpost.o section-check.o file2alias.o sumversion.o > > devicetable-offsets-file := devicetable-offsets.h > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index a78b75f0eeb0..e7e2c70a98f5 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -31,7 +31,7 @@ static bool external_module; > /* Only warn about unresolved symbols */ > static bool warn_unresolved; > > -static int sec_mismatch_count; > +int sec_mismatch_count; ^ this should go in modpost.h if it is to be used in two translation units, rather than forward declaring it in section-check.c. You did this for the functions. -- Thanks, ~Nick Desaulniers
WARNING: multiple messages have this Message-ID (diff)
From: Nick Desaulniers <ndesaulniers@google.com> To: Masahiro Yamada <masahiroy@kernel.org> Cc: linux-s390@vger.kernel.org, Nicolas Schier <nicolas@fjasle.eu>, linux-kbuild@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, clang-built-linux <llvm@lists.linux.dev>, linux-kernel@vger.kernel.org, Nathan Chancellor <nathan@kernel.org>, Sami Tolvanen <samitolvanen@google.com>, linuxppc-dev@lists.ozlabs.org, Ard Biesheuvel <ardb@kernel.org>, linux-modules@vger.kernel.org Subject: Re: [PATCH v4 03/14] modpost: split the section mismatch checks into section-check.c Date: Mon, 9 May 2022 10:19:47 -0700 [thread overview] Message-ID: <CAKwvOd=LR=UNOeWJDmM-McJ=FrCWTo8w1ox+KGMQCwCVpiUyFg@mail.gmail.com> (raw) In-Reply-To: <20220508190631.2386038-4-masahiroy@kernel.org> On Sun, May 8, 2022 at 12:10 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > modpost.c is too big, and the half of the code is for section checks. > Split it. > > I fixed some style issues in the moved code. It would be helpful for review if the split and restyle were distinct patches. Otherwise I can't tell what has changed. This does lose the ability to use git blame to get more context on some of the oddities in modpost (which I have found useful in the past). I don't feel strongly though. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > Changes in v4: > - New patch > > scripts/mod/Makefile | 2 +- > scripts/mod/modpost.c | 1202 +--------------------------------- > scripts/mod/modpost.h | 34 +- > scripts/mod/section-check.c | 1222 +++++++++++++++++++++++++++++++++++ > 4 files changed, 1240 insertions(+), 1220 deletions(-) > create mode 100644 scripts/mod/section-check.c > > diff --git a/scripts/mod/Makefile b/scripts/mod/Makefile > index c9e38ad937fd..ca739c6c68a1 100644 > --- a/scripts/mod/Makefile > +++ b/scripts/mod/Makefile > @@ -5,7 +5,7 @@ CFLAGS_REMOVE_empty.o += $(CC_FLAGS_LTO) > hostprogs-always-y += modpost mk_elfconfig > always-y += empty.o > > -modpost-objs := modpost.o file2alias.o sumversion.o > +modpost-objs := modpost.o section-check.o file2alias.o sumversion.o > > devicetable-offsets-file := devicetable-offsets.h > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index a78b75f0eeb0..e7e2c70a98f5 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -31,7 +31,7 @@ static bool external_module; > /* Only warn about unresolved symbols */ > static bool warn_unresolved; > > -static int sec_mismatch_count; > +int sec_mismatch_count; ^ this should go in modpost.h if it is to be used in two translation units, rather than forward declaring it in section-check.c. You did this for the functions. -- Thanks, ~Nick Desaulniers
next prev parent reply other threads:[~2022-05-09 17:20 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-08 19:06 [PATCH v4 00/14] kbuild: yet another series of cleanups (modpost, LTO, MODULE_REL_CRCS, export.h) Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-08 19:06 ` [PATCH v4 01/14] modpost: remove left-over cross_compile declaration Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-09 17:08 ` Nick Desaulniers 2022-05-09 17:08 ` Nick Desaulniers 2022-05-12 4:35 ` Masahiro Yamada 2022-05-12 4:35 ` Masahiro Yamada 2022-05-08 19:06 ` [PATCH v4 02/14] modpost: change the license of EXPORT_SYMBOL to bool type Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-12 4:36 ` Masahiro Yamada 2022-05-12 4:36 ` Masahiro Yamada 2022-05-08 19:06 ` [PATCH v4 03/14] modpost: split the section mismatch checks into section-check.c Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-09 17:19 ` Nick Desaulniers [this message] 2022-05-09 17:19 ` Nick Desaulniers 2022-05-10 6:55 ` Masahiro Yamada 2022-05-10 6:55 ` Masahiro Yamada 2022-05-11 18:47 ` Nick Desaulniers 2022-05-11 18:47 ` Nick Desaulniers 2022-05-11 19:27 ` Masahiro Yamada 2022-05-11 19:27 ` Masahiro Yamada 2022-05-11 19:51 ` Jeff Johnson 2022-05-11 19:51 ` Jeff Johnson 2022-05-11 20:01 ` Nick Desaulniers 2022-05-11 20:01 ` Nick Desaulniers 2022-05-08 19:06 ` [PATCH v4 04/14] modpost: add sym_find_with_module() helper Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-08 19:06 ` [PATCH v4 05/14] modpost: extract symbol versions from *.cmd files Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-09 21:52 ` Sami Tolvanen 2022-05-09 21:52 ` Sami Tolvanen 2022-05-08 19:06 ` [PATCH v4 06/14] kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-09 17:50 ` Nick Desaulniers 2022-05-09 17:50 ` Nick Desaulniers 2022-05-10 13:03 ` Masahiro Yamada 2022-05-10 13:03 ` Masahiro Yamada 2022-05-08 19:06 ` [PATCH v4 07/14] kbuild: stop merging *.symversions Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-08 19:06 ` [PATCH v4 08/14] genksyms: adjust the output format to modpost Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-08 19:06 ` [PATCH v4 09/14] kbuild: do not create *.prelink.o for Clang LTO or IBT Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-09 23:13 ` Sami Tolvanen 2022-05-09 23:13 ` Sami Tolvanen 2022-05-08 19:06 ` [PATCH v4 10/14] kbuild: check static EXPORT_SYMBOL* by script instead of modpost Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-09 18:05 ` Nick Desaulniers 2022-05-09 18:05 ` Nick Desaulniers 2022-05-10 13:53 ` Masahiro Yamada 2022-05-10 13:53 ` Masahiro Yamada 2022-05-08 19:06 ` [PATCH v4 11/14] kbuild: make built-in.a rule robust against too long argument error Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-08 19:06 ` [PATCH v4 12/14] kbuild: make *.mod " Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-08 19:06 ` [PATCH v4 13/14] kbuild: add cmd_and_savecmd macro Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-08 19:06 ` [PATCH v4 14/14] kbuild: rebuild multi-object modules when objtool is updated Masahiro Yamada 2022-05-08 19:06 ` Masahiro Yamada 2022-05-09 4:24 ` [PATCH v4 00/14] kbuild: yet another series of cleanups (modpost, LTO, MODULE_REL_CRCS, export.h) Masahiro Yamada 2022-05-09 4:24 ` Masahiro Yamada 2022-05-09 22:13 ` Nathan Chancellor 2022-05-09 22:13 ` Nathan Chancellor 2022-05-10 6:55 ` Masahiro Yamada 2022-05-10 6:55 ` Masahiro Yamada 2022-05-09 22:19 ` Nathan Chancellor 2022-05-09 22:19 ` Nathan Chancellor
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKwvOd=LR=UNOeWJDmM-McJ=FrCWTo8w1ox+KGMQCwCVpiUyFg@mail.gmail.com' \ --to=ndesaulniers@google.com \ --cc=ardb@kernel.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-modules@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=llvm@lists.linux.dev \ --cc=masahiroy@kernel.org \ --cc=nathan@kernel.org \ --cc=nicolas@fjasle.eu \ --cc=peterz@infradead.org \ --cc=samitolvanen@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.