From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF4BC433E0 for ; Thu, 28 Jan 2021 19:00:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44CA564E27 for ; Thu, 28 Jan 2021 19:00:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44CA564E27 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zssQqbuo8Pz3duqxsyGHwJcGi/cvwbA6cWS8Gu5KGrw=; b=x+1K9hOa2rKsQQr8WBmreAbg2 mUS+StOZ6ccFjUXQok8V3576RibULujQbTnfvIlvRFwtKkRswORY5M5QY+XLY80hFFpaZhSg6f/tb Jjsura+C7qXpmrMgDkWCxcQ4utw/qAZI6wYdbQBEhqR07Q70ZBPCfhIrsxDq7XFDNSeTRBG3rmKIG 2m39CRnTj+zF0mvaVtRDtlGn7WRsKWwY/HdwcobIBuINJym2rlzctaRaxtyQZXR2HtHcfthK9lRms gYsYTAtyQyV08QjM9F6LA5wOol0HFIPzpu6DFpHsJ+oAkGC5xkHsoZUeBwgBtDtlF9ysRnbdX0AhB YizWfIs4w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5CVl-0004b3-Ve; Thu, 28 Jan 2021 18:59:22 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5CVj-0004aR-Qk for linux-arm-kernel@lists.infradead.org; Thu, 28 Jan 2021 18:59:20 +0000 Received: by mail-pg1-x52e.google.com with SMTP id c132so4893449pga.3 for ; Thu, 28 Jan 2021 10:59:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jjSXs+FCSZ4k0Esl52QXVJHzbGTPt05ZJ1TYO+nt1PI=; b=XL6sjjvNuk7/AOKgUk3bN7ak12YmcjXvlH5PMt60ISdS36Q2XrlO4/LrhF5dn6cvgb gpKbCQcLLFkunqv41tCOimSj1TFZ+t9JWqofcwRWAnVAsQBGoP1x0ORCmzHRPrkiE8CE pCpy5fwIsCTDM/KjSL+wKORnn8Pm7iZCcXAN3XfM/34sYsUwVoFomKJMJUQK2NeD7rAa LtaJKtD3zm59doRDE/BLAJOA7P9T8BAhQAbEfdUgouxGx8BXToYiY1+03Iy2TPR1gp2m ssBfap4mTDvR/FhGsidpNwdEyNwkgtB2jcCWlrawJdWxurapdiletQSs+KjaXOyxl656 8fSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jjSXs+FCSZ4k0Esl52QXVJHzbGTPt05ZJ1TYO+nt1PI=; b=HPBr6+fKRsc4CUZPK3vkTt7xUE0z0uFAqJRHpSyFdzjtU3uV1sEbqI8QdzLKMYCPQ8 Ev/dMOw9yJb/IP470oiMRS0eIb2GinSTnM849OsND8E1dwwyF/vWciHb+P4krQzc5LvU QPSHUcais+GY/nyznDiYG5WG0BQLJekCj+m59Uzl/hd05+kfODUAeMFf2EU7Wzyb3Zm0 /VgWM5vvmxFD7MYeY4km1jJbpkR+SksCEhvYCvBi+cbHOi6FM81cqb/Ssbu0i2HBnO7l +Ii/bgUjZSqtRESTLMzyelfwDKIL6ap87JtGAKX/wzRG/cJv7e7wHFOtfBXvEmYuRFkX ojQQ== X-Gm-Message-State: AOAM531B4zzRsipI9jiC/etg3/l3M5UzeZq7xIwZXKUQOMFjxoPL+brT A7TTvH7TuoBwGIVmVOTIXhvcGlQ700ni+2adAToSVQ== X-Google-Smtp-Source: ABdhPJw7q3lYmDUugwXBPh+z+k3aRQKs3IrDDSCi8CO5j8OHEb3kDOeIf+aPbPQTxQSNgcuPQWu7HO4KBD5DLaUmmFY= X-Received: by 2002:a65:4201:: with SMTP id c1mr867900pgq.10.1611860356233; Thu, 28 Jan 2021 10:59:16 -0800 (PST) MIME-Version: 1.0 References: <20210128044356.38419-1-ndesaulniers@google.com> In-Reply-To: From: Nick Desaulniers Date: Thu, 28 Jan 2021 10:59:05 -0800 Message-ID: Subject: Re: [PATCH] ARM: kprobes: rewrite in UAL To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210128_135919_908815_FAA040CA X-CRM114-Status: GOOD ( 19.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , "linux-kernel@vger.kernel.org" , Russell King , clang-built-linux , Nathan Chancellor , Ard Biesheuvel , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 28, 2021 at 8:15 AM Arnd Bergmann wrote: > > On Thu, Jan 28, 2021 at 5:44 AM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > Clang's integrated assembler only accepts UAL syntax, rewrite the > > instructions that were changed by RVCTv2.1. > > > > The document "Assembly language changes after RVCTv2.1" was very > > helpful. > > > > This exposed a bug in Clang's integrated assembler, which hopefully will > > land in clang-12, but is required to test this patch with LLVM_IAS=1. > > > > Link: https://developer.arm.com/documentation/dui0473/c/writing-arm-assembly-language/assembly-language-changes-after-rvctv2-1 > > Link: https://github.com/ClangBuiltLinux/linux/issues/1271 > > Link: https://reviews.llvm.org/D95586 > > Reported-by: Arnd Bergmann > > Signed-off-by: Nick Desaulniers > > --- > > arch/arm/probes/kprobes/test-arm.c | 288 ++++++++++++++--------------- > > 1 file changed, 144 insertions(+), 144 deletions(-) > > This mostly works, but I see one extra case in some configurations: > > > :20:5: note: instantiated into assembly here > 1: swpvsb r0, r1, [sp] > ^~~~~~ Thanks, I was able to repro with at91_dt_defconfig + Kprobes. > Plus a lot of extra errors when building with CONFIG_THUMB2_KERNEL, > as that uses tests in arch/arm/probes/kprobes/test-thumb.c. Technically, that's a distinctly separate issue; arch/arm/probes/kprobes/test-arm.c is not built with CONFIG_THUMB2_KERNEL=y. This patch doesn't introduce those warnings; that file has the same issue but it is separate from test-arm.c. Would you prefer to see a v2 with the swpvsb fix contain fixes for test-thumb.c as well, or a separate patch for that? -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel