From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B91CC433F5 for ; Tue, 26 Apr 2022 16:30:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352931AbiDZQdR (ORCPT ); Tue, 26 Apr 2022 12:33:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353007AbiDZQdN (ORCPT ); Tue, 26 Apr 2022 12:33:13 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0221E211 for ; Tue, 26 Apr 2022 09:30:04 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id s27so6980177ljd.2 for ; Tue, 26 Apr 2022 09:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Yq22b/HAxllmL6hgEgORnDmMTH7ARb+QJMH7dTolZlM=; b=f9JX3iL//TVo3SLhOeUU2LpFUmTDH96Lj++Z7olpnXao0zd/qV0kZifymTBhBvYooF V0KYkCiAuXXOndmp1SvYwVMwnKgeris7HxkMU8406kMsx0IbidjY+T4MkQNUIgGGNCbp QYzHFKqYoE+XTPOE/CSSn2+6n8s/6tmFzijWaJ7pl+2rKbP/NFgG7b+rv48DqWvELyUA ZjwwDQUZBg/2Rhz5V2y0ykguM5AlHWs5klwjHaA48vgvS2BBoyJF3KKtSFW+Txyuxmr1 Wl4dii6gNNZl2BmtBltdRHxSoS80T57ZZQbwuU8kuUzB+3tdxMNT3W7tDP0nM4ZsZ6hx kA1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Yq22b/HAxllmL6hgEgORnDmMTH7ARb+QJMH7dTolZlM=; b=RcY7YGMEqAjjzoqLMI6GGq55baeuGCZaPI4XEToA9z5ZUXla+GsKWBugnxjBypeVd2 3rQiEwEzBHB9sgjS5Ib5U5ayWHa4+591ULR2dCw/UDtbFtCHDAitrIl5meDRdoPbePfd Xijvg/u2//isRrxX6Exbqzgf8Nl2Kd05wszn1Q7HykUTGh67Pbn1lYx0QzWC256OkDuv B4u3tpx4l2fza8ibYIy6yaNUn27mmF2HDQjoaMFhWkz/y1kTsi5SnJ0rRME6VawyqiEk 5w38qNC83O5hpNMeNvE7Dw+R9u+nOy6W7rxu305VujzEfv8mmcLSRYlUWJaHKwVZvk4e 4ciQ== X-Gm-Message-State: AOAM533WUl9rXsSQ3pc1PVAzjyrnihlzfRC2vKjaXfUpJgyDb1oRnq3O /KQPrRTWGMV3fFVNe8ip9yVr8lUIx7rge069lI9f4b0+frA= X-Google-Smtp-Source: ABdhPJxtV0frJu8QtkHSjZ7G17y8dVCS1oHhbqWmGgnLfpgcLuyi2Q2tBOYlosgu/7IoqC6Uh3zrzYlorV3mbCXkJXs= X-Received: by 2002:a05:651c:553:b0:24f:18c1:d2a1 with SMTP id q19-20020a05651c055300b0024f18c1d2a1mr3429125ljp.239.1650990601997; Tue, 26 Apr 2022 09:30:01 -0700 (PDT) MIME-Version: 1.0 References: <20220424190811.1678416-1-masahiroy@kernel.org> <20220424190811.1678416-8-masahiroy@kernel.org> In-Reply-To: <20220424190811.1678416-8-masahiroy@kernel.org> From: Nick Desaulniers Date: Tue, 26 Apr 2022 09:29:50 -0700 Message-ID: Subject: Re: [PATCH 07/27] modpost: import include/linux/list.h To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Marek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 24, 2022 at 12:09 PM Masahiro Yamada wrote: > > Import include/linux/list.h to use convenient list macros in modpost. > > I dropped kernel-space code such as {WRITE,READ}_ONCE etc. and unneeded > macros. > > I also imported container_of() from include/linux/container_of.h and > type definitions from include/linux/types.h. > > Signed-off-by: Masahiro Yamada Ok then, just two small nits about two comments, which may have been just copied over from the sources. Reviewed-by: Nick Desaulniers > --- > > scripts/mod/list.h | 336 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 336 insertions(+) > create mode 100644 scripts/mod/list.h > > diff --git a/scripts/mod/list.h b/scripts/mod/list.h > new file mode 100644 > index 000000000000..c87583a71714 > --- /dev/null > +++ b/scripts/mod/list.h > @@ -0,0 +1,336 @@ > +/** > + * list_for_each_entry - iterate over list of given type ^ Excessive whitespace after the `-` > + * @pos: the type * to use as a loop cursor. > + * @head: the head for your list. > + * @member: the name of the list_head within the struct. > + */ > +#define list_for_each_entry(pos, head, member) \ > + for (pos = list_first_entry(head, typeof(*pos), member); \ > + !list_entry_is_head(pos, head, member); \ > + pos = list_next_entry(pos, member)) > + > +/** > + * list_for_each_entry_safe - iterate over list of given type safe against removal of list entry ^ This sounds like two sentences and looks like it's missing punctuation separating them? "iterate over list of given type. Safe against removal of list entry" -- Thanks, ~Nick Desaulniers