From: Nick Desaulniers <ndesaulniers@google.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
Michal Marek <michal.lkml@markovi.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] kbuild: add -Wno-unused-but-set-variable compiler flag unconditionally
Date: Mon, 1 Oct 2018 10:17:12 -0700 [thread overview]
Message-ID: <CAKwvOd=R1FN_nmR4Wkpb=nTt+v2f2+uWOcQCFoB+B1hWzCXCXA@mail.gmail.com> (raw)
In-Reply-To: <1538387078-21892-3-git-send-email-yamada.masahiro@socionext.com>
On Mon, Oct 1, 2018 at 2:45 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> We have raised the compiler requirement from time to time.
> With commit cafa0010cd51 ("Raise the minimum required gcc version
> to 4.6"), the minimum for GCC is 4.6 now.
>
> This flag was added by GCC 4.6, and it is recognized by Clang and
> ICC as well.
This doesn't seem to be the case for Clang:
https://godbolt.org/z/qesF5o
Nacked-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Let's rip off the cc-disable-warning switch, and see if somebody
> complains about it.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 8a23fee..2627266 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -716,7 +716,7 @@ else
>
> # These warnings generated too much noise in a regular build.
> # Use make W=1 to enable them (see scripts/Makefile.extrawarn)
> -KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
> +KBUILD_CFLAGS += -Wno-unused-but-set-variable
> endif
>
> KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
> --
> 2.7.4
>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2018-10-01 17:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 9:44 [PATCH 1/3] kbuild: add -Wno-pointer-sign flag unconditionally Masahiro Yamada
2018-10-01 9:44 ` [PATCH 2/3] kbuild: add -Wdeclaration-after-statement " Masahiro Yamada
2018-10-01 17:21 ` Nick Desaulniers
2018-10-09 14:58 ` Masahiro Yamada
2018-10-01 9:44 ` [PATCH 3/3] kbuild: add -Wno-unused-but-set-variable compiler " Masahiro Yamada
2018-10-01 17:17 ` Nick Desaulniers [this message]
2018-10-01 19:01 ` Masahiro Yamada
2018-10-01 19:58 ` Nick Desaulniers
2018-10-01 22:23 ` Masahiro Yamada
2018-10-01 22:36 ` Nick Desaulniers
2018-10-01 17:24 ` [PATCH 1/3] kbuild: add -Wno-pointer-sign " Nick Desaulniers
2018-10-09 14:57 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOd=R1FN_nmR4Wkpb=nTt+v2f2+uWOcQCFoB+B1hWzCXCXA@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.