From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6FCBC433DF for ; Wed, 24 Jun 2020 20:57:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 798122075A for ; Wed, 24 Jun 2020 20:57:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BPMaWjSi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389038AbgFXU50 (ORCPT ); Wed, 24 Jun 2020 16:57:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728798AbgFXU5Z (ORCPT ); Wed, 24 Jun 2020 16:57:25 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4743AC061573 for ; Wed, 24 Jun 2020 13:57:25 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id r18so2021015pgk.11 for ; Wed, 24 Jun 2020 13:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2UVd4Vpuu4Hnm6XlHGR5cRrZnqXWEFfAzghKkxqA5PE=; b=BPMaWjSiHqVF8vi4hiTlzAVhVpOBnqRB11zTq0lEeedJqVV+du+PNZ4KmaMlIsirPC R928oKYPPNEK406mCXXrFo5ILeh9cKok03PTJz6JfAnRQKQCv1Rh1SMBWeCtT9nOL0oJ lryLagao4wnwA1qFmJ4sPzSNGD7lPYGa8eVmfocCRrLBf+dhWLYjqG85ZdT9LeohIlOb 2EmJnnhlOHrRKj1PGL5sVH9SaXtWzsmYftW61LHVwvnNA7wui7tFGXqcFXutnYBMCItr GdL2Vo1Q7hX8hrKDrgkMAaZk/eo83KbXysC70mpN3P9EzjPp00OuZYiGpwRBnkB00cCL l6nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2UVd4Vpuu4Hnm6XlHGR5cRrZnqXWEFfAzghKkxqA5PE=; b=opivK6abG8NYeH1B6KWZbJD7OQ4REbVGOO+6kc0Loz93MMZzROyupvNzuoyHmga5Ho XXi0owFJXzgdUXNt/ZE1F+VeWoVf1LCiFGI/q0de/zADMmnTE3qat+zhUqdO1X+HNVIc 16FxsOD9Ev+6FoVg0q3NJAlSs3BV5NUcIeOnyCZRHzUQl8ziNU5D2KPOE/ew6L4XrbxK I40+XkgqxJV2+Q9/NPOrbQUIzQajFSXEah9bq5Y94j9S4geWtJC9kJyjAZoHAY/Ri9g5 2bJV0DAi8KRSeySrNjfkRrYlFZG22tfW/I59pwZGChWqCyB8AEZrh4VHTPF7VZilI/tJ KYIQ== X-Gm-Message-State: AOAM532og74/YAV/dV3t7L/cBwi0bmOSKRlyQEokds+YWi/eWzjoZnjO /NHWerrqnfNVlzHME1TL4DzL54jTOI9ZjC99SAiQAA== X-Google-Smtp-Source: ABdhPJwqdv1zjA72U6Y+yinTpL4jIF0WvT5OjmcvgBRWy2HcW+N17omaHs7u2Al3ueQuo5czHPS48NLDnn5YbwyPtt8= X-Received: by 2002:a63:a119:: with SMTP id b25mr22841048pgf.10.1593032243514; Wed, 24 Jun 2020 13:57:23 -0700 (PDT) MIME-Version: 1.0 References: <20200624203200.78870-1-samitolvanen@google.com> <20200624203200.78870-14-samitolvanen@google.com> In-Reply-To: <20200624203200.78870-14-samitolvanen@google.com> From: Nick Desaulniers Date: Wed, 24 Jun 2020 13:57:11 -0700 Message-ID: Subject: Re: [PATCH 13/22] scripts/mod: disable LTO for empty.c To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , clang-built-linux , Kernel Hardening , linux-arch , Linux ARM , Linux Kbuild mailing list , LKML , linux-pci@vger.kernel.org, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 24, 2020 at 1:33 PM Sami Tolvanen wrote: > > With CONFIG_LTO_CLANG, clang generates LLVM IR instead of ELF object > files. As empty.o is used for probing target properties, disable LTO > for it to produce an object file instead. > > Signed-off-by: Sami Tolvanen Reviewed-by: Nick Desaulniers > --- > scripts/mod/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/mod/Makefile b/scripts/mod/Makefile > index 296b6a3878b2..b6e3b40c6eeb 100644 > --- a/scripts/mod/Makefile > +++ b/scripts/mod/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > OBJECT_FILES_NON_STANDARD := y > +CFLAGS_REMOVE_empty.o += $(CC_FLAGS_LTO) > > hostprogs := modpost mk_elfconfig > always-y := $(hostprogs) empty.o > -- > 2.27.0.212.ge8ba1cc988-goog > -- Thanks, ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF6E2C433E1 for ; Wed, 24 Jun 2020 20:59:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D2C12081A for ; Wed, 24 Jun 2020 20:59:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ejWysHJu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="BPMaWjSi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D2C12081A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f8fZxQZgYPjexO13yvzjw0hhqk4DcpB8U5hVBFbjAzQ=; b=ejWysHJusIq6Hwb0JBliKVjeS E1Y3ssjWDaRTcL7fI0lkBFIwxwEilJdnEjaODrHWqx6/wLHyXcE/T1PQxxJB1Yg0MzuybVCyMTrhh YSpMIgjpCZueScpsHGHD2HLmaXlbUOpP3Xh3qLT3fsxRFPRlXAR0b5W2Z6N0g7g+mXHduaSKNS+mm rej6OHfcGhZY8ROphAjWNfN4CgtoZiQXXHafjMbBaNj0ERrwY5NIn+SHJm3ZIQd5JZMcpMc0feOwq VLV2z3z6BK+1IXr2ZojZwg6PrX2bqmUI4VdK5QyT25Fr736QL0CWVfRJqCDMxrDnQV1tyWZuDVw+V 4s9+zCjSQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joCSV-0001dN-Mc; Wed, 24 Jun 2020 20:57:27 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joCST-0001cM-JU for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 20:57:26 +0000 Received: by mail-pg1-x543.google.com with SMTP id u128so2014497pgu.13 for ; Wed, 24 Jun 2020 13:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2UVd4Vpuu4Hnm6XlHGR5cRrZnqXWEFfAzghKkxqA5PE=; b=BPMaWjSiHqVF8vi4hiTlzAVhVpOBnqRB11zTq0lEeedJqVV+du+PNZ4KmaMlIsirPC R928oKYPPNEK406mCXXrFo5ILeh9cKok03PTJz6JfAnRQKQCv1Rh1SMBWeCtT9nOL0oJ lryLagao4wnwA1qFmJ4sPzSNGD7lPYGa8eVmfocCRrLBf+dhWLYjqG85ZdT9LeohIlOb 2EmJnnhlOHrRKj1PGL5sVH9SaXtWzsmYftW61LHVwvnNA7wui7tFGXqcFXutnYBMCItr GdL2Vo1Q7hX8hrKDrgkMAaZk/eo83KbXysC70mpN3P9EzjPp00OuZYiGpwRBnkB00cCL l6nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2UVd4Vpuu4Hnm6XlHGR5cRrZnqXWEFfAzghKkxqA5PE=; b=ly2EH/4Jme7+A5p4nlRUlK8DPk9cJl7DM3J/h8mAFsvam7ZB79thVwCxnqYf73wG8Z RSBDKcdqH4wVPBuwXAHD/etpkqoFvsZBoO7FBmuY8VueUae8zeOANGyX4i/89zQDYQAm QiW6cK/tsjfg6YyJvCfHlaHkErS2OHoSrsPuXEzjR5PAzx3qROYICAesIsfsUqyWq1u3 iREYmlOapEzYFc8m488oBWOn3gEXR7ulKObOlUUyBNE/1vxc2ANVJQiUYkXqncZY11ow WRkUukLkpmRnjGpvaRCunuEKzI7fidyJKEOS5SR6dZ1UbvAzqKNALjBwOvjX0DfGiZii 4PpQ== X-Gm-Message-State: AOAM530mHX60pmNXH+AXdco2mhoxfxrXp3t7XGdKPDC1nJC0f6i7/uQK bXrcXpU4jPPOpLT93JB3ayTUro7TazKfhZ6mql1FsA== X-Google-Smtp-Source: ABdhPJwqdv1zjA72U6Y+yinTpL4jIF0WvT5OjmcvgBRWy2HcW+N17omaHs7u2Al3ueQuo5czHPS48NLDnn5YbwyPtt8= X-Received: by 2002:a63:a119:: with SMTP id b25mr22841048pgf.10.1593032243514; Wed, 24 Jun 2020 13:57:23 -0700 (PDT) MIME-Version: 1.0 References: <20200624203200.78870-1-samitolvanen@google.com> <20200624203200.78870-14-samitolvanen@google.com> In-Reply-To: <20200624203200.78870-14-samitolvanen@google.com> From: Nick Desaulniers Date: Wed, 24 Jun 2020 13:57:11 -0700 Message-ID: Subject: Re: [PATCH 13/22] scripts/mod: disable LTO for empty.c To: Sami Tolvanen X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Kees Cook , "Paul E. McKenney" , Kernel Hardening , Greg Kroah-Hartman , Masahiro Yamada , Linux Kbuild mailing list , LKML , clang-built-linux , linux-pci@vger.kernel.org, Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2020 at 1:33 PM Sami Tolvanen wrote: > > With CONFIG_LTO_CLANG, clang generates LLVM IR instead of ELF object > files. As empty.o is used for probing target properties, disable LTO > for it to produce an object file instead. > > Signed-off-by: Sami Tolvanen Reviewed-by: Nick Desaulniers > --- > scripts/mod/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/mod/Makefile b/scripts/mod/Makefile > index 296b6a3878b2..b6e3b40c6eeb 100644 > --- a/scripts/mod/Makefile > +++ b/scripts/mod/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > OBJECT_FILES_NON_STANDARD := y > +CFLAGS_REMOVE_empty.o += $(CC_FLAGS_LTO) > > hostprogs := modpost mk_elfconfig > always-y := $(hostprogs) empty.o > -- > 2.27.0.212.ge8ba1cc988-goog > -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D847C433E0 for ; Wed, 24 Jun 2020 20:57:42 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 897F72070A for ; Wed, 24 Jun 2020 20:57:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BPMaWjSi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 897F72070A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-19132-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 3939 invoked by uid 550); 24 Jun 2020 20:57:36 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 3907 invoked from network); 24 Jun 2020 20:57:35 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2UVd4Vpuu4Hnm6XlHGR5cRrZnqXWEFfAzghKkxqA5PE=; b=BPMaWjSiHqVF8vi4hiTlzAVhVpOBnqRB11zTq0lEeedJqVV+du+PNZ4KmaMlIsirPC R928oKYPPNEK406mCXXrFo5ILeh9cKok03PTJz6JfAnRQKQCv1Rh1SMBWeCtT9nOL0oJ lryLagao4wnwA1qFmJ4sPzSNGD7lPYGa8eVmfocCRrLBf+dhWLYjqG85ZdT9LeohIlOb 2EmJnnhlOHrRKj1PGL5sVH9SaXtWzsmYftW61LHVwvnNA7wui7tFGXqcFXutnYBMCItr GdL2Vo1Q7hX8hrKDrgkMAaZk/eo83KbXysC70mpN3P9EzjPp00OuZYiGpwRBnkB00cCL l6nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2UVd4Vpuu4Hnm6XlHGR5cRrZnqXWEFfAzghKkxqA5PE=; b=QIPnM7Ah5j83Hlw6Aot7R+i6QUcjzdChNOsxdwYM4TxuOwOQRlHdW/uuI41C1SMveu TNpV480NIHg0uKB30DbvoWUo3ccMBSRZt2T6De/egI7+YlVGYbhDbxeESCI0bnt7jSTM 9SMhElTSojncOnqlwqwqit0wvTErzAhUjAWO2qMTaUOuzfzki1jhElY9GaBCRD0MjmiZ k5JfVOmw11+oyrwb5Wps+pOKU5o1D/AKSp+Tq7CwBaADo1TEak5vFaC3s9fpUHupazTD BHmedoOcD8w0jiwHJrFT+qyKEYmYGOBw+Zwv2+LtedCJZa4cKQJEEtmPDzFBmdxDPKk7 8GgQ== X-Gm-Message-State: AOAM530m52fDauSWPnK0ETvxef9epPl7+UUWGY9AYH/4q5UY6GZanB+h G0tT1XaVb5y9RgvigMKhx/1erFCiWzxuFCl1jMG1/w== X-Google-Smtp-Source: ABdhPJwqdv1zjA72U6Y+yinTpL4jIF0WvT5OjmcvgBRWy2HcW+N17omaHs7u2Al3ueQuo5czHPS48NLDnn5YbwyPtt8= X-Received: by 2002:a63:a119:: with SMTP id b25mr22841048pgf.10.1593032243514; Wed, 24 Jun 2020 13:57:23 -0700 (PDT) MIME-Version: 1.0 References: <20200624203200.78870-1-samitolvanen@google.com> <20200624203200.78870-14-samitolvanen@google.com> In-Reply-To: <20200624203200.78870-14-samitolvanen@google.com> From: Nick Desaulniers Date: Wed, 24 Jun 2020 13:57:11 -0700 Message-ID: Subject: Re: [PATCH 13/22] scripts/mod: disable LTO for empty.c To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , clang-built-linux , Kernel Hardening , linux-arch , Linux ARM , Linux Kbuild mailing list , LKML , linux-pci@vger.kernel.org, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Content-Type: text/plain; charset="UTF-8" On Wed, Jun 24, 2020 at 1:33 PM Sami Tolvanen wrote: > > With CONFIG_LTO_CLANG, clang generates LLVM IR instead of ELF object > files. As empty.o is used for probing target properties, disable LTO > for it to produce an object file instead. > > Signed-off-by: Sami Tolvanen Reviewed-by: Nick Desaulniers > --- > scripts/mod/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/mod/Makefile b/scripts/mod/Makefile > index 296b6a3878b2..b6e3b40c6eeb 100644 > --- a/scripts/mod/Makefile > +++ b/scripts/mod/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > OBJECT_FILES_NON_STANDARD := y > +CFLAGS_REMOVE_empty.o += $(CC_FLAGS_LTO) > > hostprogs := modpost mk_elfconfig > always-y := $(hostprogs) empty.o > -- > 2.27.0.212.ge8ba1cc988-goog > -- Thanks, ~Nick Desaulniers