From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1833982983965649532==" MIME-Version: 1.0 From: Nick Desaulniers To: kbuild-all@lists.01.org Subject: Re: [PATCH V4 3/3] thermal: cpufreq_cooling: Reuse sched_cpu_util() for SMP platforms Date: Mon, 07 Dec 2020 11:59:51 -0800 Message-ID: In-Reply-To: <20201207094419.lakxblzsono3nqpf@vireshk-i7> List-Id: --===============1833982983965649532== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Dec 7, 2020 at 1:44 AM Viresh Kumar wro= te: > > On 03-12-20, 02:39, kernel test robot wrote: > > Hi Viresh, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on 3650b228f83adda7e5ee532e2b90429c03f7b9ec] > > > > url: https://github.com/0day-ci/linux/commits/Viresh-Kumar/cpufreq_c= ooling-Get-effective-CPU-utilization-from-scheduler/20201124-143027 > > base: 3650b228f83adda7e5ee532e2b90429c03f7b9ec > > config: powerpc64-randconfig-r025-20201202 (attached as .config) ^ Note: randconfig > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 26= 71fccf0381769276ca8246ec0499adcb9b0355) > > reproduce (this is a W=3D1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/s= bin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # install powerpc64 cross compiling tool for clang build > > # apt-get install binutils-powerpc64-linux-gnu > > # https://github.com/0day-ci/linux/commit/17f0c7f4372070206925c= 3a10ec0e7a09d03615e > > git remote add linux-review https://github.com/0day-ci/linux > > git fetch --no-tags linux-review Viresh-Kumar/cpufreq_cooling-G= et-effective-CPU-utilization-from-scheduler/20201124-143027 > > git checkout 17f0c7f4372070206925c3a10ec0e7a09d03615e > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross = ARCH=3Dpowerpc64 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All errors (new ones prefixed by >>): > > > > >> drivers/thermal/cpufreq_cooling.c:562:8: error: implicit declaration= of function 'allocate_idle_time' [-Werror,-Wimplicit-function-declaration] > > ret =3D allocate_idle_time(cpufreq_cdev); > > ^ I can see in the top commit (https://github.com/0day-ci/linux/commit/17f0c7f4372070206925c3a10ec0e7a09d= 03615e) you've modified __cpufreq_cooling_register to now call allocate_idle_time. -Wimplicit-function-declaration is observed when calling a function for which there has been no previous declaration. Let's look and see where or under what config allocate_idle_time is declared, and how a randconfig might expose the missing declaration. (The first thing I suspect is transitive header dependencies, where some intermediary header changes what it includes based on #define/CONFIGs, or calling a function before it's been declared). It looks like allocate_idle_time is declared in the same commit...while it's defined twice (once for CONFIG_SMP, once without), it's not defined when CONFIG_THERMAL_GOV_POWER_ALLOCATOR is not enabled, which is probably what the randconfig has tickled. > > >> drivers/thermal/cpufreq_cooling.c:624:2: error: implicit declaration= of function 'free_idle_time' [-Werror,-Wimplicit-function-declaration] > > free_idle_time(cpufreq_cdev); > > ^ > > drivers/thermal/cpufreq_cooling.c:717:2: error: implicit declaration= of function 'free_idle_time' [-Werror,-Wimplicit-function-declaration] > > free_idle_time(cpufreq_cdev); > > ^ > > 3 errors generated. > > > > vim +/allocate_idle_time +562 drivers/thermal/cpufreq_cooling.c > > I am not sure why this should happen here, I don't see any such errors > on my side. Can someone please have another look ? > > -- > viresh > > -- > You received this message because you are subscribed to the Google Groups= "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an= email to clang-built-linux+unsubscribe(a)googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgi= d/clang-built-linux/20201207094419.lakxblzsono3nqpf%40vireshk-i7. -- = Thanks, ~Nick Desaulniers --===============1833982983965649532==--