From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5FCCC7618F for ; Tue, 16 Jul 2019 20:24:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7CBE20659 for ; Tue, 16 Jul 2019 20:24:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AwPuELhu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388735AbfGPUYj (ORCPT ); Tue, 16 Jul 2019 16:24:39 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:37653 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728340AbfGPUYj (ORCPT ); Tue, 16 Jul 2019 16:24:39 -0400 Received: by mail-pl1-f196.google.com with SMTP id b3so10695900plr.4 for ; Tue, 16 Jul 2019 13:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tlgW7N5665To10UWUQBwQlj7I4LdVat1k1AQkv0K9Pc=; b=AwPuELhuts8lP4/v2w2PqvbmYvehX0wshVXA+4yqs560dvwt/VcjmUPDsGW9NmUrp3 Ixiiht508/rfZ52L3VVuAygzyGtjIICJLDo/q9EGqY5+9HtHqZK8FQchWZ0AdUauZxv2 SMtL9Erzsb1IXVbnepno+4OdCZ9pwZ4uBfZfq1C6PuMUPOYD/FbFhc/AujXk9HZf672E /vSWTLZUYPDq6jU7hGhgQDAIP8Aa2ptYeYU0T+XGHP9D10XbbGaol/wyeyMFrsq7aLg4 Sy2GQuXB6ZtcMXypQxGvFWFdiy5nBMoIrWyHy5z6WGyvAaD0czSqe2MKz7PtjhOCxzZs Trog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tlgW7N5665To10UWUQBwQlj7I4LdVat1k1AQkv0K9Pc=; b=r0z2f/BXnKLxi/T+Svrp7H3LlxP9FTPJ/iqp7GxT0WWxkB3GrBfCp2Hh1RSmUFbJFS bzbqTiULwpTOq/6ZzvGpTJM4UxZlI31TrzHBavarb7BLxjX7KjL7eOe5ljGU6qT4Vei9 CnScpqU/xrAMwnfeDEs1Pg9bdfkfvqSteTZ1xae/6hSNEuzFLmZ3tMe7nogA9p+7LbnR +Ij0oSOPAV2oF9v221EVdPIWF7K7TMtOVODbfpqoLVZbFeOUePTwx+dpK5KQrr1vDJU5 hXBky8DTPamCwfr65T39lswT/gBMFa4QqgSDa2a8gTDiwrxpHOk9P554zU0mw3dELLbI EYgw== X-Gm-Message-State: APjAAAUircrZKZwrpgxm2BhryKS0GqvxAGHQmgrIqueQcaQlxAWpWroY ucfRVKajUDZM4bnxbFma9elsyBxCOUrQV3dMIx9wHg== X-Google-Smtp-Source: APXvYqxRj/dcOXQ6bzNuxwwngYnNOIRCEWeTsQRemz7Vzu/PiFlwYrBKgqFvsM1vmPNOacFsGJ62gbjVvb1C0oLgRFU= X-Received: by 2002:a17:902:4aa3:: with SMTP id x32mr36572379pld.119.1563308678079; Tue, 16 Jul 2019 13:24:38 -0700 (PDT) MIME-Version: 1.0 References: <20190711172621.a7ab7jorolicid3z@treble> <20190712135755.7qa4wxw3bfmwn5rp@treble> <20190712142928.gmt6gibikdjmkppm@treble> In-Reply-To: From: Nick Desaulniers Date: Tue, 16 Jul 2019 13:24:26 -0700 Message-ID: Subject: Re: objtool crashes on clang output (drivers/hwmon/pmbus/adm1275.o) To: Josh Poimboeuf Cc: Jann Horn , Peter Zijlstra , Linux Kernel Mailing List , clang-built-linux , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 12, 2019 at 1:41 PM Arnd Bergmann wrote: > > On Fri, Jul 12, 2019 at 6:59 PM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > The issue still needs to get fixed in clang regardless. There are other > > > noreturn functions in the kernel and this problem could easily pop back > > > up. > > > > Sure, thanks for the report. Arnd, can you help us get a more minimal > > test case to understand the issue better? > > I reduced it to this testcase: > > int a, b; > void __reiserfs_panic(int, ...) __attribute__((noreturn)); > void balance_internal() { > if (a) > __reiserfs_panic(0, "", __func__, "", 2, __func__, a); > if (b) > __reiserfs_panic(0, "", __func__, "", 5, __func__, a, 0); > } > > https://godbolt.org/z/Byfvmx Is this the same issue as Josh pointed out? IIUC, Josh pointed to a jump destination that was past a `push %rbp`, and I don't see it in your link. (Or, did I miss it?) -- Thanks, ~Nick Desaulniers