From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF929C43381 for ; Thu, 7 Mar 2019 17:54:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D94820661 for ; Thu, 7 Mar 2019 17:54:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RqZS0H/i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726521AbfCGRyc (ORCPT ); Thu, 7 Mar 2019 12:54:32 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:46456 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbfCGRyb (ORCPT ); Thu, 7 Mar 2019 12:54:31 -0500 Received: by mail-pf1-f194.google.com with SMTP id g6so11995746pfh.13 for ; Thu, 07 Mar 2019 09:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i1E4iENPCWdT2C4QeTm1iBis4EFtMd3s1mWmYsVGpNM=; b=RqZS0H/ivQpTcktytXHy/lqkxba9ommM+Nnxrite6YkxaDM3uLGGMPG+09MpM/1npL 41OOo/OZBo3GEWIir3kfhgK0SAu3CAJCr1b21m/VMtmjpC72sk1aXwrNmK6PB3VsdXyw GNlr1xlheqOILs2VheSkMeiihTsOvhK5ic7dKnXgspQi5xSihz1oCBRBV0J9WA8vgQvR 05hRwP3Db3+7TI1rL5U9gii2F7zLGmAGjlBMllO9Obu4AXg9IipqMAGBijlfWCA5UTbr aGTffvZx79vp4EdOyNDRzd7+bxXaA8DKapVLoF3ERwMiBORlvp/ZRErOuiA9HXaEbMn8 P+Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i1E4iENPCWdT2C4QeTm1iBis4EFtMd3s1mWmYsVGpNM=; b=Hy2ZfEVvr9NKUyNbzYLE4lpdARRDbVLZjnUGmRhF/4qZt3OxfJ6HQJKEht4bqUdZH2 oPMQH7ZhVpiKhdIGvpCx1hq7NYdx6/mDmke1h1YEzG5hIj2O5foXUYWQAzWcaNjTAxrG IYz6p965RFVa/RtNTVqXlUq+3/8c1v4yKt1HL+8cWM0+Hd9jbqh1vP9B0rD8gs/GYDQ6 x40YQiydSmCVp7fzrrJqAasu3u3jpJjNO0UQwQYxNZzLgNmHJa7ZWVbrQerWtI1JqaTB 7YB4kBgIp7IO3E0o52Pw8wgKmcy8GhotP8ppF+Z3dUuupxB/ZatwLtod1cz2ERvw9Q+N 0NtA== X-Gm-Message-State: APjAAAUnBN0OqQHigP/gH+0v+P8MdbGF63QI9PCRdxxjkMPru59XGKdl JrS6yOXGQNff3VNYNZF63chTl3B4X3y2DFcJEmjxsw== X-Google-Smtp-Source: APXvYqy4peGbU17UbH85NO5uI5I0DgZxsk+9kg3qi1cY9tvmP/cg1wmafOMz1RPUGXShLD2znZjXEMflpYwqDL//8L4= X-Received: by 2002:a63:40c1:: with SMTP id n184mr11935550pga.225.1551981270756; Thu, 07 Mar 2019 09:54:30 -0800 (PST) MIME-Version: 1.0 References: <20190307162101.29204-1-natechancellor@gmail.com> <20190307.094952.931716686086981512.davem@davemloft.net> In-Reply-To: <20190307.094952.931716686086981512.davem@davemloft.net> From: Nick Desaulniers Date: Thu, 7 Mar 2019 09:54:19 -0800 Message-ID: Subject: Re: [PATCH] net: stmmac: Avoid sometimes uninitialized Clang warnings To: Nathan Chancellor Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Linux ARM , LKML , clang-built-linux@googlegroups.com, David Miller Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 7, 2019 at 9:49 AM David Miller wrote: > > From: Nathan Chancellor > Date: Thu, 7 Mar 2019 09:21:01 -0700 > > > @@ -565,7 +565,7 @@ static int stmmac_hwtstamp_set(struct net_device *dev, struct ifreq *ifr) > > u32 ts_master_en = 0; > > u32 ts_event_en = 0; > > u32 value = 0; > > - u32 sec_inc; > > + u32 sec_inc = 0; > > bool xmac; > > Please don't break the reverse christmas tree ordering here, thank you. Every codebase has its own unique code style. *wonders how clang-format could or could not handle that rule* Thanks for sending the patch Nathan; if you could resend with the declaration order changed so that the line width decreases going down in the order, you can add my Reviewed-by tag. -- Thanks, ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304CFC43381 for ; Thu, 7 Mar 2019 17:54:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0368820661 for ; Thu, 7 Mar 2019 17:54:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QAqK5PoN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="RqZS0H/i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0368820661 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hoaDvtjH7zhE8841hZSTBmZQuh/SPnjO1VJIQbt7ibA=; b=QAqK5PoN3VLvGH eQqAgVPYQUOVyx+NRXOjb0HKUPvUCYJwJzbIYGu8lUM5hkhhMzUep4J0AnsDh0aoWhuaIBPxRtkNp 5LXIZDgs4rFxfxSCWHqXPPuVA71OApbBHajTOJ8970oPi/DHlKSZfoYWm4vXVVCosc3WB07UfFl2l MjeMbY0fZEO2QagO6ryCFCq3kmAj4yiR2Qv8cs9PH0Inl2MnsEIJFQFgto5I8ljuKG/CdRiMMcv4K YK4rPjLvgXe1Kk+1pJXUIgBFlknl9iLQiWeIUFYZ23eppwkN/xFSWxREZvoDloJ2mM5Z0mGTBWxH0 QjnOpixENff8tUCmkarQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1xE8-0000AY-GW; Thu, 07 Mar 2019 17:54:40 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1xE5-00009F-PS for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2019 17:54:39 +0000 Received: by mail-pf1-x443.google.com with SMTP id u9so12008078pfn.1 for ; Thu, 07 Mar 2019 09:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i1E4iENPCWdT2C4QeTm1iBis4EFtMd3s1mWmYsVGpNM=; b=RqZS0H/ivQpTcktytXHy/lqkxba9ommM+Nnxrite6YkxaDM3uLGGMPG+09MpM/1npL 41OOo/OZBo3GEWIir3kfhgK0SAu3CAJCr1b21m/VMtmjpC72sk1aXwrNmK6PB3VsdXyw GNlr1xlheqOILs2VheSkMeiihTsOvhK5ic7dKnXgspQi5xSihz1oCBRBV0J9WA8vgQvR 05hRwP3Db3+7TI1rL5U9gii2F7zLGmAGjlBMllO9Obu4AXg9IipqMAGBijlfWCA5UTbr aGTffvZx79vp4EdOyNDRzd7+bxXaA8DKapVLoF3ERwMiBORlvp/ZRErOuiA9HXaEbMn8 P+Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i1E4iENPCWdT2C4QeTm1iBis4EFtMd3s1mWmYsVGpNM=; b=Ymft2jugkwsAge/LvOTafxVr18dDpXLkI4GYnPsih3+UwMnPrfMU44aBu+F32WMq68 tZ54EUwg/YDNje31X4coZTKk8QPo0yWznBG/ukKCe1APfO4Mut2ylgnrvmFCR1sK6xs+ gwxGQoHjmu8t3NVrtQhlv3GIhhqV2LyNSBXVsjwW7rlaRqpjPsm1q6ttvmjcyirV1Qd0 fVocar5ZwwbG08f1LEsWnGpZzKDuY7AkIqcwGu72MX+QJvWPP9CFutBjmcpVJIMEUtAr hToKXk/Cs91s7dBRXjgkVibqpBmzEjfxrugh4JBREDM385OktmUMhRbkHIv7iG0EK5kp kwHQ== X-Gm-Message-State: APjAAAU/QDBbu6LZEHiVsL7yjPdkElj3VVwCuos8/4b7vKzH31NngFEq Q/hNU7rEa3pEIkV0tNTrbkl2GXqp7byW8d79j1GbCA== X-Google-Smtp-Source: APXvYqy4peGbU17UbH85NO5uI5I0DgZxsk+9kg3qi1cY9tvmP/cg1wmafOMz1RPUGXShLD2znZjXEMflpYwqDL//8L4= X-Received: by 2002:a63:40c1:: with SMTP id n184mr11935550pga.225.1551981270756; Thu, 07 Mar 2019 09:54:30 -0800 (PST) MIME-Version: 1.0 References: <20190307162101.29204-1-natechancellor@gmail.com> <20190307.094952.931716686086981512.davem@davemloft.net> In-Reply-To: <20190307.094952.931716686086981512.davem@davemloft.net> From: Nick Desaulniers Date: Thu, 7 Mar 2019 09:54:19 -0800 Message-ID: Subject: Re: [PATCH] net: stmmac: Avoid sometimes uninitialized Clang warnings To: Nathan Chancellor X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190307_095437_843810_7FC07F03 X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, netdev@vger.kernel.org, LKML , David Miller , clang-built-linux@googlegroups.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, peppe.cavallaro@st.com, linux-stm32@st-md-mailman.stormreply.com, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 7, 2019 at 9:49 AM David Miller wrote: > > From: Nathan Chancellor > Date: Thu, 7 Mar 2019 09:21:01 -0700 > > > @@ -565,7 +565,7 @@ static int stmmac_hwtstamp_set(struct net_device *dev, struct ifreq *ifr) > > u32 ts_master_en = 0; > > u32 ts_event_en = 0; > > u32 value = 0; > > - u32 sec_inc; > > + u32 sec_inc = 0; > > bool xmac; > > Please don't break the reverse christmas tree ordering here, thank you. Every codebase has its own unique code style. *wonders how clang-format could or could not handle that rule* Thanks for sending the patch Nathan; if you could resend with the declaration order changed so that the line width decreases going down in the order, you can add my Reviewed-by tag. -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel