From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A51BCC433FE for ; Mon, 3 Oct 2022 16:53:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbiJCQx3 (ORCPT ); Mon, 3 Oct 2022 12:53:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbiJCQxZ (ORCPT ); Mon, 3 Oct 2022 12:53:25 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D472827CF7 for ; Mon, 3 Oct 2022 09:53:24 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id l1-20020a17090a72c100b0020a6949a66aso5907331pjk.1 for ; Mon, 03 Oct 2022 09:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=gZKEiTUAFXZosZUTE0DVKhThrNQqN4l1F7V4i7rzUeA=; b=o5TDDhqMiYi/K0MtXNmkiwycZaDqOD2l4xsqFKTZanBx3k7SfgyRxpOmwpQLPryXUR grgkZ965pst0bXVyKwjzLY6f1YNCTxW5dTPw6mUwtchyeDVsQKwBfbCFkp+9A5gpBItI TrEUYPTTCXC9mxifIr6UZYI54irowJVOAH7uBOY2VlU9XTcRhYz2hUcyP6/lrqTxJ1qn 1zc72wS2UM2jB+rSuTFQa5iZyaivDbqQdf0HMW3gAJ3rvTC3K7zCFPl3lqW5TV/LxOlv M1X28qtr/TMe1GLR6HjEpctvfSpr/4Fe5KDbrCWlhDqc6YNBzJByZK10JnMCs09kXeba MzNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=gZKEiTUAFXZosZUTE0DVKhThrNQqN4l1F7V4i7rzUeA=; b=2g2HMhzoHdGFSZJSapqM49rlFAIiI2p0KmMnw6xwEpcq7N/W52pLcyNwDmMYs5NY95 BpD+A2pSp2MZ6gY5A90JeDcKX1fwIbDGe4Cu662Cw3ZkbjV/UCDkhKXERD1UJ9TS2JLg xlAL/lCT9vHqnRbk6XMDnxP/nCAUkt18tJaGRNO4QgJMBIzUmNVP3okGMwXAqJiEsIWN QELouH95v2ZfuUjUfdIw2CPyndFLQ2JnSuB1BkxSdyaWVjANeb/RkLGgF8/zIjhJj1Oj 4nRkbxXIy5moghGzuhHLyrGZ5o45RFbiqEssFuw33s74bmYAy9Mm41Dw5Co/l3CsDjp4 +SSw== X-Gm-Message-State: ACrzQf0WGtzXujfldDFDntDHBaJ8wTDKKKW7mwnOt1JfiiuJR7eVT/0Z HHt3AF3bOlCmsu/oG0YaTOCr7vUgjvEP8cEW7RiC5w3nZEy7EA== X-Google-Smtp-Source: AMsMyM5CDeD+wdruJsiYbQMn/0gNAkrS8VhVLsm7oItP4SziHtS/RVb3RiWdudu02VlWFT9tltTDxgN399CLC9OkTno= X-Received: by 2002:a17:90b:3a88:b0:209:f35d:ad53 with SMTP id om8-20020a17090b3a8800b00209f35dad53mr13175321pjb.102.1664816004128; Mon, 03 Oct 2022 09:53:24 -0700 (PDT) MIME-Version: 1.0 References: <20221002181107.51286-1-masahiroy@kernel.org> <20221002181107.51286-2-masahiroy@kernel.org> In-Reply-To: <20221002181107.51286-2-masahiroy@kernel.org> From: Nick Desaulniers Date: Mon, 3 Oct 2022 09:53:13 -0700 Message-ID: Subject: Re: [PATCH 1/3] Kconfig.debug: simplify the dependency of DEBUG_INFO_DWARF4/5 To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 2, 2022 at 11:11 AM Masahiro Yamada wrote: > > Commit c0a5c81ca9be ("Kconfig.debug: drop GCC 5+ version check for > DWARF5") could have cleaned up the code a bit deeper. > > "CC_IS_CLANG &&" is unneeded. No functional change is intended. This implies that there are only 2 compilers capable of building the kernel; consider also removing include/linux/compiler-intel.h if ICC is no longer supported. Otherwise, what implications does this patch have for ICC? > > Signed-off-by: Masahiro Yamada > --- > > lib/Kconfig.debug | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index d3e5f36bb01e..f4b2165f24db 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -264,7 +264,7 @@ config DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT > config DEBUG_INFO_DWARF4 > bool "Generate DWARF Version 4 debuginfo" > select DEBUG_INFO > - depends on !CC_IS_CLANG || (CC_IS_CLANG && (AS_IS_LLVM || (AS_IS_GNU && AS_VERSION >= 23502))) > + depends on !CC_IS_CLANG || AS_IS_LLVM || (AS_IS_GNU && AS_VERSION >= 23502) > help > Generate DWARF v4 debug info. This requires gcc 4.5+, binutils 2.35.2 > if using clang without clang's integrated assembler, and gdb 7.0+. > @@ -276,7 +276,7 @@ config DEBUG_INFO_DWARF4 > config DEBUG_INFO_DWARF5 > bool "Generate DWARF Version 5 debuginfo" > select DEBUG_INFO > - depends on !CC_IS_CLANG || (CC_IS_CLANG && (AS_IS_LLVM || (AS_IS_GNU && AS_VERSION >= 23502))) > + depends on !CC_IS_CLANG || AS_IS_LLVM || (AS_IS_GNU && AS_VERSION >= 23502) > help > Generate DWARF v5 debug info. Requires binutils 2.35.2, gcc 5.0+ (gcc > 5.0+ accepts the -gdwarf-5 flag but only had partial support for some > -- > 2.34.1 > -- Thanks, ~Nick Desaulniers