From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 695BE4686 for ; Mon, 26 Sep 2022 18:17:12 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id s14-20020a17090a6e4e00b0020057c70943so13302495pjm.1 for ; Mon, 26 Sep 2022 11:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Il0vkOLUU8Wr/hKXeWfSAnVT8noJuQa95krgaKi1p4s=; b=ndO8+/R02S9Z+MftcCPkoi50pEbp5cagm+Obh6sygHFMVdgUXeF5PNyfPJt6YEvCYt 7RdkC9KxTEQ1Fv/6bZMFZkGIr9/TUJh/Dn0IquOtJBsG2IK16fFoMTYGcZh2H8d8P2Lv E0BL7I628eb7+l3xct+uiGuiEncpwJ/CGtXsOiVIS4zoIaaY54OEdOK3WFHmS14qRzp2 0Ty0K9rYGGS0QkRH54SSZ8pTvZ8nhEavH4e/sfuRnTYiClyswgBgufRD61NvhQumJNje eV1nrk8nwKijMExrhQbqdT0tI2hk4ZcnTxN4TKSFoN6qylvUs4R0SxSojqwRZok22yWi sWRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Il0vkOLUU8Wr/hKXeWfSAnVT8noJuQa95krgaKi1p4s=; b=w0gkmx/iGMDTSpuBJY3L/Z0A6u3itBtvKx8MrCu9v+aZ1QWjiFRzLsejuBxWqt4cP7 RMfTdpbjJtGKb2ybVyOcq1Ro3Cw4IV/yMOeZb3UbJ6HgcO88JrjsKfTOxScGKv0MVGXb uW42bP9ekme86y1Lu+XU0Z15CKTHWSAUCr6YTAe5Fs6hzeMQEZBmGWucLFioe4qB9yDA S8wF1SqBkF+awxBoLWw4WwL0Lx2r9IZDKo5Nbgw9JzG3LN/VJO3zd2rkm/pR/REmln4L jExzRB6zYu5F3LMInzM3WxmfdsAACPYAhCfiLaN42As2JcV6mqj8ndiU9kQICfSphPDf sa6Q== X-Gm-Message-State: ACrzQf3Ad/GPAEPF0DWLmYDXnXCcVtdj0BmvBnkSupw/4KhD0jhwHbla yrURbnIeuKlP47lbR1pGFWErXc7mbUvNQhnsNCshYA== X-Google-Smtp-Source: AMsMyM7HLUfbdMpdW3guEO/IoUjYq2oQz+OyMDkq7nLclHX/EA7jhIcMm5L/Nfwp+rvUkCew0JIURYshd4k1BklGYCE= X-Received: by 2002:a17:90b:1d0f:b0:202:be3e:a14a with SMTP id on15-20020a17090b1d0f00b00202be3ea14amr49839pjb.102.1664216231609; Mon, 26 Sep 2022 11:17:11 -0700 (PDT) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Nick Desaulniers Date: Mon, 26 Sep 2022 11:17:00 -0700 Message-ID: Subject: Re: arch/arm/probes/kprobes/core.c:409:30: error: .fnstart must precede .save or .vsave directives To: "Russell King (Oracle)" Cc: Nathan Chancellor , Naresh Kamboju , open list , Linux ARM , Arnd Bergmann , Masami Hiramatsu , regressions@lists.linux.dev, lkft-triage@lists.linaro.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Mon, Sep 26, 2022 at 11:02 AM Russell King (Oracle) wrote: > > On Mon, Sep 26, 2022 at 10:42:45AM -0700, Nick Desaulniers wrote: > > > On Mon, Sep 26, 2022 at 08:44:05AM -0700, Nathan Chancellor wrote: > > > > Thank you for the testing and report! I brought this up on GitHub on > > > > Friday as I noticed this as well: > > > > > > > > https://github.com/ClangBuiltLinux/linux/issues/1718 > > > > Thanks for the reports. I'll take a look at filing additional bug > > reports against clang, then moving the definition of > > __kretprobe_trampoline to out of line assembler. > > Are you saying that .save should be accepted without a .fnstart? No. It's just a bug in clang's inline assembler. But it does make sense to just move it to out of line assembler anyways; having it be inline provides little to no benefit. Should I be using UNWIND from arch/arm/include/asm/unwind.h on these .fnstart/.save/.pad/.fnend directives? -- Thanks, ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE6AFC07E9D for ; Mon, 26 Sep 2022 18:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vY96LFVmfPK24OkqInrTjkhRnZaDnTLweg6qcNc8Qjc=; b=QDmSb8ZQn2sgm4 AylXfFl/LCKVo+0qQyV8V+LXNk4rEe4nyo3VSFBI2g5txlrKU5OiicKWJfOX2KPO3ZdIUxppHKVxq poRx+LdqbrF4NXxXi4m48fLMNTttGSSio8lqPnDFOGeWa5l8cTVzgIBS79ZfASBQevcwZ/DWm22vF jj9UBFI4UrSA+aG494lhvFAyfjph3gyXy9a5jeiurSvC/GHfgHrptbRyuYMbX+a6SAecsE2QQjDFT 7CiKhlIK30xChHO4NW+TY9RlAcWw1nShsmc7qnVBK/+BDY33ZmBMczZAod0LARUia9SbO/1LDmk6Q RqquFeWML7KUzDnZ7CEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocsfQ-006FBg-Sv; Mon, 26 Sep 2022 18:17:21 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocsfN-006FB0-4L for linux-arm-kernel@lists.infradead.org; Mon, 26 Sep 2022 18:17:18 +0000 Received: by mail-pj1-x1029.google.com with SMTP id d64-20020a17090a6f4600b00202ce056566so13278628pjk.4 for ; Mon, 26 Sep 2022 11:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Il0vkOLUU8Wr/hKXeWfSAnVT8noJuQa95krgaKi1p4s=; b=ndO8+/R02S9Z+MftcCPkoi50pEbp5cagm+Obh6sygHFMVdgUXeF5PNyfPJt6YEvCYt 7RdkC9KxTEQ1Fv/6bZMFZkGIr9/TUJh/Dn0IquOtJBsG2IK16fFoMTYGcZh2H8d8P2Lv E0BL7I628eb7+l3xct+uiGuiEncpwJ/CGtXsOiVIS4zoIaaY54OEdOK3WFHmS14qRzp2 0Ty0K9rYGGS0QkRH54SSZ8pTvZ8nhEavH4e/sfuRnTYiClyswgBgufRD61NvhQumJNje eV1nrk8nwKijMExrhQbqdT0tI2hk4ZcnTxN4TKSFoN6qylvUs4R0SxSojqwRZok22yWi sWRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Il0vkOLUU8Wr/hKXeWfSAnVT8noJuQa95krgaKi1p4s=; b=jFQehtY0uHhAd5YE9JF/5WAv1hX6uzrHYMbZQUx/UM3POf5vYeBH8/L6quRqc1WRs/ 2El5BMsLvVeL9FLOKZ/0sqle786t6apP1WSIitx4fvubXojDE2fj5RSlVI1cYuegTCAD 398ZJJihicYKAK8wCt7qQkkjMQbJ1W6/YDFaYn4eS9a+xE+RE3zriuk7Xf/6gPegl78r JfOLhKwUwYyWaRn+NMvxcC9+3RWaluA6t5kFHPWo8foNhaaHaDrw6yUXlIYNcxm9tgTT dH6IwXaRlfUp8+HctB0Xq0oA77b4d+vB1LYQxwTdR9Yrfjb9aIlzMXBqyFyoVolt/lpp zL2A== X-Gm-Message-State: ACrzQf3x0d6kwkTuqzijcs9C4P7jL/wxgmfCFwN6qlcxSNqqEEAJVIHm dbH9ypqtRuOqmWe0s8AVXrgNMsdAMDUK70zSIwLLmQ== X-Google-Smtp-Source: AMsMyM7HLUfbdMpdW3guEO/IoUjYq2oQz+OyMDkq7nLclHX/EA7jhIcMm5L/Nfwp+rvUkCew0JIURYshd4k1BklGYCE= X-Received: by 2002:a17:90b:1d0f:b0:202:be3e:a14a with SMTP id on15-20020a17090b1d0f00b00202be3ea14amr49839pjb.102.1664216231609; Mon, 26 Sep 2022 11:17:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nick Desaulniers Date: Mon, 26 Sep 2022 11:17:00 -0700 Message-ID: Subject: Re: arch/arm/probes/kprobes/core.c:409:30: error: .fnstart must precede .save or .vsave directives To: "Russell King (Oracle)" Cc: Nathan Chancellor , Naresh Kamboju , open list , Linux ARM , Arnd Bergmann , Masami Hiramatsu , regressions@lists.linux.dev, lkft-triage@lists.linaro.org, llvm@lists.linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220926_111717_192945_777AFCE8 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 26, 2022 at 11:02 AM Russell King (Oracle) wrote: > > On Mon, Sep 26, 2022 at 10:42:45AM -0700, Nick Desaulniers wrote: > > > On Mon, Sep 26, 2022 at 08:44:05AM -0700, Nathan Chancellor wrote: > > > > Thank you for the testing and report! I brought this up on GitHub on > > > > Friday as I noticed this as well: > > > > > > > > https://github.com/ClangBuiltLinux/linux/issues/1718 > > > > Thanks for the reports. I'll take a look at filing additional bug > > reports against clang, then moving the definition of > > __kretprobe_trampoline to out of line assembler. > > Are you saying that .save should be accepted without a .fnstart? No. It's just a bug in clang's inline assembler. But it does make sense to just move it to out of line assembler anyways; having it be inline provides little to no benefit. Should I be using UNWIND from arch/arm/include/asm/unwind.h on these .fnstart/.save/.pad/.fnend directives? -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel