From: Nick Desaulniers <ndesaulniers@google.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Peter Oberparleiter <oberpar@linux.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Johannes Berg <johannes.berg@intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Kees Cook <keescook@chromium.org>, Marco Elver <elver@google.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] gcov,x86: Mark GCOV broken for x86
Date: Mon, 14 Jun 2021 12:03:15 -0700 [thread overview]
Message-ID: <CAKwvOdkV8DLKJb7h_=6mUb_V=qdmBaCqNMU8scaBhpqF7yeeMQ@mail.gmail.com> (raw)
In-Reply-To: <YMeeBJKJhddzReGe@zn.tnic>
On Mon, Jun 14, 2021 at 11:21 AM Borislav Petkov <bp@alien8.de> wrote:
>
> On Mon, Jun 14, 2021 at 11:05:35AM -0700, Nick Desaulniers wrote:
> > __attribute__((no_instrument_function)) is already wired to not emit
> > calls to mcount()/fentry(). I think extending it to also apply to
> > coverage (-fprofile-arcs) and instrumentation based profiling
> > (-fprofile-generate) is reasonable.
>
> Is anyone going to ping the gcc folks so that they do it too or should
> we open a bug over there simply?
Yes, I will file a bug (or two) against GCC and then post the links on
the other thread (re: pgo) since that already has the toolchains
mailing list cc'ed.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2021-06-14 19:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 10:17 [PATCH] gcov,x86: Mark GCOV broken for x86 Peter Zijlstra
2021-06-14 10:31 ` Marco Elver
2021-06-14 14:43 ` Peter Oberparleiter
2021-06-18 11:13 ` Peter Zijlstra
2021-06-21 13:53 ` Peter Oberparleiter
2021-06-14 16:05 ` Nick Desaulniers
2021-06-14 16:20 ` Peter Zijlstra
2021-06-14 18:05 ` Nick Desaulniers
2021-06-14 18:20 ` Borislav Petkov
2021-06-14 19:03 ` Nick Desaulniers [this message]
2021-06-14 19:28 ` Borislav Petkov
2021-06-14 18:31 ` Fangrui Song
2021-06-14 19:07 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdkV8DLKJb7h_=6mUb_V=qdmBaCqNMU8scaBhpqF7yeeMQ@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=bp@alien8.de \
--cc=elver@google.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nathan@kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.