From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95DF3C433F5 for ; Mon, 25 Apr 2022 18:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244231AbiDYSWP (ORCPT ); Mon, 25 Apr 2022 14:22:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238098AbiDYSWO (ORCPT ); Mon, 25 Apr 2022 14:22:14 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 366FE3B285 for ; Mon, 25 Apr 2022 11:19:08 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id y32so27696579lfa.6 for ; Mon, 25 Apr 2022 11:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XWjyOTk2tGd4SQizwMeiUoN3Sq9yf6dGtgMTU28R/fY=; b=a6NU1EkhZkIg5psdckl12MWVLCiPzHkalwosSurPX+10R3BE0fypNlCtJNK5S9Fm33 2YEBEEi/UVhjabcO80zk2m6oTTAPL81az32tapOcMzG6J4ZlxrymUqBd4GfVxeyw/A89 sUCvynHn5KtU6pQJnPWYUPBm3E6c0NPhN3bvgcM1IM3aePtqlWuejGE3+hgWGe8DRBe8 0r+WXQ6IP9CXTs3YirPawMoZtchf9K6PSVl4/lRm0wzOJeFm0s+arS5klDkoGekVaja8 KG4uDg1BebEPxb+JyNRmkofOgdTFfPXEqg1X4MYfyXJ3lNrbTxa73xI8/nIT30F8YeJw 3y3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XWjyOTk2tGd4SQizwMeiUoN3Sq9yf6dGtgMTU28R/fY=; b=M6mhRLTV4ky4ICQdWQaJ7S0jzvlEgwXE4Tr00kiJmHd3SZdreZli66In7rwxoOr0qE qzgz8z+RE052Tppsgaa2cXUKZxQpiOV6gIudtpSvVZL7vZMWXfqywvye2U9wPIoPDTk1 lmhkDCbJ8uTyGMhENBBwCYNYRGCpIlF5bNp/sdrUHhSItsh7q8bukxFZ2HF5sNtCtDlJ BFhyfwwgFIqfbTm95lzPPsYjaSD2tvgTBZ0T9tZmNShWVQyCzF1+jh26FuDggKoxKnv2 C3GlaOkt1rSqzexV4Z6bsseCYQpq3eYw11xH9rzPsNpJUhNT7VLlFuFtQxoav1NrJQ2z rQnQ== X-Gm-Message-State: AOAM532h9VaZUVTEZ7/NDIKLDKAHKaSiiD/Pv5thvKZsWwOf2c1vl0Qr GuVu0QoZ2dk0EPyvfhqAfHfgpin6aFwLjWGqR86vQw== X-Google-Smtp-Source: ABdhPJxr648XHmFtOsQbv/5l+cltqwh0ON3p+8hRlhV3L+DYFg9FO6UTQTq49XCNNQmDYsjURyqaNrLntwLPrDMxrKk= X-Received: by 2002:ac2:4188:0:b0:471:96f4:c1d4 with SMTP id z8-20020ac24188000000b0047196f4c1d4mr13990835lfh.626.1650910746293; Mon, 25 Apr 2022 11:19:06 -0700 (PDT) MIME-Version: 1.0 References: <20220424190811.1678416-1-masahiroy@kernel.org> <20220424190811.1678416-4-masahiroy@kernel.org> In-Reply-To: <20220424190811.1678416-4-masahiroy@kernel.org> From: Nick Desaulniers Date: Mon, 25 Apr 2022 11:18:54 -0700 Message-ID: Subject: Re: [PATCH 03/27] modpost: remove stale comment about sym_add_exported() To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Marek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 24, 2022 at 12:09 PM Masahiro Yamada wrote: > > The description, > > it may have already been added without a > CRC, in this case just update the CRC > > ... is no longer valid. > > In very old days, this function was used to update the CRC as well. > > Commit 040fcc819a2e ("kbuild: improved modversioning support for > external modules") started to use a separate function (sym_update_crc) > for updating the CRC. > > The first part, "Add an exported symbol" is correct, but it is too > obvious from the function name. Drop this comment entirely. Thanks for the patch! Reviewed-by: Nick Desaulniers > > Signed-off-by: Masahiro Yamada > --- > > scripts/mod/modpost.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index f0d48f65fb33..c7cfeeb088f7 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -387,10 +387,6 @@ static void sym_update_namespace(const char *symname, const char *namespace) > s->namespace = namespace[0] ? NOFAIL(strdup(namespace)) : NULL; > } > > -/** > - * Add an exported symbol - it may have already been added without a > - * CRC, in this case just update the CRC > - **/ > static struct symbol *sym_add_exported(const char *name, struct module *mod, > enum export export) > { > -- > 2.32.0 > -- Thanks, ~Nick Desaulniers