From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_MED,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F38A9C04AB6 for ; Fri, 31 May 2019 20:06:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8C0B26EAA for ; Fri, 31 May 2019 20:06:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kV49vqq8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727473AbfEaUG0 (ORCPT ); Fri, 31 May 2019 16:06:26 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42362 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727316AbfEaUG0 (ORCPT ); Fri, 31 May 2019 16:06:26 -0400 Received: by mail-pf1-f196.google.com with SMTP id r22so6820896pfh.9 for ; Fri, 31 May 2019 13:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9TL9DcOEKgadixiKIuv445aeR9WBFQdFXZrUAgDcDlE=; b=kV49vqq86GuJyq1B2ExOHqAEHCBbLYAxLrlwX9YHW790oTpaKgrElCoYJHUXWkgOJV TyS26P7yQV73R8/GWkjjhukLJb66Q7zUUUJ7a2B93/pJZO6Shv5cFVuO06NhX0qS4a8f ckE9aHhSd9lIxLohPE/+lCMBZ2E8LEVATqVLm7wOqPKHieY8trNRGEwdnTfcrdqsN1Fz yu0mhBAzkmIxIgd+iih/pD0/QURI9+rxP04X2IHVXV+35kUITHS70Eb+sKRt40HBMm7w s6s3jP7zdEP+vz/WybVa2KYlVXm/9BI/SzyLBAfs7+4YVEhu/Sm8BI/uV6UgsPEc/XKh zXXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9TL9DcOEKgadixiKIuv445aeR9WBFQdFXZrUAgDcDlE=; b=a+FkKSYEKntZT0lwjABmXi5ZRPu/phRMy5Wfb380xirVtiGdB908pUVjALcCw5SauF THEPXTog8e/Hj23+Ivi6RWS3DtKdFEosokkxn5c1oVoY8rhN9W46AggmH9KAYv/hthBM eOU62l3uUyLjZn/PYh1dAEI4QluKqJNKQg3nf8Yk2+EETtVetMneRMHJGl2E8CQsS2fb oRpXLjfbai/IJWubMJCQKLtL4iQNBdzfB+PjM9FBYR+G4dQHyvyhqoS6FOFO36nPsgEC ruOD4qHK52lgyo9egVcHDY4Plp2mUIgDM5hs/s+OFR71cWjbJcxws7PmVidN+wh3ZIf4 8jWA== X-Gm-Message-State: APjAAAWYO+5t/NnFvK4mAtyGhssdjfa8q+Z/Ib/nQDLGwK6trrcJXxeN 3/59ltfX/LrOAkRxpx729NF+loqHDT54KE0Vu2VzCA== X-Google-Smtp-Source: APXvYqyEK1gsqxDA0Or/CK+vKBpJnggOs9awLB6ySElXj4BB/3+n9Gqj3w6GYh+I5qrhLxZWF88p5xir5ByMCP3e/lU= X-Received: by 2002:a17:90a:ac11:: with SMTP id o17mr3043266pjq.134.1559333185173; Fri, 31 May 2019 13:06:25 -0700 (PDT) MIME-Version: 1.0 References: <20190528235742.105510-1-natechancellor@gmail.com> <20190531183227.GA34102@archlinux-epyc> In-Reply-To: From: Nick Desaulniers Date: Fri, 31 May 2019 13:06:13 -0700 Message-ID: Subject: Re: [PATCH] ARM: xor-neon: Replace __GNUC__ checks with CONFIG_CC_IS_GCC To: Arnd Bergmann Cc: Nathan Chancellor , Russell King , Nicolas Pitre , Stefan Agner , Linux ARM , Linux Kernel Mailing List , Ard Biesheuvel , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 31, 2019 at 12:21 PM Arnd Bergmann wrote: > clang, I would suggest dropping your patch then, and instead adding I disagree. The minimum version of gcc required to build the kernel is 4.6, so the comment about older versions of gcc is irrelevant and should be removed. Nathan's -Rpass warnings are warning that vectorization was not calculated to be profitable **for 1 of the 4 functions** by LLVM. Surely we wouldn't disable NEON opts for XOR because 1 of 4 was not vectorized? -- Thanks, ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C84DCC04AB6 for ; Fri, 31 May 2019 20:06:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98A3226EAA for ; Fri, 31 May 2019 20:06:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qayX8LzO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="kV49vqq8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98A3226EAA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bY7bwmNj96PhGM4eCqkdQlNtSRY5+0aM16AoaJK8YhU=; b=qayX8LzOxmH3RK /rhe6iVgzwQ5d++b+lWG4ej1zkcmTewW8GObM8n85O6n8PKIE9emBrhBUrULPGFXab+EvtaHaZye7 M8CG6rG6C3eWt0B4sbT/rkHvml+UzLdAVurSU/dZ+zBdmmQnXMMv+nH7gLyLTMXSn/fnx45C2F14P 5zv9j6jxbLWhr0GwtVxcVbhoNZPQwYxFxXeLHnuaev/jCTgsrq085GzoPvlYDk+DAqau19XNvyGQv pfIbOAXWxmCyMbTESMIU1A56HLDQLP9zoFzFzoF9DmGuSwXyBU+mcertFnvu+q88fAztR1jMxQF7W /ZUEwIaFWXxIfp6wG1ug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWnnP-0001gL-3e; Fri, 31 May 2019 20:06:35 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWnnL-0001fJ-SN for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 20:06:33 +0000 Received: by mail-pf1-x441.google.com with SMTP id c6so6826783pfa.10 for ; Fri, 31 May 2019 13:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9TL9DcOEKgadixiKIuv445aeR9WBFQdFXZrUAgDcDlE=; b=kV49vqq86GuJyq1B2ExOHqAEHCBbLYAxLrlwX9YHW790oTpaKgrElCoYJHUXWkgOJV TyS26P7yQV73R8/GWkjjhukLJb66Q7zUUUJ7a2B93/pJZO6Shv5cFVuO06NhX0qS4a8f ckE9aHhSd9lIxLohPE/+lCMBZ2E8LEVATqVLm7wOqPKHieY8trNRGEwdnTfcrdqsN1Fz yu0mhBAzkmIxIgd+iih/pD0/QURI9+rxP04X2IHVXV+35kUITHS70Eb+sKRt40HBMm7w s6s3jP7zdEP+vz/WybVa2KYlVXm/9BI/SzyLBAfs7+4YVEhu/Sm8BI/uV6UgsPEc/XKh zXXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9TL9DcOEKgadixiKIuv445aeR9WBFQdFXZrUAgDcDlE=; b=iNDiTiZiexJcX06f2u9XurKP4Zkt5o7kxtIZSJT4jzXyeb1qhbwR/4aJ0bQWX9DfPv wAp+ikojs2LUwH52C8R5jS8CVTlsCOOQ6Cd0S4zjpOBDCYSd6mIZtEIlgqZtVwncdiX+ 6Fj3oTDGjZz+0k5Trz0d2JMl7hsHSlQzauemuxpFQWxg2NTXlk2s97kegd6WMRoVB/5v FKW4Ikw/s3Iektz1UF19VJ84gO8mvacXdkQ6ARbumn86fww7vZmsWpX8M6Ay9rpWVZ9Y ch9Voic2YADCb6RISR5MQkeFQ7gJ+7urTk54fbNQHgpYdU1Eird04OCaLMra4IEHKawR 3/Yw== X-Gm-Message-State: APjAAAVx4J+70Fd1rYIgQtc9mYEDBlpArA7h2cm2RsifLvF3gjJuQcif juIEDsrESt6qnAcVK+Kg8Gv7igl8/wZaYDVX5R6/pGLI X-Google-Smtp-Source: APXvYqyEK1gsqxDA0Or/CK+vKBpJnggOs9awLB6ySElXj4BB/3+n9Gqj3w6GYh+I5qrhLxZWF88p5xir5ByMCP3e/lU= X-Received: by 2002:a17:90a:ac11:: with SMTP id o17mr3043266pjq.134.1559333185173; Fri, 31 May 2019 13:06:25 -0700 (PDT) MIME-Version: 1.0 References: <20190528235742.105510-1-natechancellor@gmail.com> <20190531183227.GA34102@archlinux-epyc> In-Reply-To: From: Nick Desaulniers Date: Fri, 31 May 2019 13:06:13 -0700 Message-ID: Subject: Re: [PATCH] ARM: xor-neon: Replace __GNUC__ checks with CONFIG_CC_IS_GCC To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_130631_918497_EE2E8DC7 X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Pitre , Ard Biesheuvel , Linux Kernel Mailing List , Stefan Agner , Russell King , clang-built-linux , Nathan Chancellor , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 31, 2019 at 12:21 PM Arnd Bergmann wrote: > clang, I would suggest dropping your patch then, and instead adding I disagree. The minimum version of gcc required to build the kernel is 4.6, so the comment about older versions of gcc is irrelevant and should be removed. Nathan's -Rpass warnings are warning that vectorization was not calculated to be profitable **for 1 of the 4 functions** by LLVM. Surely we wouldn't disable NEON opts for XOR because 1 of 4 was not vectorized? -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel