From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA03BC43467 for ; Wed, 14 Oct 2020 09:22:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FDCB2054F for ; Wed, 14 Oct 2020 09:22:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="d6OEbf/+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730164AbgJNJWf (ORCPT ); Wed, 14 Oct 2020 05:22:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727833AbgJNJVv (ORCPT ); Wed, 14 Oct 2020 05:21:51 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B78FC0610D1 for ; Tue, 13 Oct 2020 15:37:33 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id g29so663512pgl.2 for ; Tue, 13 Oct 2020 15:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t+96sOhB1uhq2YjHHSuH7V+uCK/i5ddWXeBGT6qagJA=; b=d6OEbf/+V3UpxQdj2KMVlgOQcefOZdwa3t2IYeg6hJ+lKu3UXruJnPByJcdjka4MBR 4SAdUkNgqPXDj4W0srOyR8s0lLtX9jrVvv0PCkGks13TUOW/kXDX1+1bZds9tEkeOmvM 2It/ZbepycqUMq/DB66R6g1+UPLJEEF4lV8N6vhEI7yQ/pCURkPMf676QOZ8OLCMGOX3 ZMFYznBYfJd8pEsQVQHk+Qm/3WXO+FNY0mxUsBY3+ZAo2CPE+iFBagq/vFVv3jAHyFAn mouDl5Sa1TlXuHRXscWk1l0p38nOax3UPYKSdeQSsUJRmh4em6/PrjM1mx1+AuIsBZvb SWlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t+96sOhB1uhq2YjHHSuH7V+uCK/i5ddWXeBGT6qagJA=; b=uHrO9MB3pEx2efWsxIMzMYaDvWYL4hKTpBpWF+ycE4+fEW2urOo4ur2kY8bEYgzLqY z4RJWTwFSrgvqTs2JlGhPEyjQemmazfE4JrkwcTzrgbOB7PWpkKmkAdjwBb+IYHzTzbt zuBsM1oKn7uxIlAQqcFq+0ybP+KOKkUe2kDhTskzI4it8iXNXkbSvHhkQ+ipRQllwG6G murBe6rdSEZVU53uQMs52GbVuVcHEZ0tD2TKlefa3uONFVkN2VMtUwweIkbuoBlhh9VP NRVm+4qQrE2ejSaFT1qmgjx9ju1Pz6FZKCcz2LdDhFh5Kfe6W2XMykj0c5PFDziZf3mD FV5g== X-Gm-Message-State: AOAM5304iMh23j94AJf3zGDLDB4i260IAI17wxw19VxMSG8L57cs54FK 94fxnV/L+68XAQ3B3O4IrWavGHZvt9s624ILpPMic5iKUm8= X-Google-Smtp-Source: ABdhPJyB0FBPN6kmOAg+J/VCEh6dU5+yk6DK5SN+eaoylYe+N7AYyL/Y2UtPVKzPBoIPLNRcoa/aaBtLeEfdN2T7dSQ= X-Received: by 2002:a63:1f03:: with SMTP id f3mr1305731pgf.381.1602628652646; Tue, 13 Oct 2020 15:37:32 -0700 (PDT) MIME-Version: 1.0 References: <20201013033947.2257501-1-natechancellor@gmail.com> In-Reply-To: <20201013033947.2257501-1-natechancellor@gmail.com> From: Nick Desaulniers Date: Tue, 13 Oct 2020 15:37:21 -0700 Message-ID: Subject: Re: [PATCH] arm64: vdso32: Allow ld.lld to properly link the VDSO To: Nathan Chancellor Cc: Catalin Marinas , Will Deacon , Masahiro Yamada , Vincenzo Frascino , Linux ARM , Linux Kbuild mailing list , LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2020 at 8:41 PM Nathan Chancellor wrote: > > As it stands now, the vdso32 Makefile hardcodes the linker to ld.bfd > using -fuse-ld=bfd with $(CC). This was taken from the arm vDSO > Makefile, as the comment notes, done in commit d2b30cd4b722 ("ARM: > 8384/1: VDSO: force use of BFD linker"). > > Commit fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of $(CC) to > link VDSO") changed that Makefile to use $(LD) directly instead of > through $(CC), which matches how the rest of the kernel operates. Since > then, LD=ld.lld means that the arm vDSO will be linked with ld.lld, > which has shown no problems so far. > > Allow ld.lld to link this vDSO as we do the regular arm vDSO. To do > this, we need to do a few things: > > * Add a LD_COMPAT variable, which defaults to $(CROSS_COMPILE_COMPAT)ld > with gcc and $(LD) if LLVM is 1, which will be ld.lld, or > $(CROSS_COMPILE_COMPAT)ld if not, which matches the logic of the main > Makefile. It is overrideable for further customization and avoiding > breakage. > > * Eliminate cc32-ldoption, which matches commit 055efab3120b ("kbuild: > drop support for cc-ldoption"). > > With those, we can use $(LD_COMPAT) in cmd_ldvdso and change the flags > from compiler linker flags to linker flags directly. We eliminate > -mfloat-abi=soft because it is not handled by the linker. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1033 > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor Thanks for the patch and summary of related changes! This is immediately useful for Android. Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers > --- > > NOTE: This patch is currently based on the kbuild tree due to the > --build-id -> --build-id=sha1 change that Bill did. If the arm64 > maintainers would prefer to take this patch, I can rebase it (althought > presumably this won't hit mainline until at least 5.11 so it can > probably just stay as is for now). > > arch/arm64/kernel/vdso32/Makefile | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 7f96a1a9f68c..1cf00c58805d 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -22,16 +22,21 @@ endif > > CC_COMPAT ?= $(CC) > CC_COMPAT += $(CC_COMPAT_CLANG_FLAGS) > + > +ifeq ($(LLVM),1) > +LD_COMPAT ?= $(LD) > +else > +LD_COMPAT ?= $(CROSS_COMPILE_COMPAT)ld > +endif > else > CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc > +LD_COMPAT ?= $(CROSS_COMPILE_COMPAT)ld > endif > > cc32-option = $(call try-run,\ > $(CC_COMPAT) $(1) -c -x c /dev/null -o "$$TMP",$(1),$(2)) > cc32-disable-warning = $(call try-run,\ > $(CC_COMPAT) -W$(strip $(1)) -c -x c /dev/null -o "$$TMP",-Wno-$(strip $(1))) > -cc32-ldoption = $(call try-run,\ > - $(CC_COMPAT) $(1) -nostdlib -x c /dev/null -o "$$TMP",$(1),$(2)) > cc32-as-instr = $(call try-run,\ > printf "%b\n" "$(1)" | $(CC_COMPAT) $(VDSO_AFLAGS) -c -x assembler -o "$$TMP" -,$(2),$(3)) > > @@ -122,14 +127,10 @@ dmbinstr := $(call cc32-as-instr,dmb ishld,-DCONFIG_AS_DMB_ISHLD=1) > VDSO_CFLAGS += $(dmbinstr) > VDSO_AFLAGS += $(dmbinstr) > > -VDSO_LDFLAGS := $(VDSO_CPPFLAGS) > # From arm vDSO Makefile > -VDSO_LDFLAGS += -Wl,-Bsymbolic -Wl,--no-undefined -Wl,-soname=linux-vdso.so.1 > -VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 > -VDSO_LDFLAGS += -nostdlib -shared -mfloat-abi=soft > -VDSO_LDFLAGS += -Wl,--hash-style=sysv > -VDSO_LDFLAGS += -Wl,--build-id=sha1 > -VDSO_LDFLAGS += $(call cc32-ldoption,-fuse-ld=bfd) > +VDSO_LDFLAGS += -Bsymbolic --no-undefined -soname=linux-vdso.so.1 > +VDSO_LDFLAGS += -z max-page-size=4096 -z common-page-size=4096 > +VDSO_LDFLAGS += -nostdlib -shared --hash-style=sysv --build-id=sha1 > > > # Borrow vdsomunge.c from the arm vDSO > @@ -189,8 +190,8 @@ quiet_cmd_vdsold_and_vdso_check = LD32 $@ > cmd_vdsold_and_vdso_check = $(cmd_vdsold); $(cmd_vdso_check) > > quiet_cmd_vdsold = LD32 $@ > - cmd_vdsold = $(CC_COMPAT) -Wp,-MD,$(depfile) $(VDSO_LDFLAGS) \ > - -Wl,-T $(filter %.lds,$^) $(filter %.o,$^) -o $@ > + cmd_vdsold = $(LD_COMPAT) $(VDSO_LDFLAGS) \ > + -T $(filter %.lds,$^) $(filter %.o,$^) -o $@ > quiet_cmd_vdsocc = CC32 $@ > cmd_vdsocc = $(CC_COMPAT) -Wp,-MD,$(depfile) $(VDSO_CFLAGS) -c -o $@ $< > quiet_cmd_vdsocc_gettimeofday = CC32 $@ > > base-commit: 172aad81a882443eefe1bd860c4eddc81b14dd5b > -- > 2.29.0.rc0 > -- Thanks, ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0023BC433DF for ; Tue, 13 Oct 2020 22:39:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B769218AC for ; Tue, 13 Oct 2020 22:39:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N0xXBF87"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="d6OEbf/+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B769218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v2a16VE5WzhmdBg2uXv4vfNUci/h3fmWUTlpNShmQqM=; b=N0xXBF87M1jhoCG6nYY0h4NWD mtzcY03LqsNkLNDDmM/niwem2qNpFpTnAoT3kdLNRNC6PmL0XbHcggIRlN9M9MeVAUD+s/gBTwA8t 8N67e/nQMczXaJYTWOoJa6SBCFmQp+r5jF9VwfozlZJ+bKyCNxYgjF5bBsf4AIcFTUmqIO1PJkrL/ yLSZUb6Vs16m2HIFYyHB3XyoXmusMtVyVuYNGYJQXnY1RwPDljcOowCoGVAC7V3o0z01rbBE+bVk0 MIoEGaWh2/vcnbnOTBxgjrfgRuMbFPtQwk6D6BN2Iyh1OpLdPi3j8+opLaqxwJzznRj1IDu6eZCYP N1OcYb1Rw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSSvM-0003bm-L1; Tue, 13 Oct 2020 22:37:40 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSSvI-0003ai-ME for linux-arm-kernel@lists.infradead.org; Tue, 13 Oct 2020 22:37:38 +0000 Received: by mail-pg1-x541.google.com with SMTP id x13so644430pgp.7 for ; Tue, 13 Oct 2020 15:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t+96sOhB1uhq2YjHHSuH7V+uCK/i5ddWXeBGT6qagJA=; b=d6OEbf/+V3UpxQdj2KMVlgOQcefOZdwa3t2IYeg6hJ+lKu3UXruJnPByJcdjka4MBR 4SAdUkNgqPXDj4W0srOyR8s0lLtX9jrVvv0PCkGks13TUOW/kXDX1+1bZds9tEkeOmvM 2It/ZbepycqUMq/DB66R6g1+UPLJEEF4lV8N6vhEI7yQ/pCURkPMf676QOZ8OLCMGOX3 ZMFYznBYfJd8pEsQVQHk+Qm/3WXO+FNY0mxUsBY3+ZAo2CPE+iFBagq/vFVv3jAHyFAn mouDl5Sa1TlXuHRXscWk1l0p38nOax3UPYKSdeQSsUJRmh4em6/PrjM1mx1+AuIsBZvb SWlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t+96sOhB1uhq2YjHHSuH7V+uCK/i5ddWXeBGT6qagJA=; b=CQMwblsDGQPD/+7xxqHOd5dMYjxumknu//5onimGxOMCdxXi3TUA04h+OdsDhxdr6b ER8K1EGeJ5eMpuXU7PdseFCF8YcjSsQfRMmtkz4EMJTuRLjJRQGCaZqtRRCaRcDcZCHf RGmnBEEb4ORUL1cYdNQ3T+I9WJ+08cPtTRNiFtD84X9qEmKTp7cneMh5UUUgANqWlBtg T8QnaLmu4jzOjNxGQF5eUDYnhOmNtEVvLQZxMsPh/8jVBiICy4iVdxPyNY4730vF+VrL D6F6magBJemLaAXGMMjIAogIYEZdjqjMghGrxH7IHrNuWnDQG8I/iDb/W7g8suFIclvp k5MQ== X-Gm-Message-State: AOAM530eo2VX2/IT/8oPCh9OntUTsbEoCcDmRqjYKWVo3l8IMO/bDxBt Fi5oUnUhYqib3GsROSw+MIgbeQ8T1j6JtwmJ5s3wGw== X-Google-Smtp-Source: ABdhPJyB0FBPN6kmOAg+J/VCEh6dU5+yk6DK5SN+eaoylYe+N7AYyL/Y2UtPVKzPBoIPLNRcoa/aaBtLeEfdN2T7dSQ= X-Received: by 2002:a63:1f03:: with SMTP id f3mr1305731pgf.381.1602628652646; Tue, 13 Oct 2020 15:37:32 -0700 (PDT) MIME-Version: 1.0 References: <20201013033947.2257501-1-natechancellor@gmail.com> In-Reply-To: <20201013033947.2257501-1-natechancellor@gmail.com> From: Nick Desaulniers Date: Tue, 13 Oct 2020 15:37:21 -0700 Message-ID: Subject: Re: [PATCH] arm64: vdso32: Allow ld.lld to properly link the VDSO To: Nathan Chancellor X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201013_183736_764496_FD60FAD8 X-CRM114-Status: GOOD ( 29.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Kbuild mailing list , Catalin Marinas , Masahiro Yamada , LKML , clang-built-linux , Vincenzo Frascino , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 12, 2020 at 8:41 PM Nathan Chancellor wrote: > > As it stands now, the vdso32 Makefile hardcodes the linker to ld.bfd > using -fuse-ld=bfd with $(CC). This was taken from the arm vDSO > Makefile, as the comment notes, done in commit d2b30cd4b722 ("ARM: > 8384/1: VDSO: force use of BFD linker"). > > Commit fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of $(CC) to > link VDSO") changed that Makefile to use $(LD) directly instead of > through $(CC), which matches how the rest of the kernel operates. Since > then, LD=ld.lld means that the arm vDSO will be linked with ld.lld, > which has shown no problems so far. > > Allow ld.lld to link this vDSO as we do the regular arm vDSO. To do > this, we need to do a few things: > > * Add a LD_COMPAT variable, which defaults to $(CROSS_COMPILE_COMPAT)ld > with gcc and $(LD) if LLVM is 1, which will be ld.lld, or > $(CROSS_COMPILE_COMPAT)ld if not, which matches the logic of the main > Makefile. It is overrideable for further customization and avoiding > breakage. > > * Eliminate cc32-ldoption, which matches commit 055efab3120b ("kbuild: > drop support for cc-ldoption"). > > With those, we can use $(LD_COMPAT) in cmd_ldvdso and change the flags > from compiler linker flags to linker flags directly. We eliminate > -mfloat-abi=soft because it is not handled by the linker. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1033 > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor Thanks for the patch and summary of related changes! This is immediately useful for Android. Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers > --- > > NOTE: This patch is currently based on the kbuild tree due to the > --build-id -> --build-id=sha1 change that Bill did. If the arm64 > maintainers would prefer to take this patch, I can rebase it (althought > presumably this won't hit mainline until at least 5.11 so it can > probably just stay as is for now). > > arch/arm64/kernel/vdso32/Makefile | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 7f96a1a9f68c..1cf00c58805d 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -22,16 +22,21 @@ endif > > CC_COMPAT ?= $(CC) > CC_COMPAT += $(CC_COMPAT_CLANG_FLAGS) > + > +ifeq ($(LLVM),1) > +LD_COMPAT ?= $(LD) > +else > +LD_COMPAT ?= $(CROSS_COMPILE_COMPAT)ld > +endif > else > CC_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc > +LD_COMPAT ?= $(CROSS_COMPILE_COMPAT)ld > endif > > cc32-option = $(call try-run,\ > $(CC_COMPAT) $(1) -c -x c /dev/null -o "$$TMP",$(1),$(2)) > cc32-disable-warning = $(call try-run,\ > $(CC_COMPAT) -W$(strip $(1)) -c -x c /dev/null -o "$$TMP",-Wno-$(strip $(1))) > -cc32-ldoption = $(call try-run,\ > - $(CC_COMPAT) $(1) -nostdlib -x c /dev/null -o "$$TMP",$(1),$(2)) > cc32-as-instr = $(call try-run,\ > printf "%b\n" "$(1)" | $(CC_COMPAT) $(VDSO_AFLAGS) -c -x assembler -o "$$TMP" -,$(2),$(3)) > > @@ -122,14 +127,10 @@ dmbinstr := $(call cc32-as-instr,dmb ishld,-DCONFIG_AS_DMB_ISHLD=1) > VDSO_CFLAGS += $(dmbinstr) > VDSO_AFLAGS += $(dmbinstr) > > -VDSO_LDFLAGS := $(VDSO_CPPFLAGS) > # From arm vDSO Makefile > -VDSO_LDFLAGS += -Wl,-Bsymbolic -Wl,--no-undefined -Wl,-soname=linux-vdso.so.1 > -VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 > -VDSO_LDFLAGS += -nostdlib -shared -mfloat-abi=soft > -VDSO_LDFLAGS += -Wl,--hash-style=sysv > -VDSO_LDFLAGS += -Wl,--build-id=sha1 > -VDSO_LDFLAGS += $(call cc32-ldoption,-fuse-ld=bfd) > +VDSO_LDFLAGS += -Bsymbolic --no-undefined -soname=linux-vdso.so.1 > +VDSO_LDFLAGS += -z max-page-size=4096 -z common-page-size=4096 > +VDSO_LDFLAGS += -nostdlib -shared --hash-style=sysv --build-id=sha1 > > > # Borrow vdsomunge.c from the arm vDSO > @@ -189,8 +190,8 @@ quiet_cmd_vdsold_and_vdso_check = LD32 $@ > cmd_vdsold_and_vdso_check = $(cmd_vdsold); $(cmd_vdso_check) > > quiet_cmd_vdsold = LD32 $@ > - cmd_vdsold = $(CC_COMPAT) -Wp,-MD,$(depfile) $(VDSO_LDFLAGS) \ > - -Wl,-T $(filter %.lds,$^) $(filter %.o,$^) -o $@ > + cmd_vdsold = $(LD_COMPAT) $(VDSO_LDFLAGS) \ > + -T $(filter %.lds,$^) $(filter %.o,$^) -o $@ > quiet_cmd_vdsocc = CC32 $@ > cmd_vdsocc = $(CC_COMPAT) -Wp,-MD,$(depfile) $(VDSO_CFLAGS) -c -o $@ $< > quiet_cmd_vdsocc_gettimeofday = CC32 $@ > > base-commit: 172aad81a882443eefe1bd860c4eddc81b14dd5b > -- > 2.29.0.rc0 > -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel