From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFF51C432BE for ; Tue, 27 Jul 2021 20:26:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6B8760F0F for ; Tue, 27 Jul 2021 20:26:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232338AbhG0U0I (ORCPT ); Tue, 27 Jul 2021 16:26:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232140AbhG0U0H (ORCPT ); Tue, 27 Jul 2021 16:26:07 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15C36C061757 for ; Tue, 27 Jul 2021 13:26:07 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id a26so23812160lfr.11 for ; Tue, 27 Jul 2021 13:26:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5W7I5NJ7607nekgTVXMsjnvhBYEaNIc7ZnBD14nK1Lw=; b=SGmBbFjeBkkvg5TnrRW6wDpFH1NZFsjj8NeVunkx64lh+U9JXSYPNskR7ozV0UkJEJ zBkDxxdXq8bKevyGTMDR9q1g71RKl/lQjTPgnbPUIYWM4jMQVRggD6l7pJBWGfEAsUAf 3xZI07lQmMXYSGk0PzGduvG7h5rGYaMFS2LXhIFUO3U4xQOLH4Y9dXb48ZCxiObAxxxJ CbO2ELTV6ZtUc0gkzVDRdYACFOpF2yjIXvG22ko/tFt/xDkhAWh8uqJW59JPlYdZlBZ6 0KiO+dFjPFwHlfpo0/W1UpYFdGkksBsrQleck17dEYzoYLZxgeGW65qqOcakT1bLQpSH ixOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5W7I5NJ7607nekgTVXMsjnvhBYEaNIc7ZnBD14nK1Lw=; b=T1RcacOh97xppiBkGSvr0Vss1BTM2/O8zqvlAyc0KafJp27w5ahKep4oq/4wQAtYlO b4jI1HQfw3yd9XSVQ/vCjMeR3gxIdNCx/R5mgs/J7FMQfz4C/RkaBj6gvgJO0kDuNDij hlnRMGA/NX5bBL11plNsonEUt6fxEYCpPRoLDeAV1lHG480KOC+Q8L8nNB09FRuc7nln dHpMblp5dMqDZyPygtyRhmZJvJCnSuVx4rVVK6Lfu/SjqNJx1tztz21AOyQPH6SOgN7P 5xLtmJtjTXIrMIPWVkOGT1Vrf/f2Y4TI9fbUtdd3V2LaBMmI7RjJCkISz/B9qebaAHKq M0Dg== X-Gm-Message-State: AOAM533k1J3fUuGr5hdsfiELKmxvkg+9OwCXPOTHypOTVMD80BV4PvBG Cwg8pM7o3ACF6TQYIgjQI5+u1fXNLTB2WEPngylwDA== X-Google-Smtp-Source: ABdhPJwqrozlM71o/YWycrk4nFXhaQSolQceA5mTAAHS5NoeqVcyVBzNsPdOTSbtGWnIJUkr9LvsHBgHBJBrEUh0hWM= X-Received: by 2002:a05:6512:3e0c:: with SMTP id i12mr17532275lfv.122.1627417565216; Tue, 27 Jul 2021 13:26:05 -0700 (PDT) MIME-Version: 1.0 References: <20210718130748.230758-1-paul@crapouillou.net> <7YIIWQ.1TU3IBLL4KNC2@crapouillou.net> <20210721161719.GA9805@alpha.franken.de> In-Reply-To: <20210721161719.GA9805@alpha.franken.de> From: Nick Desaulniers Date: Tue, 27 Jul 2021 13:25:54 -0700 Message-ID: Subject: Re: [PATCH] MIPS: Avoid macro redefinitions To: Thomas Bogendoerfer , Paul Cercueil Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, list@opendingux.net, Kees Cook , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 21, 2021 at 9:17 AM Thomas Bogendoerfer wrote: > > On Mon, Jul 19, 2021 at 11:10:55PM +0100, Paul Cercueil wrote: > > > > #ifndef TOOLCHAIN_SUPPORTS_VIRT > > > > > > Same question for GAS version support for virt? > > > Documentation/process/changes.rst > > > says GNU binutils 2.23+ is required for building the kernel. > > > If we still need to support, have you tested this change on such an > > > older version of GNU binutils? > > > > I have no idea about virt support - I hope Thomas can answer this. > > virt support was added in 2.24 and xpa in 2.25. So we still need the > TOOLCHAIN defines for it. Ah, ok then. Thanks for finding that. Perhaps Paul you can note that in the v2 that removes the commented out line, then we should be good to go? -- Thanks, ~Nick Desaulniers