From: Nick Desaulniers <ndesaulniers@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Will Deacon <will@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
kernel-team <kernel-team@android.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH v2 09/10] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8
Date: Fri, 24 Jan 2020 09:05:27 -0800 [thread overview]
Message-ID: <CAKwvOdmFMnCgr3rP5vNkj_H1SnBJ6drdBP1RSGxzfYzSiWGfLg@mail.gmail.com> (raw)
In-Reply-To: <20200124082637.GZ14914@hirez.programming.kicks-ass.net>
On Fri, Jan 24, 2020 at 12:26 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Thu, Jan 23, 2020 at 10:36:37AM -0800, Nick Desaulniers wrote:
> > On Thu, Jan 23, 2020 at 7:34 AM Will Deacon <will@kernel.org> wrote:
> > >
> > > It is very rare to see versions of GCC prior to 4.8 being used to build
> > > the mainline kernel. These old compilers are also know to have codegen
> > > issues which can lead to silent miscompilation:
> > >
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> > >
> > > Raise the minimum GCC version for kernel build to 4.8 and remove some
> > > tautological Kconfig dependencies as a consequence.
> > >
> > > Cc: Nick Desaulniers <ndesaulniers@google.com>
> >
> > Thanks for the patch.
> > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> > I wouldn't mind if this patch preceded the earlier one in the series
> > adding the warning, should the series require a v2 and if folks are
> > generally ok with bumping the min version.
>
> If I hadn't actually read your reply, I would have never spotted that
> reviewed-by tag, hidden in a blob of text like that.
>
> Adding some whitespace before and after, such that it stands out a
> little more, might avoid such issues.
Ack. Do maintainers have tools for fetching patch series and
automating collecting Reviewed-by tags, or is it all extremely manual?
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2020-01-24 17:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 15:33 [PATCH v2 00/10] Rework READ_ONCE() to improve codegen Will Deacon
2020-01-23 15:33 ` [PATCH v2 01/10] compiler/gcc: Emit build-time warning for GCC prior to version 4.8 Will Deacon
2020-01-23 15:33 ` [PATCH v2 02/10] netfilter: Avoid assigning 'const' pointer to non-const pointer Will Deacon
2020-01-23 19:07 ` Nick Desaulniers
2020-01-24 8:24 ` Peter Zijlstra
2020-01-24 17:20 ` Nick Desaulniers
2020-01-27 12:04 ` David Laight
2020-01-24 17:36 ` Linus Torvalds
2020-01-24 22:00 ` Peter Zijlstra
2020-01-27 12:21 ` David Laight
2020-01-23 15:33 ` [PATCH v2 03/10] fault_inject: Don't rely on "return value" from WRITE_ONCE() Will Deacon
2020-01-23 15:33 ` [PATCH v2 04/10] READ_ONCE: Simplify implementations of {READ,WRITE}_ONCE() Will Deacon
2020-01-23 15:33 ` [PATCH v2 05/10] READ_ONCE: Enforce atomicity for {READ,WRITE}_ONCE() memory accesses Will Deacon
2020-01-25 8:27 ` Peter Zijlstra
2020-01-29 10:49 ` Peter Zijlstra
2020-01-23 15:33 ` [PATCH v2 06/10] READ_ONCE: Drop pointer qualifiers when reading from scalar types Will Deacon
2020-01-23 15:33 ` [PATCH v2 07/10] locking/barriers: Use '__unqual_scalar_typeof' for load-acquire macros Will Deacon
2020-01-23 15:33 ` [PATCH v2 08/10] arm64: barrier: Use '__unqual_scalar_typeof' for acquire/release macros Will Deacon
2020-01-23 15:33 ` [PATCH v2 09/10] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8 Will Deacon
2020-01-23 18:36 ` Nick Desaulniers
2020-01-24 8:26 ` Peter Zijlstra
2020-01-24 17:05 ` Nick Desaulniers [this message]
2020-01-24 23:29 ` Peter Zijlstra
2020-01-25 10:34 ` Michael Ellerman
2020-01-23 15:33 ` [PATCH v2 10/10] gcov: Remove old GCC 3.4 support Will Deacon
2020-01-23 18:51 ` Nick Desaulniers
2020-01-28 14:56 ` Peter Oberparleiter
2020-01-23 17:07 ` [PATCH v2 00/10] Rework READ_ONCE() to improve codegen David Laight
2020-01-23 17:16 ` Will Deacon
2020-01-23 17:32 ` David Laight
2020-01-23 18:45 ` Nick Desaulniers
2020-01-23 19:01 ` Arvind Sankar
2020-01-24 10:11 ` David Laight
2020-01-26 1:10 ` Qais Yousef
2020-01-27 7:26 ` Arnd Bergmann
2020-01-23 17:59 ` Linus Torvalds
2020-01-24 8:33 ` Peter Zijlstra
2020-01-24 10:41 ` Peter Zijlstra
2020-02-10 9:50 ` Masahiro Yamada
2020-02-10 9:50 ` Masahiro Yamada
2020-02-10 9:59 ` Will Deacon
2020-01-31 10:20 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdmFMnCgr3rP5vNkj_H1SnBJ6drdBP1RSGxzfYzSiWGfLg@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=arnd@arndb.de \
--cc=borntraeger@de.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=masahiroy@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=oberpar@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=segher@kernel.crashing.org \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.