From: Nick Desaulniers <ndesaulniers@google.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <peterz@infradead.org>,
"H . Peter Anvin" <hpa@zytor.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 10/16] x86: probe assembler capabilities via kconfig instead of makefile
Date: Thu, 26 Mar 2020 13:00:35 -0700 [thread overview]
Message-ID: <CAKwvOdmG4hRnG+R_ASLULdEVm31XkEo4vih7GxpNWK9f6xtCng@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9oD7DVSGVkWv2jAyr5eZUy2Ac+MWzss5dhKEmG3hq6AFg@mail.gmail.com>
On Thu, Mar 26, 2020 at 12:54 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> On Thu, Mar 26, 2020 at 11:49 AM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> >
> > On Thu, Mar 26, 2020 at 1:02 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> > >
> > > From: "Jason A. Donenfeld" <Jason@zx2c4.com>
> > >
> > > Doing this probing inside of the Makefiles means we have a maze of
> > > ifdefs inside the source code and child Makefiles that need to make
> > > proper decisions on this too. Instead, we do it at Kconfig time, like
> > > many other compiler and assembler options, which allows us to set up the
> > > dependencies normally for full compilation units. In the process, the
> > > ADX test changes to use %eax instead of %r10 so that it's valid in both
> > > 32-bit and 64-bit mode.
> >
> > Does KConfig generate -D<foo> flags for KBUILD_CFLAGS and KBUILD_AFLAGS?
>
> kconfig sticks everything it's got into include/generated/autoconf.h.
> That's how you're able to use all those #ifdef CONFIG_* macros
> already. This change moves things from a command line -D to the
> autoconf.h file.
Cool, I wondered how that was wired up. Though seeing the word
"autoconf" brings on PTSD for me.
Patch LGTM.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> > Looks like lib/raid6/test/Makefile also generates some of these?
>
> raid6 has its own crazy thing going on. The test directory compiles
> that code for use in userspace. You might argue that its whole
> situation is non-standard and weird and should be reworked
> differently, but that seems like fodder for a different patchset on
> the linux-raid list.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2020-03-26 20:00 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 8:00 [PATCH v2 00/16] x86, crypto: remove always-defined CONFIG_AS_* and cosolidate Kconfig/Makefiles Masahiro Yamada
2020-03-26 8:00 ` [Intel-gfx] " Masahiro Yamada
2020-03-26 8:00 ` Masahiro Yamada
2020-03-26 8:00 ` [PATCH v2 01/16] lib/raid6/test: fix build on distros whose /bin/sh is not bash Masahiro Yamada
2020-03-26 8:00 ` [PATCH v2 02/16] x86: remove unneeded defined(__ASSEMBLY__) check from asm/dwarf2.h Masahiro Yamada
2020-03-26 8:00 ` [PATCH v2 03/16] x86: remove always-defined CONFIG_AS_CFI Masahiro Yamada
2020-03-26 8:00 ` [PATCH v2 04/16] x86: remove unneeded (CONFIG_AS_)CFI_SIGNAL_FRAME Masahiro Yamada
2020-03-26 8:00 ` [PATCH v2 05/16] x86: remove always-defined CONFIG_AS_CFI_SECTIONS Masahiro Yamada
2020-03-26 8:00 ` [PATCH v2 06/16] x86: remove always-defined CONFIG_AS_SSSE3 Masahiro Yamada
2020-03-26 8:00 ` [PATCH v2 07/16] x86: remove always-defined CONFIG_AS_AVX Masahiro Yamada
2020-03-26 8:00 ` [PATCH v2 08/16] x86: replace arch macros from compiler with CONFIG_X86_{32,64} Masahiro Yamada
2020-03-31 2:40 ` Masahiro Yamada
2020-03-31 4:38 ` Jason A. Donenfeld
2020-03-26 8:00 ` [PATCH v2 09/16] drm/i915: remove always-defined CONFIG_AS_MOVNTDQA Masahiro Yamada
2020-03-26 8:00 ` [Intel-gfx] " Masahiro Yamada
2020-03-26 8:00 ` Masahiro Yamada
2020-03-26 8:24 ` Jani Nikula
2020-03-26 8:24 ` [Intel-gfx] " Jani Nikula
2020-03-26 8:24 ` Jani Nikula
2020-03-26 8:24 ` Jani Nikula
2020-03-26 8:00 ` [PATCH v2 10/16] x86: probe assembler capabilities via kconfig instead of makefile Masahiro Yamada
2020-03-26 17:49 ` Nick Desaulniers
2020-03-26 19:53 ` Jason A. Donenfeld
2020-03-26 20:00 ` Nick Desaulniers [this message]
2020-03-26 8:00 ` [PATCH v2 11/16] x86: add comments about the binutils version to support code in as-instr Masahiro Yamada
2020-03-26 17:50 ` Nick Desaulniers
2020-03-26 8:01 ` [PATCH v2 12/16] crypto: x86 - rework configuration based on Kconfig Masahiro Yamada
2020-03-26 8:01 ` [PATCH v2 13/16] crypto: curve25519 - do not pollute dispatcher based on assembler Masahiro Yamada
2020-03-26 8:01 ` [PATCH v2 14/16] Documentation/changes: Raise minimum supported binutils version to 2.23 Masahiro Yamada
2020-03-26 8:01 ` [PATCH v2 15/16] x86: update AS_* macros to binutils >=2.23, supporting ADX and AVX2 Masahiro Yamada
2020-03-26 17:55 ` Nick Desaulniers
2020-03-26 17:55 ` Nick Desaulniers
2020-03-26 19:48 ` Jason A. Donenfeld
2020-03-26 19:48 ` Jason A. Donenfeld
2020-03-26 19:58 ` Nick Desaulniers
2020-03-26 19:58 ` Nick Desaulniers
2020-03-26 20:26 ` [PATCH] " Jason A. Donenfeld
2020-03-26 20:29 ` Nick Desaulniers
2020-03-26 20:50 ` Masahiro Yamada
2020-03-26 8:01 ` [PATCH v2 16/16] crypto: x86 - clean up poly1305-x86_64-cryptogams.S by 'make clean' Masahiro Yamada
2020-03-26 8:12 ` [PATCH v2 00/16] x86, crypto: remove always-defined CONFIG_AS_* and cosolidate Kconfig/Makefiles Jason A. Donenfeld
2020-03-26 8:12 ` [Intel-gfx] " Jason A. Donenfeld
2020-03-26 9:22 ` Ingo Molnar
2020-03-26 9:22 ` [Intel-gfx] " Ingo Molnar
2020-03-26 9:22 ` Ingo Molnar
2020-03-26 20:43 ` Masahiro Yamada
2020-03-26 20:43 ` [Intel-gfx] " Masahiro Yamada
2020-03-26 20:43 ` Masahiro Yamada
2020-03-26 20:46 ` Jason A. Donenfeld
2020-03-26 20:46 ` [Intel-gfx] " Jason A. Donenfeld
2020-03-26 21:12 ` Masahiro Yamada
2020-03-26 21:12 ` [Intel-gfx] " Masahiro Yamada
2020-03-26 21:12 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdmG4hRnG+R_ASLULdEVm31XkEo4vih7GxpNWK9f6xtCng@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=Jason@zx2c4.com \
--cc=bp@alien8.de \
--cc=clang-built-linux@googlegroups.com \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.