From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D1EC3A59F for ; Thu, 29 Aug 2019 17:47:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 985A621726 for ; Thu, 29 Aug 2019 17:47:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rHAmbQ9q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="fFRWa3CU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 985A621726 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o5DKJprHZbeZH2Iqso9uWKXALseRYdjw/td5AerKz30=; b=rHAmbQ9qksFuzf 7U9L1NSXUl3KnUuAcmuHb331PTVHLPxTlfykiLMHJuX3yN9gDSkZrbkU+gSgAybKW1ulMQwb28AHL /5P+bsOcItYND/USJxrNv8bBK4UoUOf+sEnjOz94gjPFUlIu63b5TZCBaAVKeC7YMoym6aVUrAB/h C5k/CdXFRhOq441ZXonwATCOyh0TTDj6bJ1i4/OIgNhO0fgE+O+PI9ZKOzgYiRU1IGRCKRLk572Mi Y9bJ3GrsmV4CTlDGxpiNIwny25PCdBH3y8FNHiXyteGIO0NO70E7Tk/+WRd2ztLxkYp8Yd0gq0pHV knDgp0talh8WkRiJ2MIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3OWU-0004wo-4e; Thu, 29 Aug 2019 17:47:50 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i3OWR-0004wQ-9M for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2019 17:47:48 +0000 Received: by mail-pf1-x441.google.com with SMTP id 26so195742pfp.9 for ; Thu, 29 Aug 2019 10:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0xvDFXohsTBiXQteUhF//5H4PlMVw/jPy8bTloT6sZ0=; b=fFRWa3CUxlEe4Zp3arLzv0l9uJ5VFCXzlxp7hwuyHTspodZ4d0KlP1SEtSURGaGnDD NpjlV4bLNpEZ9dYCXXrLvBBUwpbpLSVGgy2n1j5Kno7RuIHtWFph5O7jqi8wzHVHUfgh hHB+twcs0O8tbyltexBmXk7tgghg35kUiw3WmGt0BCJuvNJd7OwQTPRMQ6hjgUBP6Ca5 bKbNxsIlwDYjUgro8pvYejc07lknU8/m+1dBYI0PMmQbk94cvhK96H+zyQQt+GOowZuZ kb/v5PDZO17NN+6W8/x5TMRQ6xU8J1p8NxwRZl395l/VonfFwVkTyw9ONPzKU4KjaIzM XK2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0xvDFXohsTBiXQteUhF//5H4PlMVw/jPy8bTloT6sZ0=; b=NhmDcsyfIT0jOmEq0QrvS8+x7X38U5DM2CjAui294pgjRInPgieELc+y8K1j12R+gt 5U7anjTvAc/rgGRQ6fxln2INRWShrP+/Uz/wkwg//7MOhDNtA8ceXFOfN/aUVPeoJ2XW aafrWaD2r2/D91HUi6jjOuZeDwm5GbEgu4W6Dj0Ko7xhRIRO9s5shT9YgGQhmIA+SM3H NPXI+LfyTUt6KXRy0xuzfRs/xA5Nqav3ZY2keetEdAR1meXBIpSilN3SoQmOW8Q5tKFO WCSAYLpORpnjaE7DeYJUR6pZJfukLasALyciaJY3C+ENwTKe3A0iAiHA5oNILrerGtUt Rtmg== X-Gm-Message-State: APjAAAWmWWvSos8sfHZvNWCItrBm+s2oFGKaEJm1EajNi7XV6uFsT1n1 lW+YkH2p7c2LjaTuJM6TU6d7irmJxvdddhpo1voajA== X-Google-Smtp-Source: APXvYqxq90no7VcBcm4J1ASuW3u/DGByPmO36ANysRUYdi9XY8JNfjdFRB3JuVAqolGWEE6gOnsE3jSeweKXDDtJGOY= X-Received: by 2002:a17:90a:3ae7:: with SMTP id b94mr11295208pjc.73.1567100866053; Thu, 29 Aug 2019 10:47:46 -0700 (PDT) MIME-Version: 1.0 References: <20190829154834.26547-1-will@kernel.org> <20190829154834.26547-6-will@kernel.org> In-Reply-To: <20190829154834.26547-6-will@kernel.org> From: Nick Desaulniers Date: Thu, 29 Aug 2019 10:47:34 -0700 Message-ID: Subject: Re: [PATCH v5 05/10] arm64: atomics: Remove atomic_ll_sc compilation unit To: Will Deacon X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190829_104747_356702_E9933DCB X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Tri Vo , Peter Zijlstra , Catalin Marinas , Ard.Biesheuvel@arm.com, andrew.murray@arm.com, Nathan Chancellor , Robin Murphy , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 29, 2019 at 8:48 AM Will Deacon wrote: > > From: Andrew Murray > > We no longer fall back to out-of-line atomics on systems with > CONFIG_ARM64_LSE_ATOMICS where ARM64_HAS_LSE_ATOMICS is not set. > > Remove the unused compilation unit which provided these symbols. > > Signed-off-by: Andrew Murray > Signed-off-by: Will Deacon > --- > arch/arm64/lib/Makefile | 19 ------------------- > arch/arm64/lib/atomic_ll_sc.c | 3 --- > 2 files changed, 22 deletions(-) > delete mode 100644 arch/arm64/lib/atomic_ll_sc.c > > diff --git a/arch/arm64/lib/Makefile b/arch/arm64/lib/Makefile > index 33c2a4abda04..f10809ef1690 100644 > --- a/arch/arm64/lib/Makefile > +++ b/arch/arm64/lib/Makefile > @@ -11,25 +11,6 @@ CFLAGS_REMOVE_xor-neon.o += -mgeneral-regs-only > CFLAGS_xor-neon.o += -ffreestanding > endif > > -# Tell the compiler to treat all general purpose registers (with the > -# exception of the IP registers, which are already handled by the caller > -# in case of a PLT) as callee-saved, which allows for efficient runtime > -# patching of the bl instruction in the caller with an atomic instruction > -# when supported by the CPU. Result and argument registers are handled > -# correctly, based on the function prototype. > -lib-$(CONFIG_ARM64_LSE_ATOMICS) += atomic_ll_sc.o > -CFLAGS_atomic_ll_sc.o := -ffixed-x1 -ffixed-x2 \ > - -ffixed-x3 -ffixed-x4 -ffixed-x5 -ffixed-x6 \ > - -ffixed-x7 -fcall-saved-x8 -fcall-saved-x9 \ > - -fcall-saved-x10 -fcall-saved-x11 -fcall-saved-x12 \ > - -fcall-saved-x13 -fcall-saved-x14 -fcall-saved-x15 \ > - -fcall-saved-x18 -fomit-frame-pointer + Tri (who implemented support for -fcall-saved-x*, -ffixed-x* in Clang). I won't be sad to see the use of these flags go. > -CFLAGS_REMOVE_atomic_ll_sc.o := $(CC_FLAGS_FTRACE) > -GCOV_PROFILE_atomic_ll_sc.o := n > -KASAN_SANITIZE_atomic_ll_sc.o := n > -KCOV_INSTRUMENT_atomic_ll_sc.o := n > -UBSAN_SANITIZE_atomic_ll_sc.o := n > - > lib-$(CONFIG_ARCH_HAS_UACCESS_FLUSHCACHE) += uaccess_flushcache.o > > obj-$(CONFIG_CRC32) += crc32.o > diff --git a/arch/arm64/lib/atomic_ll_sc.c b/arch/arm64/lib/atomic_ll_sc.c > deleted file mode 100644 > index b0c538b0da28..000000000000 > --- a/arch/arm64/lib/atomic_ll_sc.c > +++ /dev/null > @@ -1,3 +0,0 @@ > -#include > -#define __ARM64_IN_ATOMIC_IMPL > -#include > -- > 2.11.0 > -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel