From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A34A1C433F5 for ; Wed, 11 May 2022 19:34:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346991AbiEKTe6 (ORCPT ); Wed, 11 May 2022 15:34:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbiEKTex (ORCPT ); Wed, 11 May 2022 15:34:53 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DB50177898 for ; Wed, 11 May 2022 12:34:50 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id j4so5310167lfh.8 for ; Wed, 11 May 2022 12:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+ZeBueAo7XbLNHzSFdohWNSwZfJDZuFuvcSJwY8CQhE=; b=sY5PApnBJsxPzMuys/jslbcKeJaxlN768xHRp85uJ2JjMBKylsLasOTE1xiOYz9DrE +zHxayQfilge3sTH7mwsQGW9Fsx+J6W14+kAJtTARMuKl/NRqPANRL7sCv9C/vd34gF4 7pG39luF8/3brbm0o+w+UujmNj+v6Vhc3a00xXefZdKGF6wagpdJQ0qAKP+/pLw/q53J lmv05KW000ufZQS3kM/ED5l1ic9V1Z1R3xEUPIVGfkGolOoj6d67VM0rQ9RXgMO+Eivw KdR+E4pEu3A6zI0AhoYnU00bMG7f88OBlnnsfUJPV0JYjQPZzOoMMf8SahEhFktu27wh zfCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+ZeBueAo7XbLNHzSFdohWNSwZfJDZuFuvcSJwY8CQhE=; b=eerlRVig98b/tGO/uwvVAlOEiJBOXfF/qT+JHv2dxicsEZ3Dst9Fael8DFt0qlUpQ1 /9L6S4+Iqho3grJqqfISPvBbvx1SjTvlxoo3zaBEjKLYafjYhT4SX3msnwHNi4WyqP8F HayHP3A84tuAgNUJITrlBYMg+2ja3EM3WjnwfAo3YiUPcd6FeqkLkHAcq2b/mkxHn7Nh vQmyWrFdC8rcdo6aB/cvFDMVOfzsSbizABEqfwMdEsQ3501vFTB+wO4HBcK+WcqoIojn rELfCur7jCdWFivqtBABi/tGBs4nvkpCysdNdVEzEFa7hb+tNjDOAfEvBZQZ5YP1nykI YDPw== X-Gm-Message-State: AOAM530wy4/jtNpK9otYOpz/vy1SOgzI5AZdWqZ9lp1RZIQ5cU+tlZMv EaMUUem6HbXWCwF20idX6FAeaqJg6Y/F8DCbZgNT7g== X-Google-Smtp-Source: ABdhPJx0nq21d57bjSMLc9tnNiGLxntA/KgJYcxML0H/xX2fFJiktsvqHKmc9w082aQb5KnRyqZul6G+7fuSOGjN+qg= X-Received: by 2002:a05:6512:1291:b0:473:b522:ef58 with SMTP id u17-20020a056512129100b00473b522ef58mr20873024lfs.190.1652297688470; Wed, 11 May 2022 12:34:48 -0700 (PDT) MIME-Version: 1.0 References: <20220511072747.3960-1-jiangshanlai@gmail.com> <20220511072747.3960-2-jiangshanlai@gmail.com> In-Reply-To: From: Nick Desaulniers Date: Wed, 11 May 2022 12:34:36 -0700 Message-ID: Subject: Re: [PATCH 1/7] x86/entry: Introduce __entry_text for entry code written in C To: Miguel Ojeda Cc: Lai Jiangshan , linux-kernel , Borislav Petkov , Peter Zijlstra , Josh Poimboeuf , Andy Lutomirski , Thomas Gleixner , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Lai Jiangshan , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Kuppuswamy Sathyanarayanan , Joerg Roedel , "Kirill A. Shutemov" , Miguel Ojeda , Kees Cook , Nathan Chancellor , Andrew Morton , Alexei Starovoitov , Marco Elver , Hao Luo , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2022 at 12:27 PM Miguel Ojeda wrote: > > On Wed, May 11, 2022 at 8:01 PM Nick Desaulniers > wrote: > > > > I haven't looked at the rest of the series, but isn't `noinstr` used > > in a bunch of places? Wont this commit break all those uses or at > > Except the order, it expands to the same, no? Or what is the issue? Yeah, nvm, I missed the bottom #define for some reason. -- Thanks, ~Nick Desaulniers