From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E54AC433F5 for ; Fri, 15 Oct 2021 19:11:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6A3D610D2 for ; Fri, 15 Oct 2021 19:11:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242588AbhJOTNN (ORCPT ); Fri, 15 Oct 2021 15:13:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242504AbhJOTNJ (ORCPT ); Fri, 15 Oct 2021 15:13:09 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEE58C061764 for ; Fri, 15 Oct 2021 12:11:02 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id x192so10728187lff.12 for ; Fri, 15 Oct 2021 12:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oI0JQpdNcS1rPABaNRpOZ/cT39QBnr4F5JH8mM3KD1w=; b=KItGKghbFy6S8IwlkpEtP4HNbtAfKfSjgliZYr6bPw6mL8dfVSVPPw+Lu6A3D6KYGG JL6+RBOsqVCU63RCfXhpXlk9/+Od7crS2PHmqiaTBP4vaYWJC8bpMmWXSDhfIaJCfV9x KV7yHlxcxqHOZl3G2UPtEQbwkzn4SeJokDnkr5D6uE1SuAkNwE+Os6wBth3CI/ZCjZnJ Fl7nxdD3gZBsmghjKmNQyoN/DtGfjys0qypNRPMsb730as0k1sPUN9PL7I8LoXNold+W oKG8PJms0LcTJcgMvueNQDJMwRWsCmSQyRGJoWkFMc6KF85C5Nc8KvAQE9EebTj1WNR7 yqUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oI0JQpdNcS1rPABaNRpOZ/cT39QBnr4F5JH8mM3KD1w=; b=4yY0wL7MdbiLjH6IvTMDvoBAX/6psLMTMLi3oB1kppJsHC1XSzH7YCN89F1mYKY+og 65pzBfDeRbUCZBvoyus1DlY9Qba4mLlgb6MElv1lRI2YFvHYBiEfDbRx7c+4x2XBN7aV eXVjWjMsK2+KRK58x5pqww2KGJN0rufANZqJWipIrOBf9VdnWmsfyDGxw3GFL+5KwHKp t5AqymaYnOx9Z/ppJOD2Cc0WgruEFDBf0Su6wHYYSnI0KAOA4dcNJb4ooVxSy1XMTMG9 SIe1AapIobfec4ysaZlfnoVyof8vxckNC+3/0GUuH5BMiqnpeYTUWINiWq7bLucS+SLs f8bQ== X-Gm-Message-State: AOAM531/Niatp7ybo+Gu6i685Fi6FbutnQ9dnDAW3b5UxE6f6bxY3lnx pQuN9c/YEPyOwEBCmQ2bQacY9f23JT76C7Uo6XyDMg== X-Google-Smtp-Source: ABdhPJxJPbFY1d2ckPhtr+TsSG22LMoybIwYHl50ZAsM2+uDTJMohjuxtsNO4gx/E6FVg7uvt9WPFt5c5aoDLal6yWY= X-Received: by 2002:a05:651c:1108:: with SMTP id d8mr14747364ljo.220.1634325060799; Fri, 15 Oct 2021 12:11:00 -0700 (PDT) MIME-Version: 1.0 References: <1634167668-60198-1-git-send-email-ashimida@linux.alibaba.com> <722d9662-e27c-2efb-e8cf-d505b6950475@linux.alibaba.com> In-Reply-To: <722d9662-e27c-2efb-e8cf-d505b6950475@linux.alibaba.com> From: Nick Desaulniers Date: Fri, 15 Oct 2021 12:10:49 -0700 Message-ID: Subject: Re: [PATCH] [PATCH V4]ARM64: SCS: Add gcc plugin to support Shadow Call Stack To: Dan Li Cc: masahiroy@kernel.org, michal.lkml@markovi.net, catalin.marinas@arm.com, will@kernel.org, keescook@chromium.org, nathan@kernel.org, tglx@linutronix.de, akpm@linux-foundation.org, samitolvanen@google.com, frederic@kernel.org, rppt@kernel.org, mark.rutland@arm.com, yifeifz2@illinois.edu, rostedt@goodmis.org, viresh.kumar@linaro.org, andreyknvl@gmail.com, colin.king@canonical.com, ojeda@kernel.org, luc.vanoostenryck@gmail.com, elver@google.com, nivedita@alum.mit.edu, ardb@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 11:29 AM Dan Li wrote: > > > > On 10/15/21 2:44 AM, Nick Desaulniers wrote: > > Overall, I'm happy with the patch and am ready to ack it, but I would > > like to see a link to to the upstream GCC feature request for SCS (and > > one created if it doesn't exist) cited explicitly in the commit > > message. I think that would be a good demonstration that this can or > > will be upstreamed into the compiler proper for the compiler vendors > > to maintain, rather than the kernel folks. The compiler vendors may > > have further feedback on the approach, such as my question above > > pertaining to inlining. > > > I have submitted a feature request to the gcc community, and waiting > for a follow-up response. > > Is it fine to add the following description in [PATCH V5]? > > A similar feature request has also been sent to gcc. > link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102768 Yes, and you can include Acked-by: Nick Desaulniers too. -- Thanks, ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2950BC433F5 for ; Fri, 15 Oct 2021 19:12:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E815C60E0C for ; Fri, 15 Oct 2021 19:12:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E815C60E0C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mVSiPHwjCUhmq6bWBuX4OGnqWcQY8Uat+oe6IG2GLkg=; b=N1K3BCNqDc2QHx 10yN8PnLbwY4hYiSzSX1TYt/r0n9Y0qrsXWQU++jSK/7u6MBW7V0B5qCZoT9lbqkHDxusb00umqS3 j8Dp9Lr6/xXII24e3r9/krgAO0T0xNedOjug3MtHuK3jN7c7Mfpu6B2Jz99fNVwwy6ag09cTYAECd pbswRhw1ZC5K7GstF/3IGGYtKTNKofHNyXgHsktT2ODHacP/4d9nDGMKsieb6Q1o31QMaQ0md8mdT u83baU30E5N9aaXrqOGTExoRCEf9A5pLZn3eUaniKx5bZgEINun5+dObdvuP3/dFYwNHJ2m/Hom+F k6TGNdxYcuXhombSs9Lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbSbl-008aNX-5S; Fri, 15 Oct 2021 19:11:09 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbSbg-008aMO-HF for linux-arm-kernel@lists.infradead.org; Fri, 15 Oct 2021 19:11:06 +0000 Received: by mail-lf1-x12e.google.com with SMTP id z11so44390479lfj.4 for ; Fri, 15 Oct 2021 12:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oI0JQpdNcS1rPABaNRpOZ/cT39QBnr4F5JH8mM3KD1w=; b=KItGKghbFy6S8IwlkpEtP4HNbtAfKfSjgliZYr6bPw6mL8dfVSVPPw+Lu6A3D6KYGG JL6+RBOsqVCU63RCfXhpXlk9/+Od7crS2PHmqiaTBP4vaYWJC8bpMmWXSDhfIaJCfV9x KV7yHlxcxqHOZl3G2UPtEQbwkzn4SeJokDnkr5D6uE1SuAkNwE+Os6wBth3CI/ZCjZnJ Fl7nxdD3gZBsmghjKmNQyoN/DtGfjys0qypNRPMsb730as0k1sPUN9PL7I8LoXNold+W oKG8PJms0LcTJcgMvueNQDJMwRWsCmSQyRGJoWkFMc6KF85C5Nc8KvAQE9EebTj1WNR7 yqUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oI0JQpdNcS1rPABaNRpOZ/cT39QBnr4F5JH8mM3KD1w=; b=EGFaCSneZ+Y3fCGppJMoBfjSkuhMme5UnQ9hS1mS2kUtcfuv68THkxRLBFak+sisYL tQs7urdf9H1Cknmx7mC57mjsSjd4LIGoOFPjbILUqIR2c4gtj7L+Qb7Pd96fbF3EGQbG Z6dwX+sffOwBQTsT/uYc5NDSa7qAFeKYn+buFK/jBnag3A85Jv970oClh0CiItgMNzTI RY8qdnlWcg0LkOjbYBnvoEyLnaY95ntdQ24pHU3FNTKpXWQuq9Ol3W98UKT11pObK5sY kHJdyaAOoGuxs1/IY8yPXYB2PtSnSfFczBhidpXrxE+SnJYWxIFfTHD9M6/E2PCWBjOD ywUw== X-Gm-Message-State: AOAM532Qo7L06daFVwnfCFYV23W/F4LnuIrqJXruuFFNVpku/zWos3s0 g3WYcF6W8v+AVl5Kp5E5OxYu030LPze/ZZBvaM7/ww== X-Google-Smtp-Source: ABdhPJxJPbFY1d2ckPhtr+TsSG22LMoybIwYHl50ZAsM2+uDTJMohjuxtsNO4gx/E6FVg7uvt9WPFt5c5aoDLal6yWY= X-Received: by 2002:a05:651c:1108:: with SMTP id d8mr14747364ljo.220.1634325060799; Fri, 15 Oct 2021 12:11:00 -0700 (PDT) MIME-Version: 1.0 References: <1634167668-60198-1-git-send-email-ashimida@linux.alibaba.com> <722d9662-e27c-2efb-e8cf-d505b6950475@linux.alibaba.com> In-Reply-To: <722d9662-e27c-2efb-e8cf-d505b6950475@linux.alibaba.com> From: Nick Desaulniers Date: Fri, 15 Oct 2021 12:10:49 -0700 Message-ID: Subject: Re: [PATCH] [PATCH V4]ARM64: SCS: Add gcc plugin to support Shadow Call Stack To: Dan Li Cc: masahiroy@kernel.org, michal.lkml@markovi.net, catalin.marinas@arm.com, will@kernel.org, keescook@chromium.org, nathan@kernel.org, tglx@linutronix.de, akpm@linux-foundation.org, samitolvanen@google.com, frederic@kernel.org, rppt@kernel.org, mark.rutland@arm.com, yifeifz2@illinois.edu, rostedt@goodmis.org, viresh.kumar@linaro.org, andreyknvl@gmail.com, colin.king@canonical.com, ojeda@kernel.org, luc.vanoostenryck@gmail.com, elver@google.com, nivedita@alum.mit.edu, ardb@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, clang-built-linux@googlegroups.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_121104_597036_5C964695 X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 15, 2021 at 11:29 AM Dan Li wrote: > > > > On 10/15/21 2:44 AM, Nick Desaulniers wrote: > > Overall, I'm happy with the patch and am ready to ack it, but I would > > like to see a link to to the upstream GCC feature request for SCS (and > > one created if it doesn't exist) cited explicitly in the commit > > message. I think that would be a good demonstration that this can or > > will be upstreamed into the compiler proper for the compiler vendors > > to maintain, rather than the kernel folks. The compiler vendors may > > have further feedback on the approach, such as my question above > > pertaining to inlining. > > > I have submitted a feature request to the gcc community, and waiting > for a follow-up response. > > Is it fine to add the following description in [PATCH V5]? > > A similar feature request has also been sent to gcc. > link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102768 Yes, and you can include Acked-by: Nick Desaulniers too. -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel