From: Nick Desaulniers <ndesaulniers@google.com>
To: Nathan Chancellor <nathan@kernel.org>, Jens Axboe <axboe@kernel.dk>
Cc: Jian Cai <jiancai@google.com>, Guenter Roeck <linux@roeck-us.net>,
Christopher Di Bella <cjdb@google.com>,
Manoj Gupta <manojgupta@google.com>,
Luis Lozano <llozano@google.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
linux-block@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk-mq: fix alignment mismatch.
Date: Wed, 31 Mar 2021 15:06:05 -0700 [thread overview]
Message-ID: <CAKwvOdmoud9=Uf2xN7q1c1gP06ZNU4K2-Q5PDD-LTynHC+qOMA@mail.gmail.com> (raw)
In-Reply-To: <20210331215802.r4rp6wynjqutdoup@archlinux-ax161>
On Wed, Mar 31, 2021 at 2:58 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> On Wed, Mar 31, 2021 at 02:27:03PM -0700, Jian Cai wrote:
> >
> > I just realized you already proposed solutions for skipping the check
> > in https://lore.kernel.org/linux-block/20210310225240.4epj2mdmzt4vurr3@archlinux-ax161/#t.
> > Do you have any plans to send them for review?
>
> I was hoping to gather some feedback on which option would be preferred
> by Jens and the other ClangBuiltLinux folks before I sent them along. I
> can send the first just to see what kind of feedback I can gather.
Either approach is fine by me. The smaller might be easier to get
accepted into stable. The larger approach will probably become more
useful in the future (having the diag infra work properly with clang).
I think the ball is kind of in Jens' court to decide. Would doing
both be appropriate, Jens? Have the smaller patch tagged for stable
disabling it for the whole file, then another commit on top not tagged
for stable that adds the diag infra, and a third on top replacing the
file level warning disablement with local diags to isolate this down
to one case? It's a fair but small amount of churn IMO; but if Jens
is not opposed it seems fine?
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2021-03-31 22:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 23:02 [PATCH] blk-mq: fix alignment mismatch Jian Cai
2021-03-30 23:12 ` Guenter Roeck
2021-03-30 23:29 ` Nathan Chancellor
2021-03-31 0:26 ` Guenter Roeck
2021-03-31 1:31 ` Jian Cai
2021-03-31 21:27 ` Jian Cai
2021-03-31 21:58 ` Nathan Chancellor
2021-03-31 22:06 ` Nick Desaulniers [this message]
2021-04-08 17:57 ` Jian Cai
2021-04-08 18:12 ` Nathan Chancellor
2021-04-08 18:42 ` Jian Cai
2021-04-08 19:44 ` [PATCH] block: Disable -Walign-mismatch for blk-mq.c Nathan Chancellor
2021-04-08 19:52 ` Guenter Roeck
2021-03-31 10:38 ` [PATCH] blk-mq: fix alignment mismatch David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdmoud9=Uf2xN7q1c1gP06ZNU4K2-Q5PDD-LTynHC+qOMA@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=axboe@kernel.dk \
--cc=cjdb@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=jiancai@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=llozano@google.com \
--cc=manojgupta@google.com \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.