From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CD4C7EE2F for ; Wed, 1 Mar 2023 17:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbjCARus (ORCPT ); Wed, 1 Mar 2023 12:50:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229718AbjCARur (ORCPT ); Wed, 1 Mar 2023 12:50:47 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57E773D939 for ; Wed, 1 Mar 2023 09:50:43 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id d6so8233246pgu.2 for ; Wed, 01 Mar 2023 09:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677693043; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DpL6DwFkyuaEtEvh0ArhxR/cUeifrKQ0QYmfCAMdbVU=; b=lagi4xfM5lhItTQDuRxproJWvwcvRV2ufiYbfodtWrckZ9+0sW1ahRDIVSF1/ru37a iHjqSfwo67gCHwutTwpxMZqhFvMGxAHTEhw6mb6VL0iuZes7SSdXJRb7kt9/jU5Rjn/k 7dPOZx7m8j2Z+rUdxYZfd2BB3F0T/G/6qn5xLtGLK3JyBD7nj85IMMOQGMRiDBz3fCvS 8rpnjHLfybMAgEC0FVsBNE0YPItotziNHYW4dTwBLVy7wVjWGwTd6s0tBZeu7i1WwynB t6HgD+TNCzshFzJI6hyIbTjAJveFkmeHYGT0L46AP7u+zvz1rI93vWkmEWOkMUrSO/Ke 8CWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677693043; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DpL6DwFkyuaEtEvh0ArhxR/cUeifrKQ0QYmfCAMdbVU=; b=f5T7JO9XX8dW/a+yJ5rAe00b4DA8GW0KsXwXwHzFM1XmFup9HeZd1I3id5BkQw01Qq 0V3AxennAYJYrnW0NTNABE/jrAhdbWqo+q6fefEI9KLx+D3JKy6b6cMBQxGfg8QbTnmu wLv4qsk9rK0YbtwP2TwpCcWLcwjQTrq+gsKO+8m83CSqLg/juTGwdEq065YDP0705wvi PTMIGntAswqDlEDRvm/rIrLy2oxI4yS6FpXMkaUoBnAmR23cy//9XzEp3/7mir5i04Th t0wzHp/elkjw9zY1vwayqDAyBYpJxXTN5N/JNdskqmd7XW8HSApujKV14SEErxr3Jxax dG3g== X-Gm-Message-State: AO0yUKWcrc/NfTksDyotIdQq09Dgzsq8xPLmJxglivt9mVg058pBx49O LiICBteB0ZPSEBScugPNCIFTmNY5uEvT4o6IZkW1ew== X-Google-Smtp-Source: AK7set+sa5Lpwqw5kyGG4/qPXxMgWH2tZf+nBVEHopmtPWoZRNrFsf1qn2TKiNLI7IHyHoSIS55/eR0Qis04PyU96jg= X-Received: by 2002:a63:8c1d:0:b0:503:354c:41ad with SMTP id m29-20020a638c1d000000b00503354c41admr2372184pgd.11.1677693042346; Wed, 01 Mar 2023 09:50:42 -0800 (PST) MIME-Version: 1.0 References: <20230301075402.4578-1-quic_johmoo@quicinc.com> In-Reply-To: <20230301075402.4578-1-quic_johmoo@quicinc.com> From: Nick Desaulniers Date: Wed, 1 Mar 2023 09:50:30 -0800 Message-ID: Subject: Re: [PATCH v2 0/2] Validating UAPI backwards compatibility To: John Moon Cc: Masahiro Yamada , Nathan Chancellor , Nicolas Schier , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Greg Kroah-Hartman , Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , kernel-team@android.com, libabigail@sourceware.org, Jordan Crouse , Trilok Soni , Satya Durga Srinivasu Prabhala , Elliot Berman Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Feb 28, 2023 at 11:54=E2=80=AFPM John Moon wrote: > > Currently, the script works with gcc. It generates output like this when > a backwards-incompatible change is made to a UAPI header: > > !!! ABI differences detected in include/uapi/linux/acct.h (compared to > file at HEAD^1) !!! > > [C] 'struct acct' changed: > type size changed from 512 to 544 (in bits) > 1 data member insertion: > '__u32 new_val', at offset 512 (in bits) at acct.h:71:1 > > 0/1 UAPI header file changes are backwards compatible > UAPI header ABI check failed > > However, we have not had success with clang. It seems clang is more > aggressive in optimizing dead code away (no matter which options we > pass). Therefore, no ABI differences are found. Hi John, Do you have the list of bugs you've filed upstream against clang wrt. information missing when using `-fno-eliminate-unused-debug-types`? https://github.com/llvm/llvm-project/issues is the issue tracker. Seeing a strong participant in both the Android and LLVM ecosystems supply scripts that lack clang support...raises eyebrows. --=20 Thanks, ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D4FBC6FA9D for ; Wed, 1 Mar 2023 17:51:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4U4IcQkY2iFVNUo31KNjMXfkzZIlk0HeNuKfh1BF9sI=; b=FwqRCOMCREhoF4 f/nH5YsCD7pKttUH5YaTmXhdQPPRNfBlnOFerws+tuSub9C8WHTi88hlig6zmgL0+QFZwRRon3V2H RltA7AONupkeO2QtuUIPuXFyqZH+51ypIx/1dcQYW2ovXBWfjTo50eLSwqI9OcE5a9ERmsH/vkQGh WXjamqo1S9jKX5u2reNzeWeq6luyjxGc0h9tnkTCrWnvPwuv4sfLpMzogkexmDH0h+iNB62Lyg7vn ftO8LOd8Fdz3OCIYP4LER6DJz/97ifqfulO/0zFJ4iZ03dGiIeyDspnaOlFmGxnoH12MTMya/5WfE 9Tux45jt2pqy6lp10eEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXQbL-00H0ci-1P; Wed, 01 Mar 2023 17:50:51 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXQbH-00H0bU-3S for linux-arm-kernel@lists.infradead.org; Wed, 01 Mar 2023 17:50:48 +0000 Received: by mail-pf1-x42c.google.com with SMTP id c4so5571460pfl.0 for ; Wed, 01 Mar 2023 09:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677693043; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DpL6DwFkyuaEtEvh0ArhxR/cUeifrKQ0QYmfCAMdbVU=; b=lagi4xfM5lhItTQDuRxproJWvwcvRV2ufiYbfodtWrckZ9+0sW1ahRDIVSF1/ru37a iHjqSfwo67gCHwutTwpxMZqhFvMGxAHTEhw6mb6VL0iuZes7SSdXJRb7kt9/jU5Rjn/k 7dPOZx7m8j2Z+rUdxYZfd2BB3F0T/G/6qn5xLtGLK3JyBD7nj85IMMOQGMRiDBz3fCvS 8rpnjHLfybMAgEC0FVsBNE0YPItotziNHYW4dTwBLVy7wVjWGwTd6s0tBZeu7i1WwynB t6HgD+TNCzshFzJI6hyIbTjAJveFkmeHYGT0L46AP7u+zvz1rI93vWkmEWOkMUrSO/Ke 8CWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677693043; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DpL6DwFkyuaEtEvh0ArhxR/cUeifrKQ0QYmfCAMdbVU=; b=WzsXQtamn8v6BNSEXHDssvUAu/TX2/dy2mZuCYNBYzWyRh2RUK/khuKPtbTNRFumvt AbEvXuBh0lH/zL171qLz+CPF2egLRcX0aTsdWfrvhzROfD+by+ynp9YhDX2G0D47wVHt 8id8jKp7/4mNKpqiim7PfCxcqkVAL07Zg62w0GZ7b+jYmxDSxYz9JE92VpskgQq4XqgP JbA/MX83mNamcfynyoFkmjNCHLlRDFlQwhM+ky9K6LEY1PeZpgwwW56DarpCy7/qaaB9 ld+EJzQ9+/5LpvNC7MWcgpO0Yjci3H7IczRseLh7mnr11o4YpP98BvU3mx5ufyrjQnB2 Z9Ag== X-Gm-Message-State: AO0yUKUTwrx2qPWbNPjlfpaCZKWh2K7fyPwVIBuoxUlYO2lrvnnyJ/B4 7R4eOLzUKLDe/C1IcgMQn3idyhXpbwgptx1hKOrg4A== X-Google-Smtp-Source: AK7set+sa5Lpwqw5kyGG4/qPXxMgWH2tZf+nBVEHopmtPWoZRNrFsf1qn2TKiNLI7IHyHoSIS55/eR0Qis04PyU96jg= X-Received: by 2002:a63:8c1d:0:b0:503:354c:41ad with SMTP id m29-20020a638c1d000000b00503354c41admr2372184pgd.11.1677693042346; Wed, 01 Mar 2023 09:50:42 -0800 (PST) MIME-Version: 1.0 References: <20230301075402.4578-1-quic_johmoo@quicinc.com> In-Reply-To: <20230301075402.4578-1-quic_johmoo@quicinc.com> From: Nick Desaulniers Date: Wed, 1 Mar 2023 09:50:30 -0800 Message-ID: Subject: Re: [PATCH v2 0/2] Validating UAPI backwards compatibility To: John Moon Cc: Masahiro Yamada , Nathan Chancellor , Nicolas Schier , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Greg Kroah-Hartman , Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , kernel-team@android.com, libabigail@sourceware.org, Jordan Crouse , Trilok Soni , Satya Durga Srinivasu Prabhala , Elliot Berman X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230301_095047_224085_D7C9CF26 X-CRM114-Status: GOOD ( 13.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBGZWIgMjgsIDIwMjMgYXQgMTE6NTTigK9QTSBKb2huIE1vb24gPHF1aWNfam9obW9v QHF1aWNpbmMuY29tPiB3cm90ZToKPgo+IEN1cnJlbnRseSwgdGhlIHNjcmlwdCB3b3JrcyB3aXRo IGdjYy4gSXQgZ2VuZXJhdGVzIG91dHB1dCBsaWtlIHRoaXMgd2hlbgo+IGEgYmFja3dhcmRzLWlu Y29tcGF0aWJsZSBjaGFuZ2UgaXMgbWFkZSB0byBhIFVBUEkgaGVhZGVyOgo+Cj4gICEhISBBQkkg ZGlmZmVyZW5jZXMgZGV0ZWN0ZWQgaW4gaW5jbHVkZS91YXBpL2xpbnV4L2FjY3QuaCAoY29tcGFy ZWQgdG8KPiAgZmlsZSBhdCBIRUFEXjEpICEhIQo+Cj4gICAgICBbQ10gJ3N0cnVjdCBhY2N0JyBj aGFuZ2VkOgo+ICAgICAgICB0eXBlIHNpemUgY2hhbmdlZCBmcm9tIDUxMiB0byA1NDQgKGluIGJp dHMpCj4gICAgICAgIDEgZGF0YSBtZW1iZXIgaW5zZXJ0aW9uOgo+ICAgICAgICAgICdfX3UzMiBu ZXdfdmFsJywgYXQgb2Zmc2V0IDUxMiAoaW4gYml0cykgYXQgYWNjdC5oOjcxOjEKPgo+ICAwLzEg VUFQSSBoZWFkZXIgZmlsZSBjaGFuZ2VzIGFyZSBiYWNrd2FyZHMgY29tcGF0aWJsZQo+ICBVQVBJ IGhlYWRlciBBQkkgY2hlY2sgZmFpbGVkCj4KPiBIb3dldmVyLCB3ZSBoYXZlIG5vdCBoYWQgc3Vj Y2VzcyB3aXRoIGNsYW5nLiBJdCBzZWVtcyBjbGFuZyBpcyBtb3JlCj4gYWdncmVzc2l2ZSBpbiBv cHRpbWl6aW5nIGRlYWQgY29kZSBhd2F5IChubyBtYXR0ZXIgd2hpY2ggb3B0aW9ucyB3ZQo+IHBh c3MpLiBUaGVyZWZvcmUsIG5vIEFCSSBkaWZmZXJlbmNlcyBhcmUgZm91bmQuCgpIaSBKb2huLApE byB5b3UgaGF2ZSB0aGUgbGlzdCBvZiBidWdzIHlvdSd2ZSBmaWxlZCB1cHN0cmVhbSBhZ2FpbnN0 IGNsYW5nIHdydC4KaW5mb3JtYXRpb24gbWlzc2luZyB3aGVuIHVzaW5nIGAtZm5vLWVsaW1pbmF0 ZS11bnVzZWQtZGVidWctdHlwZXNgPwoKaHR0cHM6Ly9naXRodWIuY29tL2xsdm0vbGx2bS1wcm9q ZWN0L2lzc3VlcyBpcyB0aGUgaXNzdWUgdHJhY2tlci4KClNlZWluZyBhIHN0cm9uZyBwYXJ0aWNp cGFudCBpbiBib3RoIHRoZSBBbmRyb2lkIGFuZCBMTFZNIGVjb3N5c3RlbXMKc3VwcGx5IHNjcmlw dHMgdGhhdCBsYWNrIGNsYW5nIHN1cHBvcnQuLi5yYWlzZXMgZXllYnJvd3MuCi0tIApUaGFua3Ms Cn5OaWNrIERlc2F1bG5pZXJzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==