All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag
Date: Tue, 2 Mar 2021 14:33:38 -0800	[thread overview]
Message-ID: <CAKwvOdn42+2bFOMvJpJUuvmM1cj3V6uNEJWfwBWCRFMXtvQfcA@mail.gmail.com> (raw)
In-Reply-To: <20210302210646.3044738-1-nathan@kernel.org>

On Tue, Mar 2, 2021 at 1:07 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> This is not necessary anymore now that we specify '--prefix=', which
> tells clang exactly where to find the GNU cross tools. This has been
> verified with self compiled LLVM 10.0.1 and LLVM 13.0.0 as well as a
> distribution version of LLVM 11.1.0 without binutils in the LLVM
> toolchain locations.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>

I see this pattern still being used in
arch/arm64/kernel/vdso32/Makefile, but that can be separate cleanups.

> ---
>  Makefile | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index f9b54da2fca0..c20f0ad8be73 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -568,10 +568,6 @@ ifneq ($(CROSS_COMPILE),)
>  CLANG_FLAGS    += --target=$(notdir $(CROSS_COMPILE:%-=%))
>  GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE)elfedit))
>  CLANG_FLAGS    += --prefix=$(GCC_TOOLCHAIN_DIR)$(notdir $(CROSS_COMPILE))
> -GCC_TOOLCHAIN  := $(realpath $(GCC_TOOLCHAIN_DIR)/..)
> -endif
> -ifneq ($(GCC_TOOLCHAIN),)
> -CLANG_FLAGS    += --gcc-toolchain=$(GCC_TOOLCHAIN)
>  endif
>  ifneq ($(LLVM_IAS),1)
>  CLANG_FLAGS    += -no-integrated-as
>
> base-commit: 7a7fd0de4a9804299793e564a555a49c1fc924cb
> --
> 2.31.0.rc0.75.gec125d1bc1
>


-- 
Thanks,
~Nick Desaulniers

  parent reply	other threads:[~2021-03-02 23:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 21:06 [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag Nathan Chancellor
2021-03-02 21:06 ` [PATCH 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as Nathan Chancellor
2021-03-02 22:02   ` Fangrui Song
2021-03-02 22:09     ` Nick Desaulniers
2021-03-02 22:40       ` Nick Desaulniers
2021-03-09 19:55   ` Masahiro Yamada
2021-03-09 19:58     ` Masahiro Yamada
2021-09-29 17:26   ` kernel test robot
2021-09-29 17:26     ` kernel test robot
2021-09-29 19:32   ` kernel test robot
2021-09-29 19:32     ` kernel test robot
2021-03-02 21:43 ` [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag Fangrui Song
2021-03-03  8:33   ` Masahiro Yamada
2021-03-02 22:33 ` Nick Desaulniers [this message]
2021-03-03  3:25 ` Sedat Dilek
2021-03-03 14:22   ` Sedat Dilek
2021-03-09 20:59 ` [PATCH v2 " Nathan Chancellor
2021-03-09 20:59   ` [PATCH v2 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as Nathan Chancellor
2021-03-09 21:15   ` [PATCH v2 1/2] Makefile: Remove '--gcc-toolchain' flag Fangrui Song
2021-03-15 16:21   ` Masahiro Yamada
2021-03-15 16:41     ` Sedat Dilek
2021-03-16 15:36       ` Masahiro Yamada
2021-03-03 23:07 [PATCH " Fangrui Song
2021-03-04 19:11 ` Fāng-ruì Sòng
2021-03-08 13:59 ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKwvOdn42+2bFOMvJpJUuvmM1cj3V6uNEJWfwBWCRFMXtvQfcA@mail.gmail.com \
    --to=ndesaulniers@google.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nathan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.