From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85445C433F5 for ; Wed, 6 Apr 2022 02:07:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1846235AbiDFCD0 (ORCPT ); Tue, 5 Apr 2022 22:03:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1457641AbiDEQX4 (ORCPT ); Tue, 5 Apr 2022 12:23:56 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDA1E9AE40 for ; Tue, 5 Apr 2022 09:21:56 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id b43so17752026ljr.10 for ; Tue, 05 Apr 2022 09:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vp1rKhW9xVfHaAk1bIcVHB9UucHbWp+Gn42oU0LRglU=; b=ggFQtYxL98uH1FVRJXq9oNgXvUh7G5864YICyxdISp6UW19aXb07z9VuR5PMLBY9J7 1ui4V2QkWdkQ8b+SvbpnoVGwCd1Xm02G2YDLHM6A4pqxne0L5WoMoFMYuZgLcRqLJjkC uKq28daKE3d0BLTdAnyJv5iAaRu+NZxP204AOOf+LazUkzaZw+bEcHptjluNHTEJ+2NS su+sVW++A74Gk3/Yxi+n1rFG80u7M/hcS4c9qCh+3iguKOYC7ufS0mmLaXLHxq4XsL8B 44aqeMZIWPQhhm1dPwhh1WyO8HMOfWgERO26dW/LEqO5oepBnpNLwGozUUlZu05Xo5Sm V/PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vp1rKhW9xVfHaAk1bIcVHB9UucHbWp+Gn42oU0LRglU=; b=66WsbSsHml4DNKl7BOlj27KABQS9ip9t4tP5W4AwXzdGX2ghkY2jj+S6iTh2XT5IJE VDywnzBUH1wU0S7D9n3JKfMOlAURS/B40ITUd087RSX2g1HqmpYn1iWZX9FsxxO+yfzc X0D/MaPyy8PzTkOkN+RQkZfOPokOVLtS0Q3VHQIb1sp0JqnL0Jl0LVa25NKDOW7Tq0uL +b0ub9YbEhou0gihPjthv0IfqYZ5kYUYBsaAXsg11+GdWidJ33cGM9NJMAnWl2yLw+gZ ae+BXZWG/aOtIZAUrcedYveEUshIYC/5Uw5vi0U+IgvhmJMRPRE5EOjlfQ/ysGLe1XeV qDhQ== X-Gm-Message-State: AOAM530lkYtY7Baia9dJCKMPANqcsg2fnZfSxDyHSFLdj5RdXuVwKU+X I3/COZTZnnGZCTOWBfGenXVyHhUpQSB3S+sOKuHG4g== X-Google-Smtp-Source: ABdhPJyrxb/EGFbBM6TVvfBKSHKHKzPwAFDSG4hhB1aZNQj7iew86HRktdhcL2l9aehOjQKObYiAlmHTMTw1SQCBzbw= X-Received: by 2002:a2e:611a:0:b0:249:83e5:9f9b with SMTP id v26-20020a2e611a000000b0024983e59f9bmr2738675ljb.165.1649175713574; Tue, 05 Apr 2022 09:21:53 -0700 (PDT) MIME-Version: 1.0 References: <20220405113359.2880241-1-masahiroy@kernel.org> <20220405113359.2880241-6-masahiroy@kernel.org> In-Reply-To: <20220405113359.2880241-6-masahiroy@kernel.org> From: Nick Desaulniers Date: Tue, 5 Apr 2022 09:21:42 -0700 Message-ID: Subject: Re: [PATCH v2 05/10] modpost: remove redundant initializes for static variables To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Marek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 5, 2022 at 4:34 AM Masahiro Yamada wrote: > > These are initialized with zeros without explicit initializes. s/initializes/initializers/ Thanks for the patch! Reviewed-by: Nick Desaulniers > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: > - New > > scripts/mod/modpost.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index f9e54247ae1d..2a202764ff48 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -23,15 +23,15 @@ > #include "../../include/linux/license.h" > > /* Are we using CONFIG_MODVERSIONS? */ > -static int modversions = 0; > +static int modversions; > /* Is CONFIG_MODULE_SRCVERSION_ALL set? */ > -static int all_versions = 0; > +static int all_versions; > /* If we are modposting external module set to 1 */ > -static int external_module = 0; > +static int external_module; > /* Only warn about unresolved symbols */ > -static int warn_unresolved = 0; > +static int warn_unresolved; > /* How a symbol is exported */ > -static int sec_mismatch_count = 0; > +static int sec_mismatch_count; > static int sec_mismatch_warn_only = true; > /* ignore missing files */ > static int ignore_missing_files; > -- > 2.32.0 > -- Thanks, ~Nick Desaulniers