Re: [PATCH v3 3/4] regulator: mpq7920: add mpq7920 regulator driver

[Nick Desaulniers <ndesaulniers@google.com>]

[-- Attachment #1: Type: text/plain, Size: 3670 bytes --]

Hi Saravanan, can you please take a look at the below report?

On Tue, Dec 24, 2019 at 3:38 PM kbuild test robot <lkp@intel.com> wrote:
>
> CC: kbuild-all(a)lists.01.org
> In-Reply-To: <20191222204507.32413-4-sravanhome@gmail.com>
> References: <20191222204507.32413-4-sravanhome@gmail.com>
> TO: Saravanan Sekar <sravanhome@gmail.com>
> CC: sravanhome(a)gmail.com, lgirdwood(a)gmail.com, broonie(a)kernel.org, robh+dt(a)kernel.org, mark.rutland(a)arm.com, mripard(a)kernel.org, shawnguo(a)kernel.org, heiko(a)sntech.de, sam(a)ravnborg.org, icenowy(a)aosc.io, laurent.pinchart(a)ideasonboard.com, gregkh(a)linuxfoundation.org, Jonathan.Cameron(a)huawei.com, davem(a)davemloft.net, mchehab+samsung(a)kernel.org
> CC: devicetree(a)vger.kernel.org, linux-kernel(a)vger.kernel.org
>
> Hi Saravanan,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on regulator/for-next]
> [also build test ERROR on robh/for-next linus/master v5.5-rc3 next-20191220]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url:    https://github.com/0day-ci/linux/commits/Saravanan-Sekar/Add-regulator-support-for-mpq7920/20191225-005026
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
> config: x86_64-allyesconfig (attached as .config)
> compiler: clang version 10.0.0 (git://gitmirror/llvm_project e5a743c4f6e3639ba3bee778c894a996ef96391a)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> >> drivers/regulator/mpq7920.c:317:7: error: assigning to 'struct regulator_ops *' from 'const struct regulator_ops *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>                    ops = rdesc->ops;
>                        ^ ~~~~~~~~~~
>    1 error generated.
>
> vim +317 drivers/regulator/mpq7920.c
>
>    306
>    307  static inline int mpq7920_regulator_register(
>    308                                  struct mpq7920_regulator_info *info,
>    309                                  struct regulator_config *config)
>    310  {
>    311          int i;
>    312          struct regulator_desc *rdesc;
>    313          struct regulator_ops *ops;
>    314
>    315          for (i = 0; i < MPQ7920_MAX_REGULATORS; i++) {
>    316                  rdesc = &info->rdesc[i];
>  > 317                  ops = rdesc->ops;
>    318                  if (rdesc->curr_table) {
>    319                          ops->get_current_limit =
>    320                                  regulator_get_current_limit_regmap;
>    321                          ops->set_current_limit =
>    322                                  regulator_set_current_limit_regmap;
>    323                  }
>    324
>    325                  info->rdev[i] = devm_regulator_register(info->dev, rdesc,
>    326                                           config);
>    327                  if (IS_ERR(info->rdev))
>    328                          return PTR_ERR(info->rdev);
>    329          }
>    330
>    331          return 0;
>    332  }
>    333
>
> ---
> 0-DAY kernel test infrastructure                 Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation



-- 
Thanks,
~Nick Desaulniers