From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE3CBC4167D for ; Tue, 5 Apr 2022 22:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391424AbiDEWF2 (ORCPT ); Tue, 5 Apr 2022 18:05:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1457622AbiDEQSa (ORCPT ); Tue, 5 Apr 2022 12:18:30 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3497819C0F for ; Tue, 5 Apr 2022 09:16:31 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id t25so24104443lfg.7 for ; Tue, 05 Apr 2022 09:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Uy8i40RIZFVV64urUf42bHyfQVf4Q/JqjVb+pMMetgg=; b=VEZUGGgcS/bCf+7bs3tHZb8+OMlT5unqdhNUgKPFfUrzmUWPzwkPflleyRfNc9Gszb Zvp51L5ajuECgaMz1MXPXAXCzpd+r7XgMLjc0WwZUqmG6YkOW8zjrrmE+M6NRQcmJWuO Y0fH0pb8byrF6pULERlph+UgHZwh1mkS4uFnJ4VLQVddcyXp54KZF/gQUNfoGi+CLUv5 mS5mky+6cLoMPbbvLH9DILjT2TrafcmZcPrfQVcEzGZ47/o/q3O5NsqGbBMbE0V/AgPW oBBJDvv82i/EGVLu1pU55SOGOo1TrCbFYInzxzprvbxO/U2/r7StZYuNCf32nr453634 fBJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Uy8i40RIZFVV64urUf42bHyfQVf4Q/JqjVb+pMMetgg=; b=FEpFutEmyDIAtnGJacWSciHZyPMvFaXPKBKFefP05u8fR3C4wTWwoiWfk5ap6ZJGHe zWNuOoRaJ44cyPJilEu2ei0kxqWGQI+Y9hMR5+ugiwxBrD/KjwYVWtD0ZGUzteq2iLVf J/Wx8ihaKTXrM+wJ8cXi0yZW5pYB+REIJwtvESHJ3QDc6tNRG+/8iPJJIwXAC8YEQowg FAjf+MlqqCOM5QoKUomd6n12nLEvyIoecaaOxvsDdFoZNQY6ZpuFLo9/q2sRMjzq+g1W VA8qp5ggIAwucndRrMdE8kqqcOu3HECurz0vU+MkxQr67haZREdPe5OlWpNA16t9NmlY jKQA== X-Gm-Message-State: AOAM530WyiEjg0WxeuDwWSSFbeoYZbm10fWlzIo+wgYM4V3GvIM+gXUU Nm/JNjEEfnHgIC79mjZ3Rtkwc+NnNhyJ2+92r6PJ1KdWDZZKxw== X-Google-Smtp-Source: ABdhPJyczCamPzZ+WireWxW4CQXH7k2Pos0Q5thRcGyasYMnxW8whHvGnEWwMVjDvTFTyp15EDL3Em9/iSDdkwnlAHg= X-Received: by 2002:a05:6512:b9e:b0:44a:10eb:9607 with SMTP id b30-20020a0565120b9e00b0044a10eb9607mr3071054lfv.626.1649175385326; Tue, 05 Apr 2022 09:16:25 -0700 (PDT) MIME-Version: 1.0 References: <20220405113359.2880241-1-masahiroy@kernel.org> <20220405113359.2880241-2-masahiroy@kernel.org> In-Reply-To: <20220405113359.2880241-2-masahiroy@kernel.org> From: Nick Desaulniers Date: Tue, 5 Apr 2022 09:16:13 -0700 Message-ID: Subject: Re: [PATCH v2 01/10] kbuild: factor out genksyms command from cmd_gensymtypes_{c,S} To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Marek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 5, 2022 at 4:34 AM Masahiro Yamada wrote: > > The genksyms command part in cmd_gensymtypes_{c,S} is duplicated. > Factor it out into the 'genksyms' macro. > > For the readability, I slightly refactor the arguments to genksyms. > > Signed-off-by: Masahiro Yamada It looks like you may have sent v2 twice; apologies if I comment on BOTH threads rather than 1. Reviewed-by: Nick Desaulniers > --- > > Changes in v2: > - Fix the location of the closing parenthesis > > scripts/Makefile.build | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index 9717e6f6fb31..31e0e33dfe5d 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -125,13 +125,14 @@ cmd_cpp_i_c = $(CPP) $(c_flags) -o $@ $< > $(obj)/%.i: $(src)/%.c FORCE > $(call if_changed_dep,cpp_i_c) > > +genksyms = scripts/genksyms/genksyms \ > + $(if $(1), -T $(2)) \ > + $(if $(CONFIG_MODULE_REL_CRCS), -R) \ > + $(if $(KBUILD_PRESERVE), -p) \ > + -r $(or $(wildcard $(2:.symtypes=.symref)), /dev/null) > + > # These mirror gensymtypes_S and co below, keep them in synch. > -cmd_gensymtypes_c = \ > - $(CPP) -D__GENKSYMS__ $(c_flags) $< | \ > - scripts/genksyms/genksyms $(if $(1), -T $(2)) \ > - $(patsubst y,-R,$(CONFIG_MODULE_REL_CRCS)) \ > - $(if $(KBUILD_PRESERVE),-p) \ > - -r $(firstword $(wildcard $(2:.symtypes=.symref) /dev/null)) > +cmd_gensymtypes_c = $(CPP) -D__GENKSYMS__ $(c_flags) $< | $(genksyms) > > quiet_cmd_cc_symtypes_c = SYM $(quiet_modtag) $@ > cmd_cc_symtypes_c = \ > @@ -344,11 +345,7 @@ cmd_gensymtypes_S = \ > $(CPP) $(a_flags) $< | \ > grep "\<___EXPORT_SYMBOL\>" | \ > sed 's/.*___EXPORT_SYMBOL[[:space:]]*\([a-zA-Z0-9_]*\)[[:space:]]*,.*/EXPORT_SYMBOL(\1);/' ; } | \ > - $(CPP) -D__GENKSYMS__ $(c_flags) -xc - | \ > - scripts/genksyms/genksyms $(if $(1), -T $(2)) \ > - $(patsubst y,-R,$(CONFIG_MODULE_REL_CRCS)) \ > - $(if $(KBUILD_PRESERVE),-p) \ > - -r $(firstword $(wildcard $(2:.symtypes=.symref) /dev/null)) > + $(CPP) -D__GENKSYMS__ $(c_flags) -xc - | $(genksyms) > > quiet_cmd_cc_symtypes_S = SYM $(quiet_modtag) $@ > cmd_cc_symtypes_S = \ > -- > 2.32.0 > -- Thanks, ~Nick Desaulniers