From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4787BC433F5 for ; Tue, 26 Apr 2022 17:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244653AbiDZRUA (ORCPT ); Tue, 26 Apr 2022 13:20:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353656AbiDZRRn (ORCPT ); Tue, 26 Apr 2022 13:17:43 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7E8341FBA for ; Tue, 26 Apr 2022 10:14:34 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id m23so12023396ljc.0 for ; Tue, 26 Apr 2022 10:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ni6LS4WRIid4Cj4AB+HeVRc/u0ggtCmwJRNEkXzGU0I=; b=ncIGWjTDHznLp1yaKK/3x12wlf+QAclDOEjA52ORLaxlKBeCHZW9cjSMYZ+YC0HVqq 5tFYMu1EmGmsWKDv+1+pwPYT0l7ntgZDDJOvewG2Rs63vt2qgZf6ymkgdXlvntUS4peG ESfR0UAOaevXCBHid5FA75S7wCs9FCTVL5mXrsBoLYpGPZGQ2Qo+JVDomIfOvmBET0Z6 eU6M9oaf76fWtZTNNoREWE/4BY2Jbiu5k+MMo3VPXrvgn8DrLHpb1MT9qWDU+w2DjN32 dLg98Ve0mCp+NDrA5w/rO4d0YkuMQDBQOKDL7CfHgDNGZmcUXlQ1Y6PnQR4dwAs+0AR2 odZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ni6LS4WRIid4Cj4AB+HeVRc/u0ggtCmwJRNEkXzGU0I=; b=8KPKArPWESpVdG/jqwErTIdhmdYG6ONmzt1xxAP+2tUMLQTZwQimGBgvC73IrfIW/C BAypvy5uUyHt5OZXCA7noGqnsC+iH3OA8D2hYU5O2HsewvS1JhpAirYwbH63iXO4QUG8 4rR2VE4w3/mgbgzzTdqBNSF1DTW6hNrLGPQcK+FBZ1S4lfkcCIxNI8pzHysdc6vBM0iu FE6OupZMAmDF6arOTD3lRy77hPYcrqq/yaT7XnhPl8SAtKB4HDCbawau/S3hNuL/X8su J3nSyHZrZvS3xqfmnWhUU6h0DF7uBEjKx0XMPdcBF+YCBn73NEL3rpWAGtoToXn0520e 7QLQ== X-Gm-Message-State: AOAM532cgxf4FpMYPO7mCi7w6lm9EuC+OQy+CNSQ5qM+xTWhrszxCcg2 aYCba8RjhxGT9DWl48+g/Wl5rJ31WjruYvigUIIvmHQp9xg= X-Google-Smtp-Source: ABdhPJyc8q71y0xMH3JeQT82JcezC7bQ0ByCO3FEz0CmsKkUJGUv/k0zGXyoz3eO4nNBBQRSoOkhEIsR93tEsNyC5Ro= X-Received: by 2002:a2e:91cf:0:b0:24f:11ea:d493 with SMTP id u15-20020a2e91cf000000b0024f11ead493mr6834233ljg.408.1650993272973; Tue, 26 Apr 2022 10:14:32 -0700 (PDT) MIME-Version: 1.0 References: <20220424190811.1678416-1-masahiroy@kernel.org> <20220424190811.1678416-12-masahiroy@kernel.org> In-Reply-To: <20220424190811.1678416-12-masahiroy@kernel.org> From: Nick Desaulniers Date: Tue, 26 Apr 2022 10:14:20 -0700 Message-ID: Subject: Re: [PATCH 11/27] modpost: use doubly linked list for dump_lists To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Marek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 24, 2022 at 12:09 PM Masahiro Yamada wrote: > > This looks easier to understand (just because this is a pattern in > the kernel code). No functional change is intended. > > Signed-off-by: Masahiro Yamada > --- > > scripts/mod/modpost.c | 24 ++++++++++-------------- > 1 file changed, 10 insertions(+), 14 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index e1eb188d6282..4c074d6c1721 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -2496,7 +2496,7 @@ static void write_namespace_deps_files(const char *fname) > } > > struct dump_list { > - struct dump_list *next; > + struct list_head list; > const char *file; > }; > > @@ -2508,8 +2508,8 @@ int main(int argc, char **argv) > char *dump_write = NULL, *files_source = NULL; > int opt; > int n; > - struct dump_list *dump_read_start = NULL; > - struct dump_list **dump_read_iter = &dump_read_start; > + LIST_HEAD(dump_lists); > + struct dump_list *dl, *dl2; > > while ((opt = getopt(argc, argv, "ei:mnT:o:awENd:")) != -1) { > switch (opt) { > @@ -2517,10 +2517,9 @@ int main(int argc, char **argv) > external_module = true; > break; > case 'i': > - *dump_read_iter = > - NOFAIL(calloc(1, sizeof(**dump_read_iter))); > - (*dump_read_iter)->file = optarg; > - dump_read_iter = &(*dump_read_iter)->next; > + dl = NOFAIL(malloc(sizeof(*dl))); > + dl->file = optarg; > + list_add_tail(&dl->list, &dump_lists); Consider NULL'ing out dl since you reuse its storage below. Either way Reviewed-by: Nick Desaulniers > break; > case 'm': > modversions = true; > @@ -2554,13 +2553,10 @@ int main(int argc, char **argv) > } > } > > - while (dump_read_start) { > - struct dump_list *tmp; > - > - read_dump(dump_read_start->file); > - tmp = dump_read_start->next; > - free(dump_read_start); > - dump_read_start = tmp; > + list_for_each_entry_safe(dl, dl2, &dump_lists, list) { > + read_dump(dl->file); > + list_del(&dl->list); > + free(dl); > } > > while (optind < argc) > -- > 2.32.0 > -- Thanks, ~Nick Desaulniers