From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DFD8C433DF for ; Mon, 29 Jun 2020 20:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A4CC2067D for ; Mon, 29 Jun 2020 20:29:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eQJ4C1Og" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389044AbgF2U3x (ORCPT ); Mon, 29 Jun 2020 16:29:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387905AbgF2U3u (ORCPT ); Mon, 29 Jun 2020 16:29:50 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FCDFC03E97A for ; Mon, 29 Jun 2020 13:29:50 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id u185so6350138pfu.1 for ; Mon, 29 Jun 2020 13:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1nXbjmGuO9YghPzUiSigrzs5/9GT5Q6NNhUBnZ5BL6o=; b=eQJ4C1Og5DxGMyP8fWLcdR8Z3CwksZFnIGnuQop7YqAIDkKSYG4ONb22hCetVI2dMa XlTHs1YnKZwKbNTsc1vYgLQApn6CEsy11cVvAH0W8MA9tpog/jILDFawLHvAbnz6wbLc MOr/DpyFN5amUZuAcTF6xCkw3l5ZA5IZ2aVkLt4pQ4hbAulAODM2O4kjrlBTBDFdFrsk HN+QhWO3ClmIpA86xpuWF6l/Rt/cKlJGag5/A6V0kEXZvqbq1uaiEQ7D74BMh9YiBgqt uN/F18cFPt8yiVVK3bgo2KkS/XgGaS4veeK+BkZYPP8LfdLBnFFHKYruXHYXkltdQrqW 5tFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1nXbjmGuO9YghPzUiSigrzs5/9GT5Q6NNhUBnZ5BL6o=; b=Fe0DXu6p1WpErcLp99u1NZhZt71zpMSjb2NvQs28bLgXMnelvA0V6pfOR2laDjF26U T9TTgnNtqlklDb2H+9At+zwWcNcYSI9cQxLlhGHqi5fF4YgC06JHVrPyEr8MKUakQXvd Nl5TJ3wuRjOt70b4OYJ9P4UGEE2DfO9EabQPrXFs64Hi4zq05NbKynu/6NE2Oqmz8hkL 60AShmyDFySJvhriPpoBt3EGA86+JwWvYMdFv+U9k1gezjGCUVb/ZgWyzrjLfrxxu6Ez fCanxEzqfxahRU9cywXaNJFDhtCExM9nb35fExyaR1OZ70+I4knW3u9/fINsw9zQYc9O 6N2Q== X-Gm-Message-State: AOAM5320RHY7h67cs1A4LKrWwV66tNlpKLchrAo+GEW5EgecqJKhhdvm 7D0USNzeKNrGFh2MdL81jloppSDTmVTfv+70ebYdBA== X-Google-Smtp-Source: ABdhPJwv6SUxAiJU3OMeQLtrnFcvI/h1iY82pIlt6qbyAGsh50kqhWEDWLaUBKiAJzLF7/INflMcJGpqQT2M4cbcb6s= X-Received: by 2002:a05:6a00:15ca:: with SMTP id o10mr16122175pfu.169.1593462589513; Mon, 29 Jun 2020 13:29:49 -0700 (PDT) MIME-Version: 1.0 References: <20200629061840.4065483-1-keescook@chromium.org> <20200629061840.4065483-9-keescook@chromium.org> <9b7f9c3aed7223e49def6e775d3b250aa780e562.camel@perches.com> In-Reply-To: <9b7f9c3aed7223e49def6e775d3b250aa780e562.camel@perches.com> From: Nick Desaulniers Date: Mon, 29 Jun 2020 13:29:38 -0700 Message-ID: Subject: Re: [PATCH v4 08/17] arm64/mm: Remove needless section quotes To: Joe Perches Cc: Kees Cook , Will Deacon , Catalin Marinas , Mark Rutland , Ard Biesheuvel , Peter Collingbourne , James Morse , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Russell King , Masahiro Yamada , Arvind Sankar , Nathan Chancellor , Arnd Bergmann , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , clang-built-linux , linux-arch , linux-efi , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 29, 2020 at 1:03 PM Joe Perches wrote: > > On Mon, 2020-06-29 at 12:53 -0700, Nick Desaulniers wrote: > > On Sun, Jun 28, 2020 at 11:18 PM Kees Cook wrote: > > > Fix a case of needless quotes in __section(), which Clang doesn't like. > > > > > > Acked-by: Will Deacon > > > Signed-off-by: Kees Cook > > > > Yep, I remember bugs from this. Probably should scan the kernel for > > other instances of this. +Joe for checkpatch.pl validation. > > Reviewed-by: Nick Desaulniers > > $ git grep -P -n '__section\s*\(\s*\"' > arch/arm64/mm/mmu.c:45:u64 __section(".mmuoff.data.write") vabits_actual; > include/linux/compiler.h:211: __section("___kentry" "+" #sym ) \ > include/linux/export.h:133: static int __ksym_marker_##sym[0] __section(".discard.ksym") __used > include/linux/srcutree.h:127: __section("___srcu_struct_ptrs") = &name > > My recollection is I submitted a patch > to _add_ quotes > > https://lore.kernel.org/patchwork/patch/1125785/ Hey, yeah! Did you end up sending v2? -- Thanks, ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Desaulniers Subject: Re: [PATCH v4 08/17] arm64/mm: Remove needless section quotes Date: Mon, 29 Jun 2020 13:29:38 -0700 Message-ID: References: <20200629061840.4065483-1-keescook@chromium.org> <20200629061840.4065483-9-keescook@chromium.org> <9b7f9c3aed7223e49def6e775d3b250aa780e562.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731827AbgF2U3u (ORCPT ); Mon, 29 Jun 2020 16:29:50 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 302B5C03E979 for ; Mon, 29 Jun 2020 13:29:50 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id j19so1964521pgm.11 for ; Mon, 29 Jun 2020 13:29:50 -0700 (PDT) In-Reply-To: <9b7f9c3aed7223e49def6e775d3b250aa780e562.camel@perches.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Joe Perches Cc: Kees Cook , Will Deacon , Catalin Marinas , Mark Rutland , Ard Biesheuvel , Peter Collingbourne , James Morse , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Russell King , Masahiro Yamada , Arvind Sankar , Nathan Chancellor , Arnd Bergmann , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , clang-built-linux , linux-arch , linux-efi , L On Mon, Jun 29, 2020 at 1:03 PM Joe Perches wrote: > > On Mon, 2020-06-29 at 12:53 -0700, Nick Desaulniers wrote: > > On Sun, Jun 28, 2020 at 11:18 PM Kees Cook wrote: > > > Fix a case of needless quotes in __section(), which Clang doesn't like. > > > > > > Acked-by: Will Deacon > > > Signed-off-by: Kees Cook > > > > Yep, I remember bugs from this. Probably should scan the kernel for > > other instances of this. +Joe for checkpatch.pl validation. > > Reviewed-by: Nick Desaulniers > > $ git grep -P -n '__section\s*\(\s*\"' > arch/arm64/mm/mmu.c:45:u64 __section(".mmuoff.data.write") vabits_actual; > include/linux/compiler.h:211: __section("___kentry" "+" #sym ) \ > include/linux/export.h:133: static int __ksym_marker_##sym[0] __section(".discard.ksym") __used > include/linux/srcutree.h:127: __section("___srcu_struct_ptrs") = &name > > My recollection is I submitted a patch > to _add_ quotes > > https://lore.kernel.org/patchwork/patch/1125785/ Hey, yeah! Did you end up sending v2? -- Thanks, ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF784C433E0 for ; Mon, 29 Jun 2020 20:31:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B03D7206C0 for ; Mon, 29 Jun 2020 20:31:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3XUGD+Ap"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="eQJ4C1Og" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B03D7206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=00U3F4A1W6o5t5DIgXA/V/6lU++NbPzxK+5z4onQSfw=; b=3XUGD+ApTp6tmPmfob5COTML8 caWVjm5z9BiE3KbBRglyr+4cLwOFkkTfaA9cOsOM1xdTRXONC7McI9LUaTBdBluTQXckTRV0TYK6D 6v3TST2chH7h09d7yXThSF/ejL9f0lJEXcsMl42wXdVFRN8Mg7Dm5hJjxZk1IH3gvxk52yTUVp012 hLRAJ27+f61mfeYXkr0ILfE6hG354MF/XKhVtcn4/XAOQKWj+zZBVQ6dbjFb8DYUiL+9lSZaj9c9y Kq+QB59OebeYKnCCfOjls3O1xuqASWh0HyC9LbRcpG+YX9U7j8hqEhabl2bqqtqjbqT1qrT4Bx0YV pZHUOkXCg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jq0Pb-000717-6C; Mon, 29 Jun 2020 20:29:55 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jq0PX-00070O-Nv for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 20:29:53 +0000 Received: by mail-pg1-x543.google.com with SMTP id e18so8826897pgn.7 for ; Mon, 29 Jun 2020 13:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1nXbjmGuO9YghPzUiSigrzs5/9GT5Q6NNhUBnZ5BL6o=; b=eQJ4C1Og5DxGMyP8fWLcdR8Z3CwksZFnIGnuQop7YqAIDkKSYG4ONb22hCetVI2dMa XlTHs1YnKZwKbNTsc1vYgLQApn6CEsy11cVvAH0W8MA9tpog/jILDFawLHvAbnz6wbLc MOr/DpyFN5amUZuAcTF6xCkw3l5ZA5IZ2aVkLt4pQ4hbAulAODM2O4kjrlBTBDFdFrsk HN+QhWO3ClmIpA86xpuWF6l/Rt/cKlJGag5/A6V0kEXZvqbq1uaiEQ7D74BMh9YiBgqt uN/F18cFPt8yiVVK3bgo2KkS/XgGaS4veeK+BkZYPP8LfdLBnFFHKYruXHYXkltdQrqW 5tFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1nXbjmGuO9YghPzUiSigrzs5/9GT5Q6NNhUBnZ5BL6o=; b=nFU8cGRw0y5nQumni0im4mgiRXb+VraS66xIBsa6Ybvd9TE5LZV2z3G96AIprWnov7 nKPxX8n8zM9vJMEAB0V5yZ7avLZD/ZKG6cBXoDSxsAJlCbSPhI6Ev7VoTB9CNoa4oyLg be8/1dwoL8QJoF7BkrsM6joV0lWw94yCg38KYCZ9PItvT9fn7lnGgmfBnqPJnO/fdj6g H5bTbPzZ+AcWSl9v52jyY0C2gaSyE725z05AMFA0tadpVontVuiP9SnhwiyQ+voUkoGb TfLrOwYibSGyRJ471rellau0SXbieHISJBZ5PfJWS0ldbUMEo1OX2LaGv3wgR1eEBAaC eIpQ== X-Gm-Message-State: AOAM5317XpNVkvgMVRvFyxEdTLZA8kwUsABsLS+pcxbJZ6jgqIL8EKew QaQE+8I84otS6IbP6vkI4BRQ+0NruCPn1RsmfDhh/g== X-Google-Smtp-Source: ABdhPJwv6SUxAiJU3OMeQLtrnFcvI/h1iY82pIlt6qbyAGsh50kqhWEDWLaUBKiAJzLF7/INflMcJGpqQT2M4cbcb6s= X-Received: by 2002:a05:6a00:15ca:: with SMTP id o10mr16122175pfu.169.1593462589513; Mon, 29 Jun 2020 13:29:49 -0700 (PDT) MIME-Version: 1.0 References: <20200629061840.4065483-1-keescook@chromium.org> <20200629061840.4065483-9-keescook@chromium.org> <9b7f9c3aed7223e49def6e775d3b250aa780e562.camel@perches.com> In-Reply-To: <9b7f9c3aed7223e49def6e775d3b250aa780e562.camel@perches.com> From: Nick Desaulniers Date: Mon, 29 Jun 2020 13:29:38 -0700 Message-ID: Subject: Re: [PATCH v4 08/17] arm64/mm: Remove needless section quotes To: Joe Perches X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch , linux-efi , Kees Cook , Arnd Bergmann , Peter Collingbourne , Catalin Marinas , Masahiro Yamada , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Russell King , LKML , Nathan Chancellor , clang-built-linux , Arvind Sankar , Ingo Molnar , James Morse , Thomas Gleixner , Borislav Petkov , Will Deacon , Ard Biesheuvel , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 1:03 PM Joe Perches wrote: > > On Mon, 2020-06-29 at 12:53 -0700, Nick Desaulniers wrote: > > On Sun, Jun 28, 2020 at 11:18 PM Kees Cook wrote: > > > Fix a case of needless quotes in __section(), which Clang doesn't like. > > > > > > Acked-by: Will Deacon > > > Signed-off-by: Kees Cook > > > > Yep, I remember bugs from this. Probably should scan the kernel for > > other instances of this. +Joe for checkpatch.pl validation. > > Reviewed-by: Nick Desaulniers > > $ git grep -P -n '__section\s*\(\s*\"' > arch/arm64/mm/mmu.c:45:u64 __section(".mmuoff.data.write") vabits_actual; > include/linux/compiler.h:211: __section("___kentry" "+" #sym ) \ > include/linux/export.h:133: static int __ksym_marker_##sym[0] __section(".discard.ksym") __used > include/linux/srcutree.h:127: __section("___srcu_struct_ptrs") = &name > > My recollection is I submitted a patch > to _add_ quotes > > https://lore.kernel.org/patchwork/patch/1125785/ Hey, yeah! Did you end up sending v2? -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel