From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62E3A1FC0 for ; Mon, 9 May 2022 17:09:11 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id b18so24932422lfv.9 for ; Mon, 09 May 2022 10:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qmNh/UlR00KzKm2embL/8KXGrDJlEF5LNSh8Qse0tHI=; b=XlxYVyti/+Q7NqrSdb22SAIl6Y2j55Yg5g2k37ctvzV1ktFvUd3+GBrrXaqN+9NFeY 6EJHldsP4pwcrjQ2xzBRUlRSmr1Qray+IZ0Azb6pH9oGWAA6cH1MqKDYqSoobESAB3Tt eRGYGGgOM/icKjcAIArV0t0cRsOS98O3uc3oCmKTiATpvxAJt2dw7pFRGKnsUp5Fy6+q XIPCiWfYfE/TS6cBhvExSO/fG7/pxV+Gc6ing+pOzWL/ysqhEjHBgLIYNRnpXIBuNHwt 4ZGKV+R/g8mxG2EAM+mfZqER4WmDuwtD4WjdICN3razEbRrdkjkeh/S/AOCAatbdqrDm dp9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qmNh/UlR00KzKm2embL/8KXGrDJlEF5LNSh8Qse0tHI=; b=jRDZigOFWYrp0BCun1UfjVkd8mFXGOoD8a1wjU29aohnur4yPayR8MnDTrURvUBqLT j8MWJ6Tv0WIT4+9ooHJEjAMWZxf4dPMKZaQQt8i9TactO/JD1nKuM/AhW0sUx5KwClM9 cL3elIDEwJPAyh3qbdH+TI6cr0Ktaq+UsRUHFeT/1Glcs9Tcv5N/MLJ8C2SrdyOBWtL3 hRTOKc3piN56tZrFWbzAA6lUITM25QhF5E0Uyn6s7i6syIG8X3QsaQ3lbKJniit5xzm1 yBgf+15UjF6bheCdWvGoc5QqZMnvgg3iI+2USLnnJj6AMclKjaumr4hObs7UUBCUotSR SLaQ== X-Gm-Message-State: AOAM531lmjZmE44SBttpib1OqVneZCK9hJDH0skc9PGgjQeGkNBhnjNn X4Vw3UadcwdVADgKwak58+8hNZZDgPq0ljWy5Rm7hQ== X-Google-Smtp-Source: ABdhPJwxw3I1e8oaAvfUjbq5Ev4Yd8NjV0buUyZoAzr7cbILcvl2TRmROPbsKEb/6HUIdbYLzAigXpP3dNIEtdsX6aE= X-Received: by 2002:a05:6512:1d1:b0:471:f63a:b182 with SMTP id f17-20020a05651201d100b00471f63ab182mr13052968lfp.392.1652116149145; Mon, 09 May 2022 10:09:09 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220508190631.2386038-1-masahiroy@kernel.org> <20220508190631.2386038-2-masahiroy@kernel.org> In-Reply-To: <20220508190631.2386038-2-masahiroy@kernel.org> From: Nick Desaulniers Date: Mon, 9 May 2022 10:08:57 -0700 Message-ID: Subject: Re: [PATCH v4 01/14] modpost: remove left-over cross_compile declaration To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Nicolas Schier , Peter Zijlstra , linux-modules@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ard Biesheuvel , Sami Tolvanen , clang-built-linux Content-Type: text/plain; charset="UTF-8" On Sun, May 8, 2022 at 12:09 PM Masahiro Yamada wrote: > > This is a remnant of commit 6543becf26ff ("mod/file2alias: make > modalias generation safe for cross compiling"). > > Signed-off-by: Masahiro Yamada Thanks for the patch! (I wonder if we should put our old mailing list in .mailmap?) Reviewed-by: Nick Desaulniers > --- > > Changes in v4: > - New patch > > scripts/mod/modpost.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/scripts/mod/modpost.h b/scripts/mod/modpost.h > index cfa127d2bb8f..d9daeff07b83 100644 > --- a/scripts/mod/modpost.h > +++ b/scripts/mod/modpost.h > @@ -174,7 +174,6 @@ static inline unsigned int get_secindex(const struct elf_info *info, > } > > /* file2alias.c */ > -extern unsigned int cross_build; > void handle_moddevtable(struct module *mod, struct elf_info *info, > Elf_Sym *sym, const char *symname); > void add_moddevtable(struct buffer *buf, struct module *mod); > -- -- Thanks, ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2B5FC433EF for ; Mon, 9 May 2022 17:09:54 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KxnjF0SW2z3cGD for ; Tue, 10 May 2022 03:09:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=XlxYVyti; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2a00:1450:4864:20::135; helo=mail-lf1-x135.google.com; envelope-from=ndesaulniers@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=XlxYVyti; dkim-atps=neutral Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KxnhX2ZrGz2xXw for ; Tue, 10 May 2022 03:09:14 +1000 (AEST) Received: by mail-lf1-x135.google.com with SMTP id p26so11675390lfh.10 for ; Mon, 09 May 2022 10:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qmNh/UlR00KzKm2embL/8KXGrDJlEF5LNSh8Qse0tHI=; b=XlxYVyti/+Q7NqrSdb22SAIl6Y2j55Yg5g2k37ctvzV1ktFvUd3+GBrrXaqN+9NFeY 6EJHldsP4pwcrjQ2xzBRUlRSmr1Qray+IZ0Azb6pH9oGWAA6cH1MqKDYqSoobESAB3Tt eRGYGGgOM/icKjcAIArV0t0cRsOS98O3uc3oCmKTiATpvxAJt2dw7pFRGKnsUp5Fy6+q XIPCiWfYfE/TS6cBhvExSO/fG7/pxV+Gc6ing+pOzWL/ysqhEjHBgLIYNRnpXIBuNHwt 4ZGKV+R/g8mxG2EAM+mfZqER4WmDuwtD4WjdICN3razEbRrdkjkeh/S/AOCAatbdqrDm dp9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qmNh/UlR00KzKm2embL/8KXGrDJlEF5LNSh8Qse0tHI=; b=Oka+rXKRuTU3LZmecZbjPdk+VNYHkOzEzt8KOZTCCtvCnwBxgLE/49aXcrYeQV4kgm IiRrKYG47KOtBMtn1YVFnwu6DYaG5vhcE5EK6oi61LvHCdvetBi0WlIwOee2Hy8QCBr1 7dMjPqGv328WgzD48hoj5FIr3OVonfbWOK5XojDAIh6lmMq9Y+M06Wndtu3F2NaLHt+B 8Iua++1WwuihfTrj9BsMm6bC2ib76sialcYixwlUhgNQYEqCxBtwZQOl41cX8eAqQ7hy ZPN8A5m6b4Xt2CJJQZCtgWoQgCxVToI44KOjt6UrulvDZ71ceACppPjtCIOQrqEbKd4k uh/g== X-Gm-Message-State: AOAM532Q6bd0I9HBBCdRPp59JOKJhiPq52RWw1XiMmR23x5bpjQ4Bbbw PG9Shdlres/WCL5aQCUhx6SJI/4lvS9wPxeiT1M9Xg== X-Google-Smtp-Source: ABdhPJwxw3I1e8oaAvfUjbq5Ev4Yd8NjV0buUyZoAzr7cbILcvl2TRmROPbsKEb/6HUIdbYLzAigXpP3dNIEtdsX6aE= X-Received: by 2002:a05:6512:1d1:b0:471:f63a:b182 with SMTP id f17-20020a05651201d100b00471f63ab182mr13052968lfp.392.1652116149145; Mon, 09 May 2022 10:09:09 -0700 (PDT) MIME-Version: 1.0 References: <20220508190631.2386038-1-masahiroy@kernel.org> <20220508190631.2386038-2-masahiroy@kernel.org> In-Reply-To: <20220508190631.2386038-2-masahiroy@kernel.org> From: Nick Desaulniers Date: Mon, 9 May 2022 10:08:57 -0700 Message-ID: Subject: Re: [PATCH v4 01/14] modpost: remove left-over cross_compile declaration To: Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, Nicolas Schier , linux-kbuild@vger.kernel.org, Peter Zijlstra , clang-built-linux , linux-kernel@vger.kernel.org, Nathan Chancellor , Sami Tolvanen , linuxppc-dev@lists.ozlabs.org, Ard Biesheuvel , linux-modules@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, May 8, 2022 at 12:09 PM Masahiro Yamada wrote: > > This is a remnant of commit 6543becf26ff ("mod/file2alias: make > modalias generation safe for cross compiling"). > > Signed-off-by: Masahiro Yamada Thanks for the patch! (I wonder if we should put our old mailing list in .mailmap?) Reviewed-by: Nick Desaulniers > --- > > Changes in v4: > - New patch > > scripts/mod/modpost.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/scripts/mod/modpost.h b/scripts/mod/modpost.h > index cfa127d2bb8f..d9daeff07b83 100644 > --- a/scripts/mod/modpost.h > +++ b/scripts/mod/modpost.h > @@ -174,7 +174,6 @@ static inline unsigned int get_secindex(const struct elf_info *info, > } > > /* file2alias.c */ > -extern unsigned int cross_build; > void handle_moddevtable(struct module *mod, struct elf_info *info, > Elf_Sym *sym, const char *symname); > void add_moddevtable(struct buffer *buf, struct module *mod); > -- -- Thanks, ~Nick Desaulniers