From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FDD3FA373E for ; Tue, 25 Oct 2022 18:01:18 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 900E741133; Tue, 25 Oct 2022 20:01:17 +0200 (CEST) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by mails.dpdk.org (Postfix) with ESMTP id EDB2E410D2 for ; Tue, 25 Oct 2022 20:01:15 +0200 (CEST) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-36a4b86a0abso106078557b3.7 for ; Tue, 25 Oct 2022 11:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1MSX+BG7PSh5V0Vko84PyaGFbB+vRYwzACtuySRidjE=; b=OP4l/V4qXncT059GwzkqxGZ9dTDsdjeSlw4l1rBZeWsPPQzLQpoeySnOBUm+1wIEhL 5VbAzm4TuBBsIP/HloLmfwzuen4RXyTrjAFOTT/DvkE15DWPnq0uTK04GIfIp26zfhvV yjgzFIclMjB7TR6KjWgL6I0L2JQ58tQ6/czO97xVjblfKHG0vLxzdGMVJKogiT2YeO7R Kw7OImEUEYWk7dX/baekj+tzK99qlv3H1aDRBq/Rw1sADuNPmix31mGx1ylO8wCgw18s rp9gwcGGS2SwOat2EIf0q6PFG+yoKmueVqMAttYKtsZkQiEUVPq7l02yThwU6YTuX1aT TnWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1MSX+BG7PSh5V0Vko84PyaGFbB+vRYwzACtuySRidjE=; b=fcqsw/bvpbcppaaGXrz0riE8hRrErwwdN7NNwru5LGECACME2qD8tOXzp5bkzNPRo1 F/MfW5IqVnKQ5tZKdV7+LWh6UE4FmLec28vuAezJu06EGuST2O8Ue14+puMBeVxIA8gz WIa0P0iL+D8+Xa+IKNqvV/pzpYnOB/Ga0OganwQT6VhlID8Tg/hLGbPfGEr+wPB0uqaL QZWhqsK+8ffBBOXJkno+md0hJH9mK5A9F+rx9BijVMGWM+87CjMs3+0fpcAnqJAf4Q2w e+zCnKeh7D65f1/VsWS2BlUn6zHgf0y674Dhj7NmfkIE5Nl1XhnXHG4qdyRC8y8bmuZN JuBA== X-Gm-Message-State: ACrzQf3JKyELsGNYL84YfVoGjk81OzS7MhTAcvOYbfcxzesnzMl3BmOA O2Isz9QdcVlkGRXujooAjbH1xW8vi6cQyPYg3QmQpGBLzXI= X-Google-Smtp-Source: AMsMyM65QPSMZAzzVyYmyCTCHB4Z2A9/BRC+K1lkbL/45OUflsM3PakXOADy7Khc5756mVGW9trum3svsJ2JYheVsMc= X-Received: by 2002:a81:9a8f:0:b0:36f:d05d:b59a with SMTP id r137-20020a819a8f000000b0036fd05db59amr2525371ywg.180.1666720875288; Tue, 25 Oct 2022 11:01:15 -0700 (PDT) MIME-Version: 1.0 References: <20220726213618.142173-1-stephen@networkplumber.org> <20221021130525.46732044@hermes.local> In-Reply-To: <20221021130525.46732044@hermes.local> From: Ben Magistro Date: Tue, 25 Oct 2022 14:01:04 -0400 Message-ID: Subject: Re: [RFC] pcapng: record received RSS hash in pcap file To: Stephen Hemminger Cc: dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000b62bd405ebdfb1be" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000b62bd405ebdfb1be Content-Type: text/plain; charset="UTF-8" Tested with Wireshark 4.1.0rc0-599-g708da4852678 (and older version to confirm no issues) Tested-by: Ben Magistro On Fri, Oct 21, 2022 at 4:05 PM Stephen Hemminger < stephen@networkplumber.org> wrote: > On Tue, 26 Jul 2022 14:36:19 -0700 > Stephen Hemminger wrote: > > > There is an option for recording RSS hash with packets in the > > pcapng standard. This implements this for all received packets. > > > > There is a corner case that can not be addressed with current > > DPDK API's. If using rte_flow() and some hardware it is possible > > to write a flow rule that uses another hash function like XOR. > > But there is no API that records this, or provides the algorithm > > info on a per-packet basis. > > > > The current version of wireshark does not display the recorded > > hash option. But if we build it they will come. > > Support for displaying RSS hash in record has been merged into > Wireshark for 4.1 release. > > Could this please be acked and merged. > --000000000000b62bd405ebdfb1be Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Tested with Wireshark=C2=A04.1.0rc0-599-g708da4852678 (and= older version to confirm no issues)

Tested-by: Ben Magi= stro <koncept1@g= mail.com>

On Fri, Oct 21, 2022 at 4:05 PM Stephen Hemminger <= ;stephen@networkplumber.org> wrote:
On= Tue, 26 Jul 2022 14:36:19 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> There is an option for recording RSS hash with packets in the
> pcapng standard. This implements this for all received packets.
>
> There is a corner case that can not be addressed with current
> DPDK API's. If using rte_flow() and some hardware it is possible > to write a flow rule that uses another hash function like XOR.
> But there is no API that records this, or provides the algorithm
> info on a per-packet basis.
>
> The current version of wireshark does not display the recorded
> hash option. But if we build it they will come.

Support for displaying RSS hash in record has been merged into
Wireshark for 4.1 release.

Could this please be acked and merged.
--000000000000b62bd405ebdfb1be--